Skip to contentSkip to conversation

Fix SES timeout

PATCH In review Matthew Wilcox 2 participants 2 messages Jun 23, 2008 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 Fix SES timeout

Timeouts are measured in jiffies, not in seconds.

drivers/scsi/ses.c +1 -1
index 45df83b..351bce7 100644
@@ -61,7 +61,7 @@ static int ses_probe(struct device *dev)
 	return err;
 }
 
-#define SES_TIMEOUT 30
+#define SES_TIMEOUT (30 * HZ)
 #define SES_RETRIES 3
 
 static int ses_recv_diag(struct scsi_device *sdev, int page_code,
Signature · 4 lines
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
maintainer
#1 lore raw
Quoted 1 line · Matthew Wilcox

Timeouts are measured in jiffies, not in seconds.

That's a bit of a brown paper bag one; thanks.

It's not really part of the series (fortunately) because it needs to be in -rc fixes and backported to stable.

James