Skip to contentSkip to conversation

Convert SES to use scsi_get_vpd_page

PATCH In review Matthew Wilcox 1 participant 1 message Jun 23, 2008 SCSI

lore
Share & tools
lore

Matthew Wilcox

author
#0 lore raw

PATCH 4/4 Convert SES to use scsi_get_vpd_page

SES had its own code to retrieve VPD from devices; convert it to use the new scsi_get_vpd_page helper.

Signed-off-by Matthew Wilcox <[email protected]>
drivers/scsi/ses.c +1 -15
index 45df83b..351bce7 100644
@@ -356,21 +356,7 @@ static void ses_match_to_enclosure(struct enclosure_device *edev,
 	struct efd efd = {
 		.addr = 0,
 	};
-	unsigned char cmd[] = {
-		INQUIRY,
-		1,
-		0x83,
-		VPD_INQUIRY_SIZE >> 8,
-		VPD_INQUIRY_SIZE & 0xff,
-		0
-	};
-
-	if (!buf)
-		return;
-
-	if (scsi_execute_req(sdev, cmd, DMA_FROM_DEVICE, buf,
-			     VPD_INQUIRY_SIZE, NULL, SES_TIMEOUT, SES_RETRIES))
-		goto free;
+	scsi_get_vpd_page(sdev, buf, 0x83, VPD_INQUIRY_SIZE);
 
 	len = (buf[2] << 8) + buf[3];
 	desc = buf + 4;
Signature · 4 lines
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."