Skip to contentSkip to conversation

softlockup: print a module list on being stuck

PATCH New Ingo Molnar 1 participant 1 message Jun 25, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 softlockup: print a module list on being stuck

Linus,

Arjan has been observing lots of softlockup reports on kerneloops.org and would like to have the patch below in v2.6.26 to narrow the real source of it down some more, and has asked for this patch to be applied sooner than planned.

The patch is queued up for the next merge window at the moment. It's well-tested and obvious. The module list is printed here the same way it's printed for oopses.

Discard it if you feel in any way nervous about it.

Ingo

---------------->
commit 688c91755dc3d3c03d8c67c1df13c02be258768e
Author: Arjan van de Ven <[email protected]>
Date: Mon Jun 16 15:51:08 2008 -0700
CommitDate: Wed Jun 18 15:26:54 2008 +0200

softlockup: print a module list on being stuck

Most places in the kernel that go BUG: print a module list (which is very useful for doing statistics and finding patterns), however the softlockup detector does not do this yet.

This patch adds the one line change to fix this gap.

kernel/softlockup.c +1 -0
index 6b682d8..f2bf5de 100644
@@ -143,6 +143,7 @@ void softlockup_tick(void)
 	printk(KERN_ERR "BUG: soft lockup - CPU#%d stuck for %lus! [%s:%d]\n",
 			this_cpu, now - touch_timestamp,
 			current->comm, task_pid_nr(current));
+	print_modules();
 	if (regs)
 		show_regs(regs);
 	else