Skip to contentSkip to conversation

x86: enable pat on amd athlon mode=6

PATCH Bernd Schubert 2 participants 4 messages Jun 25, 2008 x86

lore
Share & tools
lore
#0 lore raw

Hello,

on my AthlonXP 1700 PAT works fine (I tested it several days). Please accept one of the patches below, I don't know which you refer.

Patch to enable PAT specifically on model=6

arch/x86/kernel/cpu/addon_cpuid_features.c +2 -0
index c2e1ce3..61a5aa5 100644
@@ -57,6 +57,8 @@ void __cpuinit validate_pat_support(struct cpuinfo_x86 *c)
 	case X86_VENDOR_AMD:
 		if (c->x86 >= 0xf && c->x86 <= 0x11)
 			return;
+		if (c->x86 == 0x6)
+			return;
 		break;
 	case X86_VENDOR_INTEL:
 		if (c->x86 == 0xF || (c->x86 == 6 && c->x86_model >= 15))

Or maybe PAT on all system >=6 is suitable?

arch/x86/kernel/cpu/addon_cpuid_features.c +1 -1
index c2e1ce3..f12c413 100644
@@ -55,7 +55,7 @@ void __cpuinit validate_pat_support(struct cpuinfo_x86 *c)
 {
 	switch (c->x86_vendor) {
 	case X86_VENDOR_AMD:
-		if (c->x86 >= 0xf && c->x86 <= 0x11)
+		if (c->x86 >= 0x6 && c->x86 <= 0x11)
 			return;
 		break;
 	case X86_VENDOR_INTEL:

Thanks,
Bernd

#1 lore raw
Quoted 4 lines · Bernd Schubert

on my AthlonXP 1700 PAT works fine (I tested it several days). Please accept one of the patches below, I don't know which you refer.

Yes, PAT works equally well on my earlier model 6. The setup's already changed in linux-next though and now blacklists some Intel models only:

http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=blob;f=arch/x86/kernel/cpu/addon_cpuid_features.c;h=84a8220a6072c0425b9da95fbb28b5a309cbfda1;hb=HEAD

Rene.

#2 lore raw
Quoted 10 lines · Rene Herman
Quoted 4 lines · Bernd Schubert

on my AthlonXP 1700 PAT works fine (I tested it several days). Please accept one of the patches below, I don't know which you refer.

Yes, PAT works equally well on my earlier model 6. The setup's already changed in linux-next though and now blacklists some Intel models only:

http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=blob;f=arch/x86/kernel/cpu/addon_cpuid_features.c;h=84a8220a6072c0425b9da95fbb28b5a309cbfda1;hb=HEAD

Well, if I provide a link, I might as well look at it myself I guess...

Earlier patches on linux-kernel did the white->black list switching but as you can see that in linux-next at least all of AMD is already whitelisted.

Rene.

#3 lore raw
Quoted 14 lines · Rene Herman
Quoted 4 lines · Rene Herman
Quoted 3 lines · Bernd Schubert

on my AthlonXP 1700 PAT works fine (I tested it several days). Please accept one of the patches below, I don't know which you refer.

Quoted 8 lines
Quoted 1 line

Yes, PAT works equally well on my earlier model 6. The setup's already changed in linux-next though and now blacklists some Intel models only:

http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=blob;f=arc
h/x86/kernel/cpu/addon_cpuid_features.c;h=84a8220a6072c0425b9da95fbb28b5a3 09cbfda1;hb=HEAD

Quoted 5 lines

Well, if I provide a link, I might as well look at it myself I guess...

Earlier patches on linux-kernel did the white->black list switching but as you can see that in linux-next at least all of AMD is already whitelisted.

Great, thanks!

Cheers,
Bernd