drivers/power: fix platform driver hotplug/coldplug
PATCH 1/1 drivers/power: fix platform driver hotplug/coldplug
From: Kay Sievers <[email protected]>
Since 43cc71eed1250755986da4c0f9898f9a635cb3bf, the platform modalias is prefixed with "platform:". Add MODULE_ALIAS() to the hotpluggable "power" drivers drivers, to re-enable auto loading.
--- drivers/power/ds2760_battery.c | 2 ++ drivers/power/pda_power.c | 2 ++ 2 files changed, 4 insertions(+)
drivers/power/ds2760_battery.c +2 -0
@@ -433,6 +433,8 @@ static int ds2760_battery_resume(struct#endif /* CONFIG_PM */ +MODULE_ALIAS ("platform:ds2760-battery" ); +static struct platform_driver ds2760_battery_driver = { .driver = { .name ="ds2760-battery" ,
drivers/power/pda_power.c +2 -0
@@ -362,6 +362,8 @@ static int pda_power_resume(struct platf#define pda_power_resume NULL#endif /* CONFIG_PM */ +MODULE_ALIAS ("platform:pda-power" ); +static struct platform_driver pda_power_pdrv = { .driver = { .name ="pda-power" ,
Quoted 3 lines · On Wed, 2 Jul 2008 00:13:14 -0700 David Brownell <[email protected]> wrote:
From: Kay Sievers <[email protected]>
Since
43cc71eed1250755986da4c0f9898f9a635cb3bf
Linus chucks a wobbly if we quote bare SHA hashes at him. I updated the changelog appropriately.
Quoted 26 lines
, the platform
modalias is prefixed with "platform:". AddMODULE_ALIAS()to the hotpluggable "power" drivers drivers, to re-enable auto loading.Signed-off-by Kay Sievers <[email protected]>[ [email protected]: one was missing ]Signed-off-by David Brownell <[email protected]>--- drivers/power/ds2760_battery.c | 2 ++ drivers/power/pda_power.c | 2 ++ 2 files changed, 4 insertions(+)drivers/power/ds2760_battery.c +2
-0@@ -433,6 +433,8 @@ static int ds2760_battery_resume(struct#endif /* CONFIG_PM */ +MODULE_ALIAS ("platform:ds2760-battery" ); +static struct platform_driver ds2760_battery_driver = { .driver = { .name ="ds2760-battery" ,
drivers/power/pda_power.c static int pda_power_resume(struct platf · line 369
Quoted 8 lines
drivers/power/pda_power.c +2
-0@@ -362,6 +362,8 @@ static int pda_power_resume(struct platf#define pda_power_resume NULL#endif /* CONFIG_PM */ +MODULE_ALIAS ("platform:pda-power" ); +static struct platform_driver pda_power_pdrv = { .driver = { .name ="pda-power" ,
Do we think this is needed in 2.6.26?
In 2.6.25.x?
Quoted 3 lines · Andrew Morton
Do we think this is needed in 2.6.26?
In 2.6.25.x?
I don't think either. Arguably this particular type of driver should always be statically linked. And these are new enough that they weren't hit by the regression (fix) aspect of $PATCH.
- Dave