s390: bus_id -> dev_name conversions
Subsystems (7)
PATCH 1/4 s390: bus_id -> dev_name conversions
From: Kay Sievers <[email protected]>
bus_id -> dev_name() conversions in s390 code.
This is done in anticipation of removing the bus_id field from struct driver.
--- drivers/s390/block/dasd.c | 32 ++++----- drivers/s390/block/dasd_3990_erp.c | 2 drivers/s390/block/dasd_devmap.c | 28 ++++---- drivers/s390/block/dasd_eckd.c | 6 - drivers/s390/block/dasd_eer.c | 4 - drivers/s390/block/dasd_fba.c | 4 - drivers/s390/block/dasd_int.h | 4 - drivers/s390/block/dasd_proc.c | 2 drivers/s390/block/dcssblk.c | 5 - drivers/s390/char/tape_3590.c | 129 ++++++++++++++++++------------------- drivers/s390/char/tape_block.c | 2 drivers/s390/char/tape_core.c | 20 ++--- drivers/s390/char/tape_proc.c | 2 drivers/s390/char/tape_std.c | 12 +-- drivers/s390/char/vmlogrdr.c | 2 drivers/s390/char/vmur.c | 6 - drivers/s390/cio/ccwgroup.c | 2 drivers/s390/cio/cio.c | 18 ++--- drivers/s390/cio/device.c | 4 - drivers/s390/cio/device_fsm.c | 6 + drivers/s390/cio/device_ops.c | 2 drivers/s390/cio/qdio.c | 24 +++--- drivers/s390/net/claw.c | 30 ++++---- drivers/s390/net/claw.h | 2 drivers/s390/net/ctcm_main.c | 16 ++-- drivers/s390/net/ctcm_main.h | 2 drivers/s390/net/lcs.c | 30 ++++---- drivers/s390/net/netiucv.c | 2 drivers/s390/net/qeth_core.h | 10 +- drivers/s390/net/qeth_core_main.c | 10 +- drivers/s390/scsi/zfcp_def.h | 2 31 files changed, 212 insertions(+), 208 deletions(-)
drivers/s390/block/dasd_3990_erp.c +1 -1
@@ -1397,7 +1397,7 @@ static struct dasd_ccw_req *dasd_3990_erDEV_MESSAGE (KERN_ERR , cqr->startdev,"ERP on alias device for request %p," " recover on base device %s" , cqr, - cqr->block->base->cdev->dev.bus_id); +dev_name (&cqr->block->base->cdev->dev)); }dasd_eckd_reset_ccw_to_base_io (cqr); erp->startdev = cqr->block->base;
drivers/s390/block/dasd.c +16 -16
@@ -215,7 +215,7 @@ static int dasd_state_known_to_basic(strreturn rc; }/* register 'device' debug area, used for all DBF_DEV_XXX calls */ - device->debug_area =debug_register (device->cdev->dev.bus_id,1 ,1 , + device->debug_area =debug_register (dev_name (&device->cdev->dev),1 ,1 ,8 *sizeof (long ));debug_register_view (device->debug_area, &debug_sprintf_view);debug_set_level (device->debug_area,DBF_WARNING );
@@ -933,7 +933,7 @@ static void dasd_handle_killed_request(sMESSAGE (KERN_DEBUG ,"invalid status in handle_killed_request: " "bus_id %s, status %02x" , - cdev->dev.bus_id, cqr->status); +dev_name (&cdev->dev), cqr->status);return ; }
@@ -942,7 +942,7 @@ static void dasd_handle_killed_request(s device != dasd_device_from_cdev_locked(cdev) || strncmp(device->discipline->ebcname, (char *) &cqr->magic, 4)) {MESSAGE (KERN_DEBUG ,"invalid device in request: bus_id %s" , - cdev->dev.bus_id); +dev_name (&cdev->dev));return ; }
@@ -982,11 +982,11 @@ void dasd_int_handler(struct ccw_devicebreak ;case -ETIMEDOUT :printk (KERN_WARNING "%s(%s): request timed out\n" , - __func__, cdev->dev.bus_id); + __func__,dev_name (&cdev->dev));break ;default :printk (KERN_WARNING "%s(%s): unknown error %ld\n" , - __func__, cdev->dev.bus_id,PTR_ERR (irb)); + __func__,dev_name (&cdev->dev),PTR_ERR (irb)); }dasd_handle_killed_request (cdev, intparm);return ;
@@ -995,7 +995,7 @@ void dasd_int_handler(struct ccw_device now =get_clock ();DBF_EVENT (DBF_ERR ,"Interrupt: bus_id %s CS/DS %04x ip %08x" , - cdev->dev.bus_id, ((irb->scsw.cstat<<8 )|irb->scsw.dstat), +dev_name (&cdev->dev), ((irb->scsw.cstat<<8 )|irb->scsw.dstat), (unsigned int ) intparm);/* check for unsolicited interrupts */
@@ -1019,7 +1019,7 @@ void dasd_int_handler(struct ccw_deviceif (!device ||strncmp (device->discipline->ebcname, (char *) &cqr->magic,4 )) {MESSAGE (KERN_DEBUG ,"invalid device in request: bus_id %s" , - cdev->dev.bus_id); +dev_name (&cdev->dev));return ; }
@@ -1037,7 +1037,7 @@ void dasd_int_handler(struct ccw_deviceif (cqr->status !=DASD_CQR_IN_IO ) {MESSAGE (KERN_DEBUG ,"invalid status: bus_id %s, status %02x" , - cdev->dev.bus_id, cqr->status); +dev_name (&cdev->dev), cqr->status);return ; } DBF_DEV_EVENT(DBF_DEBUG, device, "Int: CS/DS 0x%04x for cqr %p",
@@ -2134,14 +2134,14 @@ int dasd_generic_probe(struct ccw_deviceif (ret) {printk (KERN_WARNING "dasd_generic_probe: could not set ccw-device options " -"for %s\n" , cdev->dev.bus_id); +"for %s\n" ,dev_name (&cdev->dev));return ret; } ret =dasd_add_sysfs_files (cdev);if (ret) {printk (KERN_WARNING "dasd_generic_probe: could not add sysfs entries " -"for %s\n" , cdev->dev.bus_id); +"for %s\n" ,dev_name (&cdev->dev));return ret; } cdev->handler = &dasd_int_handler;
@@ -2152,13 +2152,13 @@ int dasd_generic_probe(struct ccw_device* initial probe. */ if ((dasd_get_feature (cdev,DASD_FEATURE_INITIAL_ONLINE ) >0 ) || - (dasd_autodetect &&dasd_busid_known (cdev->dev.bus_id) !=0 )) + (dasd_autodetect &&dasd_busid_known (dev_name (&cdev->dev)) !=0 )) ret =ccw_device_set_online (cdev);if (ret)printk (KERN_WARNING "dasd_generic_probe: could not initially " "online ccw-device %s; return code: %d\n" , - cdev->dev.bus_id, ret); +dev_name (&cdev->dev), ret);return 0 ; }
@@ -2224,7 +2224,7 @@ int dasd_generic_set_online(struct ccw_dprintk (KERN_WARNING "dasd_generic couldn't online device %s " "- discipline DIAG not available\n" , - cdev->dev.bus_id); +dev_name (&cdev->dev));dasd_delete_device (device);return -ENODEV ; }
@@ -2248,7 +2248,7 @@ int dasd_generic_set_online(struct ccw_dprintk (KERN_WARNING "dasd_generic couldn't online device %s " "with discipline %s rc=%i\n" , - cdev->dev.bus_id, discipline->name, rc); +dev_name (&cdev->dev), discipline->name, rc);module_put (discipline->owner);module_put (base_discipline->owner);dasd_delete_device (device);
@@ -2259,7 +2259,7 @@ int dasd_generic_set_online(struct ccw_dif (device->state <=DASD_STATE_KNOWN ) {printk (KERN_WARNING "dasd_generic discipline not found for %s\n" , - cdev->dev.bus_id); +dev_name (&cdev->dev)); rc = -ENODEV ;dasd_set_target_state (device,DASD_STATE_NEW );if (device->block)
@@ -2267,7 +2267,7 @@ int dasd_generic_set_online(struct ccw_ddasd_delete_device (device); }else pr_debug ("dasd_generic device %s found\n" , - cdev->dev.bus_id); +dev_name (&cdev->dev));/* FIXME: we have to wait for the root device but we don't want * to wait for each single device but for all at once. */
drivers/s390/block/dasd_devmap.c +14 -14
@@ -515,9 +515,9 @@ dasd_devmap_from_cdev(struct ccw_device {struct dasd_devmap *devmap; - devmap =dasd_find_busid (cdev->dev.bus_id); + devmap =dasd_find_busid (dev_name (&cdev->dev));if (IS_ERR (devmap)) - devmap =dasd_add_busid (cdev->dev.bus_id, + devmap =dasd_add_busid (dev_name (&cdev->dev),DASD_FEATURE_DEFAULT );return devmap; }
@@ -584,7 +584,7 @@ dasd_delete_device(struct dasd_device *dunsigned long flags;/* First remove device pointer from devmap. */ - devmap =dasd_find_busid (device->cdev->dev.bus_id); + devmap =dasd_find_busid (dev_name (&device->cdev->dev));BUG_ON (IS_ERR (devmap));spin_lock (&dasd_devmap_lock);if (devmap->device != device) {
@@ -674,7 +674,7 @@ dasd_ro_show(struct device *dev, structstruct dasd_devmap *devmap;int ro_flag; - devmap =dasd_find_busid (dev->bus_id); + devmap =dasd_find_busid (dev_name (dev));if (!IS_ERR (devmap)) ro_flag = (devmap->features &DASD_FEATURE_READONLY ) !=0 ;else
@@ -723,7 +723,7 @@ dasd_erplog_show(struct device *dev, strstruct dasd_devmap *devmap;int erplog; - devmap =dasd_find_busid (dev->bus_id); + devmap =dasd_find_busid (dev_name (dev));if (!IS_ERR (devmap)) erplog = (devmap->features &DASD_FEATURE_ERPLOG ) !=0 ;else
@@ -770,7 +770,7 @@ dasd_use_diag_show(struct device *dev, sstruct dasd_devmap *devmap;int use_diag; - devmap =dasd_find_busid (dev->bus_id); + devmap =dasd_find_busid (dev_name (dev));if (!IS_ERR (devmap)) use_diag = (devmap->features &DASD_FEATURE_USEDIAG ) !=0 ;else
@@ -876,7 +876,7 @@ dasd_alias_show(struct device *dev, strustruct dasd_devmap *devmap;int alias; - devmap =dasd_find_busid (dev->bus_id); + devmap =dasd_find_busid (dev_name (dev));spin_lock (&dasd_devmap_lock);if (IS_ERR (devmap) ||strlen (devmap->uid.vendor) ==0 ) {spin_unlock (&dasd_devmap_lock);
@@ -899,7 +899,7 @@ dasd_vendor_show(struct device *dev, strstruct dasd_devmap *devmap;char *vendor; - devmap =dasd_find_busid (dev->bus_id); + devmap =dasd_find_busid (dev_name (dev));spin_lock (&dasd_devmap_lock);if (!IS_ERR (devmap) &&strlen (devmap->uid.vendor) >0 ) vendor = devmap->uid.vendor;
@@ -923,7 +923,7 @@ dasd_uid_show(struct device *dev, structchar ua_string[3 ];struct dasd_uid *uid; - devmap =dasd_find_busid (dev->bus_id); + devmap =dasd_find_busid (dev_name (dev));spin_lock (&dasd_devmap_lock);if (IS_ERR (devmap) ||strlen (devmap->uid.vendor) ==0 ) {spin_unlock (&dasd_devmap_lock);
@@ -962,7 +962,7 @@ dasd_eer_show(struct device *dev, structstruct dasd_devmap *devmap;int eer_flag; - devmap =dasd_find_busid (dev->bus_id); + devmap =dasd_find_busid (dev_name (dev));if (!IS_ERR (devmap) && devmap->device) eer_flag =dasd_eer_enabled (devmap->device);else
@@ -1024,7 +1024,7 @@ dasd_get_uid(struct ccw_device *cdev, st {struct dasd_devmap *devmap; - devmap =dasd_find_busid (cdev->dev.bus_id); + devmap =dasd_find_busid (dev_name (&cdev->dev));if (IS_ERR (devmap))return PTR_ERR (devmap);spin_lock (&dasd_devmap_lock);
@@ -1047,7 +1047,7 @@ dasd_set_uid(struct ccw_device *cdev, st {struct dasd_devmap *devmap; - devmap =dasd_find_busid (cdev->dev.bus_id); + devmap =dasd_find_busid (dev_name (&cdev->dev));if (IS_ERR (devmap))return PTR_ERR (devmap);
@@ -1067,7 +1067,7 @@ dasd_get_feature(struct ccw_device *cdev {struct dasd_devmap *devmap; - devmap =dasd_find_busid (cdev->dev.bus_id); + devmap =dasd_find_busid (dev_name (&cdev->dev));if (IS_ERR (devmap))return PTR_ERR (devmap);
@@ -1083,7 +1083,7 @@ dasd_set_feature(struct ccw_device *cdev {struct dasd_devmap *devmap; - devmap =dasd_find_busid (cdev->dev.bus_id); + devmap =dasd_find_busid (dev_name (&cdev->dev));if (IS_ERR (devmap))return PTR_ERR (devmap);
drivers/s390/block/dasd_eckd.c +3 -3
@@ -84,7 +84,7 @@ dasd_eckd_probe (struct ccw_device *cdevif (ret) {printk (KERN_WARNING "dasd_eckd_probe: could not set ccw-device options " -"for %s\n" , cdev->dev.bus_id); +"for %s\n" ,dev_name (&cdev->dev));return ret; } ret =dasd_generic_probe (cdev, &dasd_eckd_discipline);
@@ -2065,13 +2065,13 @@ static void dasd_eckd_dump_sense(struct/* dump the sense data */ len = sprintf(page, KERN_ERR PRINTK_HEADER" I/O status report for device %s:\n" , - device->cdev->dev.bus_id); +dev_name (&device->cdev->dev)); len += sprintf(page + len, KERN_ERR PRINTK_HEADER" in req: %p CS: 0x%02X DS: 0x%02X\n" , req, irb->scsw.cstat, irb->scsw.dstat); len += sprintf(page + len, KERN_ERR PRINTK_HEADER" device %s: Failing CCW: %p\n" , - device->cdev->dev.bus_id, +dev_name (&device->cdev->dev), (void *) (addr_t ) irb->scsw.cpa);if (irb->esw.esw0.erw.cons) {for (sl =0 ; sl <4 ; sl++) {
drivers/s390/block/dasd_eer.c +2 -2
@@ -307,7 +307,7 @@ static void dasd_eer_write_standard_trigdo_gettimeofday (&tv); header.tv_sec = tv.tv_sec; header.tv_usec = tv.tv_usec; -strncpy (header.busid, device->cdev->dev.bus_id,DASD_EER_BUSID_SIZE ); +strncpy (header.busid,dev_name (&device->cdev->dev),DASD_EER_BUSID_SIZE );spin_lock_irqsave (&bufferlock, flags);list_for_each_entry (eerb, &bufferlist, list) {
@@ -347,7 +347,7 @@ static void dasd_eer_write_snss_trigger(do_gettimeofday (&tv); header.tv_sec = tv.tv_sec; header.tv_usec = tv.tv_usec; -strncpy (header.busid, device->cdev->dev.bus_id,DASD_EER_BUSID_SIZE ); +strncpy (header.busid,dev_name (&device->cdev->dev),DASD_EER_BUSID_SIZE );spin_lock_irqsave (&bufferlock, flags);list_for_each_entry (eerb, &bufferlist, list) {
drivers/s390/block/dasd_fba.c +2 -2
@@ -446,13 +446,13 @@ dasd_fba_dump_sense(struct dasd_device * } len = sprintf(page, KERN_ERR PRINTK_HEADER" I/O status report for device %s:\n" , - device->cdev->dev.bus_id); +dev_name (&device->cdev->dev)); len += sprintf(page + len, KERN_ERR PRINTK_HEADER" in req: %p CS: 0x%02X DS: 0x%02X\n" , req, irb->scsw.cstat, irb->scsw.dstat); len += sprintf(page + len, KERN_ERR PRINTK_HEADER" device %s: Failing CCW: %p\n" , - device->cdev->dev.bus_id, +dev_name (&device->cdev->dev), (void *) (addr_t ) irb->scsw.cpa);if (irb->esw.esw0.erw.cons) {for (sl =0 ; sl <4 ; sl++) {
drivers/s390/block/dasd_int.h +2 -2
@@ -126,7 +126,7 @@ do { \ #define DEV_MESSAGE(d_loglevel,d_device,d_string,d_args...)\ do { \ printk(d_loglevel PRINTK_HEADER " %s: " d_string "\n", \ - d_device->cdev->dev.bus_id, d_args); \ + dev_name(&d_device->cdev->dev), d_args); \ DBF_DEV_EVENT(DBF_ALERT, d_device, d_string, d_args); \ } while(0)
@@ -140,7 +140,7 @@ do { \ #define DEV_MESSAGE_LOG(d_loglevel,d_device,d_string,d_args...)\ do { \ printk(d_loglevel PRINTK_HEADER " %s: " d_string "\n", \ - d_device->cdev->dev.bus_id, d_args); \ + dev_name(&d_device->cdev->dev), d_args); \ } while(0) #define MESSAGE_LOG(d_loglevel,d_string,d_args...)\
drivers/s390/block/dasd_proc.c +1 -1
@@ -67,7 +67,7 @@ dasd_devices_show(struct seq_file *m, voreturn 0 ; }/* Print device number. */ -seq_printf (m,"%s" , device->cdev->dev.bus_id); +seq_printf (m,"%s" ,dev_name (&device->cdev->dev));/* Print discipline string. */ if (device !=NULL && device->discipline !=NULL )seq_printf (m,"(%s)" , device->discipline->name);
drivers/s390/block/dcssblk.c +3 -2
@@ -91,7 +91,7 @@ static struct rw_semaphore dcssblk_devicstatic void dcssblk_release_segment (struct device *dev) { -PRINT_DEBUG ("segment release fn called for %s\n" , dev->bus_id); +PRINT_DEBUG ("segment release fn called for %s\n" ,dev_name (dev));kfree (container_of(dev ,struct dcssblk_dev_info ,dev ));module_put (THIS_MODULE ); }
@@ -604,7 +604,8 @@ dcssblk_make_request(struct request_queucase SEG_TYPE_SC :/* cannot write to these segments */ if (bio_data_dir (bio) ==WRITE ) { -PRINT_WARN ("rejecting write to ro segment %s\n" , dev_info->dev.bus_id); +PRINT_WARN ("rejecting write to ro segment %s\n" , +dev_name (&dev_info->dev)); goto fail; } }
drivers/s390/char/tape_3590.c +65 -64
391 lines not on this page · raw message
drivers/s390/char/tape_block.c +1 -1
@@ -278,7 +278,7 @@ tapeblock_cleanup_device(struct tape_devif (!device->blk_data.disk) {PRINT_ERR ("(%s): No gendisk to clean up!\n" , - device->cdev->dev.bus_id); +dev_name (&device->cdev->dev)); goto cleanup_queue; }
drivers/s390/char/tape_core.c +10 -10
@@ -215,12 +215,12 @@ tape_med_state_set(struct tape_device *dcase MS_UNLOADED : device->tape_generic_status |=GMT_DR_OPEN (~0 );PRINT_INFO ("(%s): Tape is unloaded\n" , - device->cdev->dev.bus_id); +dev_name (&device->cdev->dev));break ;case MS_LOADED : device->tape_generic_status &= ~GMT_DR_OPEN (~0 );PRINT_INFO ("(%s): Tape has been mounted\n" , - device->cdev->dev.bus_id); +dev_name (&device->cdev->dev));break ;default :// print nothing
@@ -415,7 +415,7 @@ tape_generic_offline(struct tape_device device->cdev_id);PRINT_WARN ("(%s): Set offline failed " "- drive in use.\n" , - device->cdev->dev.bus_id); +dev_name (&device->cdev->dev));spin_unlock_irq (get_ccwdev_lock (device->cdev));return -EBUSY ; }
@@ -538,7 +538,7 @@ tape_generic_probe(struct ccw_device *cd ret =sysfs_create_group (&cdev->dev.kobj, &tape_attr_group);if (ret) {tape_put_device (device); -PRINT_ERR ("probe failed for tape device %s\n" , cdev->dev.bus_id); +PRINT_ERR ("probe failed for tape device %s\n" ,dev_name (&cdev->dev));return ret; } cdev->dev.driver_data = device;
@@ -546,7 +546,7 @@ tape_generic_probe(struct ccw_device *cd device->cdev = cdev;ccw_device_get_id (cdev, &dev_id); device->cdev_id =devid_to_int (&dev_id); -PRINT_INFO ("tape device %s found\n" , cdev->dev.bus_id); +PRINT_INFO ("tape device %s found\n" ,dev_name (&cdev->dev));return ret; }
@@ -616,7 +616,7 @@ tape_generic_remove(struct ccw_device *c device->cdev_id);PRINT_WARN ("(%s): Drive in use vanished - " "expect trouble!\n" , - device->cdev->dev.bus_id); +dev_name (&device->cdev->dev));PRINT_WARN ("State was %i\n" , device->tape_state);tape_state_set (device,TS_NOT_OPER );__tape_discard_requests (device);
@@ -840,7 +840,7 @@ tape_dump_sense(struct tape_device* deviPRINT_INFO ("-------------------------------------------------\n" );PRINT_INFO ("DSTAT : %02x CSTAT: %02x CPA: %04x\n" , irb->scsw.dstat, irb->scsw.cstat, irb->scsw.cpa); -PRINT_INFO ("DEVICE: %s\n" , device->cdev->dev.bus_id); +PRINT_INFO ("DEVICE: %s\n" ,dev_name (&device->cdev->dev));if (request !=NULL )PRINT_INFO ("OP : %s\n" , tape_op_verbose[request->op]);
@@ -1051,7 +1051,7 @@ __tape_do_irq (struct ccw_device *cdev, device = (struct tape_device *) cdev->dev.driver_data;if (device ==NULL ) {PRINT_ERR ("could not get device structure for %s " -"in interrupt\n" , cdev->dev.bus_id); +"in interrupt\n" ,dev_name (&cdev->dev));return ; } request = (struct tape_request *) intparm;
@@ -1064,13 +1064,13 @@ __tape_do_irq (struct ccw_device *cdev,switch (PTR_ERR (irb)) {case -ETIMEDOUT :PRINT_WARN ("(%s): Request timed out\n" , - cdev->dev.bus_id); +dev_name (&cdev->dev));case -EIO :__tape_end_request (device, request, -EIO );break ;default :PRINT_ERR ("(%s): Unexpected i/o error %li\n" , - cdev->dev.bus_id, +dev_name (&cdev->dev),PTR_ERR (irb)); }return ;
drivers/s390/char/tape_proc.c +1 -1
@@ -52,7 +52,7 @@ static int tape_proc_show(struct seq_filreturn 0 ;spin_lock_irq (get_ccwdev_lock (device->cdev));seq_printf (m,"%d\t" , (int ) n); -seq_printf (m,"%-10.10s " , device->cdev->dev.bus_id); +seq_printf (m,"%-10.10s " ,dev_name (&device->cdev->dev));seq_printf (m,"%04X/" , device->cdev->id.cu_type);seq_printf (m,"%02X\t" , device->cdev->id.cu_model);seq_printf (m,"%04X/" , device->cdev->id.dev_type);
drivers/s390/char/tape_std.c +6 -6
@@ -47,7 +47,7 @@ tape_std_assign_timeout(unsigned long da rc =tape_cancel_io (device, request);if (rc)PRINT_ERR ("(%s): Assign timeout: Cancel failed with rc = %i\n" , - device->cdev->dev.bus_id, rc); +dev_name (&device->cdev->dev), rc); }
@@ -83,7 +83,7 @@ tape_std_assign(struct tape_device *deviif (rc !=0 ) {PRINT_WARN ("%s: assign failed - device might be busy\n" , - device->cdev->dev.bus_id); +dev_name (&device->cdev->dev));DBF_EVENT (3 ,"%08x: assign failed - device might be busy\n" , device->cdev_id); }else {
@@ -106,7 +106,7 @@ tape_std_unassign (struct tape_device *dDBF_EVENT (3 ,"(%08x): Can't unassign device\n" , device->cdev_id);PRINT_WARN ("(%s): Can't unassign device - device gone\n" , - device->cdev->dev.bus_id); +dev_name (&device->cdev->dev));return -EIO ; }
@@ -120,7 +120,7 @@ tape_std_unassign (struct tape_device *dif ((rc =tape_do_io (device, request)) !=0 ) {DBF_EVENT (3 ,"%08x: Unassign failed\n" , device->cdev_id); -PRINT_WARN ("%s: Unassign failed\n" , device->cdev->dev.bus_id); +PRINT_WARN ("%s: Unassign failed\n" ,dev_name (&device->cdev->dev)); }else {DBF_EVENT (3 ,"%08x: Tape unassigned\n" , device->cdev_id); }
@@ -634,10 +634,10 @@ tape_std_mtcompression(struct tape_devicDBF_EXCEPTION (6 ,"xcom parm\n" );if (*device->modeset_byte &0x08 )PRINT_INFO ("(%s) Compression is currently on\n" , - device->cdev->dev.bus_id); +dev_name (&device->cdev->dev));else PRINT_INFO ("(%s) Compression is currently off\n" , - device->cdev->dev.bus_id); +dev_name (&device->cdev->dev));PRINT_INFO ("Use 1 to switch compression on, 0 to " "switch it off\n" );return -EINVAL ;
drivers/s390/char/vmlogrdr.c +1 -1
@@ -765,7 +765,7 @@ static int vmlogrdr_register_device(stru priv->class_device =device_create_drvdata (vmlogrdr_class, dev,MKDEV (vmlogrdr_major, priv->minor_num), - priv,"%s" , dev->bus_id); + priv,"%s" ,dev_name (dev));if (IS_ERR (priv->class_device)) { ret =PTR_ERR (priv->class_device); priv->class_device=NULL ;
drivers/s390/char/vmur.c +3 -3
@@ -879,11 +879,11 @@ static int ur_set_online(struct ccw_devi goto fail_free_cdev;if (urd->cdev->id.cu_type ==READER_PUNCH_DEVTYPE ) {if (urd->class ==DEV_CLASS_UR_I ) -sprintf (node_id,"vmrdr-%s" , cdev->dev.bus_id); +sprintf (node_id,"vmrdr-%s" ,dev_name (&cdev->dev));if (urd->class ==DEV_CLASS_UR_O ) -sprintf (node_id,"vmpun-%s" , cdev->dev.bus_id); +sprintf (node_id,"vmpun-%s" ,dev_name (&cdev->dev)); }else if (urd->cdev->id.cu_type ==PRINTER_DEVTYPE ) { -sprintf (node_id,"vmprt-%s" , cdev->dev.bus_id); +sprintf (node_id,"vmprt-%s" ,dev_name (&cdev->dev)); }else { rc = -ENOTSUPP ; goto fail_free_cdev;
drivers/s390/cio/ccwgroup.c +1 -1
@@ -265,7 +265,7 @@ int ccwgroup_create_from_string(struct d gdev->dev.release = ccwgroup_release;snprintf (gdev->dev.bus_id,BUS_ID_SIZE ,"%s" , - gdev->cdev[0 ]->dev.bus_id); +dev_name (&gdev->cdev[0 ]->dev)); rc =device_register (&gdev->dev);if (rc)
drivers/s390/cio/cio.c +9 -9
@@ -152,7 +152,7 @@ cio_start_handle_notoper(struct subchannCIO_MSG_EVENT (2 ,"cio_start: 'not oper' status for " "subchannel 0.%x.%04x!\n" , sch->schid.ssid, sch->schid.sch_no); -sprintf (dbf_text,"no%s" , sch->dev.bus_id); +sprintf (dbf_text,"no%s" ,dev_name (&sch->dev));CIO_TRACE_EVENT (0 , dbf_text);CIO_HEX_EVENT (0 , &sch->schib,sizeof (struct schib ));
@@ -170,7 +170,7 @@ cio_start_key (struct subchannel *sch, /struct orb *orb;CIO_TRACE_EVENT (4 ,"stIO" ); -CIO_TRACE_EVENT (4 , sch->dev.bus_id); +CIO_TRACE_EVENT (4 ,dev_name (&sch->dev)); orb = &to_io_private (sch)->orb;/* sch is always under 2G. */
@@ -228,7 +228,7 @@ cio_resume (struct subchannel *sch)int ccode;CIO_TRACE_EVENT (4 ,"resIO" ); -CIO_TRACE_EVENT (4 , sch->dev.bus_id); +CIO_TRACE_EVENT (4 ,dev_name (&sch->dev)); ccode =rsch (sch->schid);
@@ -265,7 +265,7 @@ cio_halt(struct subchannel *sch)return -ENODEV ;CIO_TRACE_EVENT (2 ,"haltIO" ); -CIO_TRACE_EVENT (2 , sch->dev.bus_id); +CIO_TRACE_EVENT (2 ,dev_name (&sch->dev));/* * Issue "Halt subchannel" and process condition code
@@ -300,7 +300,7 @@ cio_clear(struct subchannel *sch)return -ENODEV ;CIO_TRACE_EVENT (2 ,"clearIO" ); -CIO_TRACE_EVENT (2 , sch->dev.bus_id); +CIO_TRACE_EVENT (2 ,dev_name (&sch->dev));/* * Issue "Clear subchannel" and process condition code
@@ -336,7 +336,7 @@ cio_cancel (struct subchannel *sch)return -ENODEV ;CIO_TRACE_EVENT (2 ,"cancelIO" ); -CIO_TRACE_EVENT (2 , sch->dev.bus_id); +CIO_TRACE_EVENT (2 ,dev_name (&sch->dev)); ccode =xsch (sch->schid);
@@ -398,7 +398,7 @@ int cio_enable_subchannel(struct subchanint ret;CIO_TRACE_EVENT (2 ,"ensch" ); -CIO_TRACE_EVENT (2 , sch->dev.bus_id); +CIO_TRACE_EVENT (2 ,dev_name (&sch->dev));if (sch_is_pseudo_sch (sch))return -EINVAL ;
@@ -447,7 +447,7 @@ cio_disable_subchannel (struct subchanneint ret;CIO_TRACE_EVENT (2 ,"dissch" ); -CIO_TRACE_EVENT (2 , sch->dev.bus_id); +CIO_TRACE_EVENT (2 ,dev_name (&sch->dev));if (sch_is_pseudo_sch (sch))return 0 ;
@@ -529,7 +529,7 @@ cio_validate_subchannel (struct subchann }mutex_init (&sch->reg_mutex);/* Set a name for the subchannel */ -snprintf (sch->dev.bus_id,BUS_ID_SIZE ,"0.%x.%04x" , schid.ssid, +snprintf (dev_name (&sch->dev),BUS_ID_SIZE ,"0.%x.%04x" , schid.ssid, schid.sch_no);/*
drivers/s390/cio/device.c +2 -2
@@ -1117,7 +1117,7 @@ static void io_subchannel_irq(struct sub cdev =sch_get_cdev (sch);CIO_TRACE_EVENT (3 ,"IRQ" ); -CIO_TRACE_EVENT (3 , sch->dev.bus_id); +CIO_TRACE_EVENT (3 ,dev_name (&sch->dev));if (cdev)dev_fsm_event (cdev,DEV_EVENT_INTERRUPT ); }
@@ -1367,7 +1367,7 @@ __ccwdev_check_busid(struct device *dev, bus_id = id; -return (strncmp (bus_id, dev->bus_id,BUS_ID_SIZE ) ==0 ); +return (strncmp (bus_id,dev_name (dev),BUS_ID_SIZE ) ==0 ); }
drivers/s390/cio/device_fsm.c +4 -2
@@ -110,8 +110,10 @@ static void ccw_timeout_log(struct ccw_dprintk (KERN_WARNING "cio: orb:\n" );print_hex_dump (KERN_WARNING ,"cio: " ,DUMP_PREFIX_NONE ,16 ,1 , &private->orb,sizeof (private->orb),0 ); -printk (KERN_WARNING "cio: ccw device bus id: %s\n" , cdev->dev.bus_id); -printk (KERN_WARNING "cio: subchannel bus id: %s\n" , sch->dev.bus_id); +printk (KERN_WARNING "cio: ccw device bus id: %s\n" , +dev_name (&cdev->dev)); +printk (KERN_WARNING "cio: subchannel bus id: %s\n" , +dev_name (&sch->dev));printk (KERN_WARNING "cio: subchannel lpm: %02x, opm: %02x, " "vpm: %02x\n" , sch->lpm, sch->opm, sch->vpm);
drivers/s390/cio/device_ops.c +1 -1
@@ -497,7 +497,7 @@ ccw_device_stlck(struct ccw_device *cdev sch =to_subchannel (cdev->dev.parent);CIO_TRACE_EVENT (2 ,"stl lock" ); -CIO_TRACE_EVENT (2 , cdev->dev.bus_id); +CIO_TRACE_EVENT (2 ,dev_name (&cdev->dev)); buf =kmalloc (32 *sizeof (char ),GFP_DMA |GFP_KERNEL );if (!buf)
drivers/s390/cio/qdio.c +12 -12
@@ -2001,21 +2001,21 @@ qdio_handle_activate_check(struct ccw_de irq_ptr = cdev->private->qdio_data;QDIO_DBF_TEXT2 (1 , trace,"ick2" ); -sprintf (dbf_text,"%s" , cdev->dev.bus_id); +sprintf (dbf_text,"%s" ,dev_name (&cdev->dev));QDIO_DBF_TEXT2 (1 ,trace,dbf_text);QDIO_DBF_HEX2 (0 ,trace,&intparm,sizeof (int ));QDIO_DBF_HEX2 (0 ,trace,&dstat,sizeof (int ));QDIO_DBF_HEX2 (0 ,trace,&cstat,sizeof (int ));QDIO_PRINT_ERR ("received check condition on activate " \"queues on device %s (cs=x%x, ds=x%x).\n" , - cdev->dev.bus_id, cstat, dstat); +dev_name (&cdev->dev), cstat, dstat);if (irq_ptr->no_input_qs) { q=irq_ptr->input_qs[0 ]; }else if (irq_ptr->no_output_qs) { q=irq_ptr->output_qs[0 ]; }else {QDIO_PRINT_ERR ("oops... no queue registered for device %s!?\n" , - cdev->dev.bus_id); +dev_name (&cdev->dev)); goto omit_handler_call; } q->handler(q->cdev,QDIO_STATUS_ACTIVATE_CHECK_CONDITION|
@@ -2045,7 +2045,7 @@ qdio_timeout_handler(struct ccw_device *char dbf_text[15 ];QDIO_DBF_TEXT2 (0 , trace,"qtoh" ); -sprintf (dbf_text,"%s" , cdev->dev.bus_id); +sprintf (dbf_text,"%s" ,dev_name (&cdev->dev));QDIO_DBF_TEXT2 (0 , trace, dbf_text); irq_ptr = cdev->private->qdio_data;
@@ -2095,23 +2095,23 @@ qdio_handler(struct ccw_device *cdev, un#ifdef CONFIG_QDIO_DEBUG QDIO_DBF_TEXT4 (0 , trace,"qint" ); -sprintf (dbf_text,"%s" , cdev->dev.bus_id); +sprintf (dbf_text,"%s" ,dev_name (&cdev->dev));QDIO_DBF_TEXT4 (0 , trace, dbf_text);#endif /* CONFIG_QDIO_DEBUG */ if (!intparm) {QDIO_PRINT_ERR ("got unsolicited interrupt in qdio " \ -"handler, device %s\n" , cdev->dev.bus_id); +"handler, device %s\n" ,dev_name (&cdev->dev));return ; } irq_ptr = cdev->private->qdio_data;if (!irq_ptr) {QDIO_DBF_TEXT2 (1 , trace,"uint" ); -sprintf (dbf_text,"%s" , cdev->dev.bus_id); +sprintf (dbf_text,"%s" ,dev_name (&cdev->dev));QDIO_DBF_TEXT2 (1 ,trace,dbf_text);QDIO_PRINT_ERR ("received interrupt on unused device %s!\n" , - cdev->dev.bus_id); +dev_name (&cdev->dev));return ; }
@@ -2120,14 +2120,14 @@ qdio_handler(struct ccw_device *cdev, unswitch (PTR_ERR (irb)) {case -EIO :QDIO_PRINT_ERR ("i/o error on device %s\n" , - cdev->dev.bus_id); +dev_name (&cdev->dev));return ;case -ETIMEDOUT :qdio_timeout_handler (cdev);return ;default :QDIO_PRINT_ERR ("unknown error state %ld on device %s\n" , -PTR_ERR (irb), cdev->dev.bus_id); +PTR_ERR (irb),dev_name (&cdev->dev));return ; } }
@@ -2165,7 +2165,7 @@ qdio_handler(struct ccw_device *cdev, undefault :QDIO_PRINT_ERR ("got interrupt for queues in state %d on " \"device %s?!\n" , - irq_ptr->state, cdev->dev.bus_id); + irq_ptr->state,dev_name (&cdev->dev)); }wake_up (&cdev->private->wait_q);
@@ -2675,7 +2675,7 @@ qdio_shutdown(struct ccw_device *cdev, i irq_ptr->state == QDIO_IRQ_STATE_ERR); }else {QDIO_PRINT_INFO ("ccw_device_{halt,clear} returned %d for " -"device %s\n" , result, cdev->dev.bus_id); +"device %s\n" , result,dev_name (&cdev->dev));spin_unlock_irqrestore (get_ccwdev_lock (cdev), flags); result = rc; goto out;
drivers/s390/net/claw.c +15 -15
@@ -313,7 +313,7 @@ claw_probe(struct ccwgroup_device *cgdevprobe_error (cgdev);put_device (&cgdev->dev);printk (KERN_WARNING "Out of memory %s %s Exit Line %d \n" , - cgdev->cdev[0 ]->dev.bus_id,__func__,__LINE__); +dev_name (&cgdev->cdev[0 ]->dev),__func__,__LINE__);CLAW_DBF_TEXT_ (2 ,setup,"probex%d" ,-ENOMEM );return -ENOMEM ; }
@@ -703,7 +703,7 @@ claw_irq_handler(struct ccw_device *cdevif (!cdev->dev.driver_data) {printk (KERN_WARNING "claw: unsolicited interrupt for device:" "%s received c-%02x d-%02x\n" , - cdev->dev.bus_id,irb->scsw.cstat, irb->scsw.dstat); +dev_name (&cdev->dev),irb->scsw.cstat, irb->scsw.dstat);#ifdef FUNCTRACE printk (KERN_INFO "claw: %s() " "exit on line %d\n" ,__func__,__LINE__);
@@ -720,7 +720,7 @@ claw_irq_handler(struct ccw_device *cdev p_ch = &privptr->channel[WRITE ]; else {printk (KERN_WARNING "claw: Can't determine channel for " -"interrupt, device %s\n" , cdev->dev.bus_id); +"interrupt, device %s\n" ,dev_name (&cdev->dev));CLAW_DBF_TEXT (2 ,trace,"badchan" );return ; }
@@ -827,7 +827,7 @@ claw_irq_handler(struct ccw_device *cdevprintk (KERN_WARNING "claw: unsolicited " "interrupt for device:" "%s received c-%02x d-%02x\n" , - cdev->dev.bus_id, +dev_name (&cdev->dev), irb->scsw.cstat, irb->scsw.dstat);return ;
@@ -1483,7 +1483,7 @@ ccw_check_return_code(struct ccw_device {#ifdef FUNCTRACE printk (KERN_INFO "%s: %s() > enter \n" , - cdev->dev.bus_id,__func__); +dev_name (&cdev->dev),__func__);#endif CLAW_DBF_TEXT (4 ,trace,"ccwret" );#ifdef DEBUGMSG
@@ -1495,28 +1495,28 @@ ccw_check_return_code(struct ccw_deviceswitch (return_code) {case -EBUSY :printk (KERN_INFO "%s: Busy !\n" , - cdev->dev.bus_id); +dev_name (&cdev->dev));break ;case -ENODEV :printk (KERN_EMERG "%s: Missing device called " -"for IO ENODEV\n" , cdev->dev.bus_id); +"for IO ENODEV\n" ,dev_name (&cdev->dev));break ;case -EIO :printk (KERN_EMERG "%s: Status pending... EIO \n" , - cdev->dev.bus_id); +dev_name (&cdev->dev));break ;case -EINVAL :printk (KERN_EMERG "%s: Invalid Dev State EINVAL \n" , - cdev->dev.bus_id); +dev_name (&cdev->dev));break ;default :printk (KERN_EMERG "%s: Unknown error in " -"Do_IO %d\n" ,cdev->dev.bus_id, return_code); +"Do_IO %d\n" ,dev_name (&cdev->dev), return_code); } }#ifdef FUNCTRACE printk (KERN_INFO "%s: %s() > exit on line %d\n" , - cdev->dev.bus_id,__func__,__LINE__); +dev_name (&cdev->dev),__func__,__LINE__);#endif CLAW_DBF_TEXT (4 ,trace,"ccwret" ); }/* end of ccw_check_return_code */
@@ -3909,13 +3909,13 @@ add_channel(struct ccw_device *cdev,intstruct ccw_dev_id dev_id;#ifdef FUNCTRACE -printk (KERN_INFO "%s:%s Enter\n" ,cdev->dev.bus_id,__func__); +printk (KERN_INFO "%s:%s Enter\n" ,dev_name (&cdev->dev),__func__);#endif -CLAW_DBF_TEXT_ (2 ,setup,"%s" ,cdev->dev.bus_id); +CLAW_DBF_TEXT_ (2 ,setup,"%s" ,dev_name (&cdev->dev)); privptr->channel[i].flag = i+1 ;/* Read is 1 Write is 2 */ p_ch = &privptr->channel[i]; p_ch->cdev = cdev; -snprintf (p_ch->id,CLAW_ID_SIZE ,"cl-%s" , cdev->dev.bus_id); +snprintf (p_ch->id,CLAW_ID_SIZE ,"cl-%s" ,dev_name (&cdev->dev));ccw_device_get_id (cdev, &dev_id); p_ch->devno = dev_id.devno;if ((p_ch->irb =kzalloc (sizeof (struct irb ),GFP_KERNEL )) ==NULL ) {
@@ -3929,7 +3929,7 @@ add_channel(struct ccw_device *cdev,int }#ifdef FUNCTRACE printk (KERN_INFO "%s:%s Exit on line %d\n" , - cdev->dev.bus_id,__func__,__LINE__); +dev_name (&cdev->dev),__func__,__LINE__);#endif return 0 ; }
drivers/s390/net/claw.h +1 -1
@@ -85,7 +85,7 @@#define CLAW_MAX_DEV 256/* max claw devices */ #define MAX_NAME_LEN 8/* host name, adapter name length */ #define CLAW_FRAME_SIZE 4096 -#define CLAW_ID_SIZE BUS_ID_SIZE+3 +#define CLAW_ID_SIZE 20+3/* state machine codes used in claw_irq_handler */
drivers/s390/net/ctcm_main.c +8 -8
@@ -284,18 +284,18 @@ static long ctcm_check_irb_error(structreturn 0 ;CTCM_DBF_TEXT_ (ERROR ,CTC_DBF_WARN ,"irb error %ld on device %s\n" , -PTR_ERR (irb), cdev->dev.bus_id); +PTR_ERR (irb),dev_name (&cdev->dev));switch (PTR_ERR (irb)) {case -EIO : -ctcm_pr_warn ("i/o-error on device %s\n" , cdev->dev.bus_id); +ctcm_pr_warn ("i/o-error on device %s\n" ,dev_name (&cdev->dev));break ;case -ETIMEDOUT : -ctcm_pr_warn ("timeout on device %s\n" , cdev->dev.bus_id); +ctcm_pr_warn ("timeout on device %s\n" ,dev_name (&cdev->dev));break ;default :ctcm_pr_warn ("unknown error %ld on device %s\n" , -PTR_ERR (irb), cdev->dev.bus_id); +PTR_ERR (irb),dev_name (&cdev->dev)); }return PTR_ERR (irb); }
@@ -1236,7 +1236,7 @@ static void ctcm_irq_handler(struct ccw_/* Check for unsolicited interrupts. */ if (cgdev ==NULL ) {ctcm_pr_warn ("ctcm: Got unsolicited irq: %s c-%02x d-%02x\n" , - cdev->dev.bus_id, irb->scsw.cstat, +dev_name (&cdev->dev), irb->scsw.cstat, irb->scsw.dstat);return ; }
@@ -1250,14 +1250,14 @@ static void ctcm_irq_handler(struct ccw_ ch = priv->channel[WRITE ]; else {ctcm_pr_err ("ctcm: Can't determine channel for interrupt, " -"device %s\n" , cdev->dev.bus_id); +"device %s\n" ,dev_name (&cdev->dev));return ; } dev = (struct net_device *)(ch->netdev);if (dev ==NULL ) {ctcm_pr_crit ("ctcm: %s dev=NULL bus_id=%s, ch=0x%p\n" , - __FUNCTION__, cdev->dev.bus_id, ch); + __FUNCTION__,dev_name (&cdev->dev), ch);return ; }
@@ -1392,7 +1392,7 @@ static int add_channel(struct ccw_device goto nomem_return; ch->cdev = cdev; -snprintf (ch->id,CTCM_ID_SIZE ,"ch-%s" , cdev->dev.bus_id); +snprintf (ch->id,CTCM_ID_SIZE ,"ch-%s" ,dev_name (&cdev->dev)); ch->type = type;/**
drivers/s390/net/ctcm_main.h +1 -1
@@ -80,7 +80,7 @@#define READ 0#define WRITE 1 -#define CTCM_ID_SIZE BUS_ID_SIZE+3 +#define CTCM_ID_SIZE 20+3struct ctcm_profile {unsigned long maxmulti;
drivers/s390/net/lcs.c +15 -15
@@ -492,7 +492,7 @@ lcs_start_channel(struct lcs_channel *chunsigned long flags;int rc; -LCS_DBF_TEXT_ (4 ,trace,"ssch%s" , channel->ccwdev->dev.bus_id); +LCS_DBF_TEXT_ (4 ,trace,"ssch%s" ,dev_name (&channel->ccwdev->dev));spin_lock_irqsave (get_ccwdev_lock (channel->ccwdev), flags); rc = ccw_device_start(channel->ccwdev, channel->ccws + channel->io_idx, 0, 0,
@@ -501,7 +501,7 @@ lcs_start_channel(struct lcs_channel *ch channel->state =LCS_CH_STATE_RUNNING ;spin_unlock_irqrestore (get_ccwdev_lock (channel->ccwdev), flags);if (rc) { -LCS_DBF_TEXT_ (4 ,trace,"essh%s" , channel->ccwdev->dev.bus_id); +LCS_DBF_TEXT_ (4 ,trace,"essh%s" ,dev_name (&channel->ccwdev->dev));PRINT_ERR ("Error in starting channel, rc=%d!\n" , rc); }return rc;
@@ -514,12 +514,12 @@ lcs_clear_channel(struct lcs_channel *chint rc;LCS_DBF_TEXT (4 ,trace,"clearch" ); -LCS_DBF_TEXT_ (4 ,trace,"%s" , channel->ccwdev->dev.bus_id); +LCS_DBF_TEXT_ (4 ,trace,"%s" ,dev_name (&channel->ccwdev->dev));spin_lock_irqsave (get_ccwdev_lock (channel->ccwdev), flags); rc =ccw_device_clear (channel->ccwdev, (addr_t ) channel);spin_unlock_irqrestore (get_ccwdev_lock (channel->ccwdev), flags);if (rc) { -LCS_DBF_TEXT_ (4 ,trace,"ecsc%s" , channel->ccwdev->dev.bus_id); +LCS_DBF_TEXT_ (4 ,trace,"ecsc%s" ,dev_name (&channel->ccwdev->dev));return rc; }wait_event (channel->wait_q, (channel->state ==LCS_CH_STATE_CLEARED ));
@@ -540,13 +540,13 @@ lcs_stop_channel(struct lcs_channel *chaif (channel->state ==LCS_CH_STATE_STOPPED )return 0 ;LCS_DBF_TEXT (4 ,trace,"haltsch" ); -LCS_DBF_TEXT_ (4 ,trace,"%s" , channel->ccwdev->dev.bus_id); +LCS_DBF_TEXT_ (4 ,trace,"%s" ,dev_name (&channel->ccwdev->dev)); channel->state =LCS_CH_STATE_INIT ;spin_lock_irqsave (get_ccwdev_lock (channel->ccwdev), flags); rc =ccw_device_halt (channel->ccwdev, (addr_t ) channel);spin_unlock_irqrestore (get_ccwdev_lock (channel->ccwdev), flags);if (rc) { -LCS_DBF_TEXT_ (4 ,trace,"ehsc%s" , channel->ccwdev->dev.bus_id); +LCS_DBF_TEXT_ (4 ,trace,"ehsc%s" ,dev_name (&channel->ccwdev->dev));return rc; }/* Asynchronous halt initialted. Wait for its completion. */
@@ -632,10 +632,10 @@ __lcs_resume_channel(struct lcs_channelreturn 0 ;if (channel->ccws[channel->io_idx].flags &CCW_FLAG_SUSPEND )return 0 ; -LCS_DBF_TEXT_ (5 , trace,"rsch%s" , channel->ccwdev->dev.bus_id); +LCS_DBF_TEXT_ (5 , trace,"rsch%s" ,dev_name (&channel->ccwdev->dev)); rc =ccw_device_resume (channel->ccwdev);if (rc) { -LCS_DBF_TEXT_ (4 , trace,"ersc%s" , channel->ccwdev->dev.bus_id); +LCS_DBF_TEXT_ (4 , trace,"ersc%s" ,dev_name (&channel->ccwdev->dev));PRINT_ERR ("Error in lcs_resume_channel: rc=%d\n" ,rc); }else channel->state =LCS_CH_STATE_RUNNING ;
@@ -1302,18 +1302,18 @@ lcs_check_irb_error(struct ccw_device *cswitch (PTR_ERR (irb)) {case -EIO : -PRINT_WARN ("i/o-error on device %s\n" , cdev->dev.bus_id); +PRINT_WARN ("i/o-error on device %s\n" ,dev_name (&cdev->dev));LCS_DBF_TEXT (2 , trace,"ckirberr" );LCS_DBF_TEXT_ (2 , trace," rc%d" , -EIO );break ;case -ETIMEDOUT : -PRINT_WARN ("timeout on device %s\n" , cdev->dev.bus_id); +PRINT_WARN ("timeout on device %s\n" ,dev_name (&cdev->dev));LCS_DBF_TEXT (2 , trace,"ckirberr" );LCS_DBF_TEXT_ (2 , trace," rc%d" , -ETIMEDOUT );break ;default :PRINT_WARN ("unknown error %ld on device %s\n" ,PTR_ERR (irb), - cdev->dev.bus_id); +dev_name (&cdev->dev));LCS_DBF_TEXT (2 , trace,"ckirberr" );LCS_DBF_TEXT (2 , trace," rc???" ); }
@@ -1390,7 +1390,7 @@ lcs_irq(struct ccw_device *cdev, unsigne cstat = irb->scsw.cstat; dstat = irb->scsw.dstat; -LCS_DBF_TEXT_ (5 , trace,"Rint%s" ,cdev->dev.bus_id); +LCS_DBF_TEXT_ (5 , trace,"Rint%s" ,dev_name (&cdev->dev));LCS_DBF_TEXT_ (5 , trace,"%4x%4x" ,irb->scsw.cstat, irb->scsw.dstat);LCS_DBF_TEXT_ (5 , trace,"%4x%4x" ,irb->scsw.fctl, irb->scsw.actl);
@@ -1398,7 +1398,7 @@ lcs_irq(struct ccw_device *cdev, unsigne rc =lcs_get_problem (cdev, irb);if (rc || (dstat &DEV_STAT_UNIT_EXCEP )) {PRINT_WARN ("check on device %s, dstat=0x%X, cstat=0x%X \n" , - cdev->dev.bus_id, dstat, cstat); +dev_name (&cdev->dev), dstat, cstat);if (rc) { channel->state =LCS_CH_STATE_ERROR ; }
@@ -1461,7 +1461,7 @@ lcs_tasklet(unsigned long data)int rc; channel = (struct lcs_channel *) data; -LCS_DBF_TEXT_ (5 , trace,"tlet%s" ,channel->ccwdev->dev.bus_id); +LCS_DBF_TEXT_ (5 , trace,"tlet%s" ,dev_name (&channel->ccwdev->dev));/* Check for processed buffers. */ iob = channel->iob;
@@ -2244,7 +2244,7 @@ lcs_recovery(void *ptr)return 0 ;LCS_DBF_TEXT (4 , trace,"recover2" ); gdev = card->gdev; -PRINT_WARN ("Recovery of device %s started...\n" , gdev->dev.bus_id); +PRINT_WARN ("Recovery of device %s started...\n" ,dev_name (&gdev->dev)); rc =__lcs_shutdown_device (gdev,1 ); rc =lcs_new_device (gdev);if (!rc)
drivers/s390/net/netiucv.c +1 -1
@@ -1422,7 +1422,7 @@ static ssize_t user_write(struct device (ndev->flags & (IFF_UP | IFF_RUNNING))) {/* username changed while the interface is active. */ PRINT_WARN ("netiucv: device %s active, connected to %s\n" , - dev->bus_id, priv->conn->userid); +dev_name (dev), priv->conn->userid);PRINT_WARN ("netiucv: user cannot be updated\n" );IUCV_DBF_TEXT (setup,2 ,"user_write: device active\n" );return -EBUSY ;
drivers/s390/net/qeth_core.h +5 -5
@@ -90,11 +90,11 @@ struct qeth_dbf_info {#define CARD_RDEV (card) card->read.ccwdev#define CARD_WDEV (card) card->write.ccwdev#define CARD_DDEV (card) card->data.ccwdev -#define CARD_BUS_ID (card) card->gdev->dev.bus_id -#define CARD_RDEV_ID (card) card->read.ccwdev->dev.bus_id -#define CARD_WDEV_ID (card) card->write.ccwdev->dev.bus_id -#define CARD_DDEV_ID (card) card->data.ccwdev->dev.bus_id -#define CHANNEL_ID (channel) channel->ccwdev->dev.bus_id +#define CARD_BUS_ID (card) dev_name(&card->gdev->dev) +#define CARD_RDEV_ID (card) dev_name(&card->read.ccwdev->dev) +#define CARD_WDEV_ID (card) dev_name(&card->write.ccwdev->dev) +#define CARD_DDEV_ID (card) dev_name(&card->data.ccwdev->dev) +#define CHANNEL_ID (channel) dev_name(&channel->ccwdev->dev)/** * card stuff
drivers/s390/net/qeth_core_main.c +5 -5
@@ -743,7 +743,7 @@ static int qeth_get_problem(struct ccw_d SCHN_STAT_PROT_CHECK | SCHN_STAT_PROG_CHECK)) {QETH_DBF_TEXT (TRACE ,2 ,"CGENCHK" );PRINT_WARN ("check on device %s, dstat=x%x, cstat=x%x " , - cdev->dev.bus_id, dstat, cstat); +dev_name (&cdev->dev), dstat, cstat);print_hex_dump (KERN_WARNING ,"qeth: irb " ,DUMP_PREFIX_OFFSET ,16 ,1 , irb,64 ,1 );return 1 ;
@@ -782,12 +782,12 @@ static long __qeth_check_irb_error(strucswitch (PTR_ERR (irb)) {case -EIO : -PRINT_WARN ("i/o-error on device %s\n" , cdev->dev.bus_id); +PRINT_WARN ("i/o-error on device %s\n" ,dev_name (&cdev->dev));QETH_DBF_TEXT (TRACE ,2 ,"ckirberr" );QETH_DBF_TEXT_ (TRACE ,2 ," rc%d" , -EIO );break ;case -ETIMEDOUT : -PRINT_WARN ("timeout on device %s\n" , cdev->dev.bus_id); +PRINT_WARN ("timeout on device %s\n" ,dev_name (&cdev->dev));QETH_DBF_TEXT (TRACE ,2 ,"ckirberr" );QETH_DBF_TEXT_ (TRACE ,2 ," rc%d" , -ETIMEDOUT );if (intparm ==QETH_RCD_PARM ) {
@@ -801,7 +801,7 @@ static long __qeth_check_irb_error(strucbreak ;default :PRINT_WARN ("unknown error %ld on device %s\n" ,PTR_ERR (irb), - cdev->dev.bus_id); +dev_name (&cdev->dev));QETH_DBF_TEXT (TRACE ,2 ,"ckirberr" );QETH_DBF_TEXT (TRACE ,2 ," rc???" ); }
@@ -4073,7 +4073,7 @@ static int qeth_core_probe_device(structif (!get_device (dev))return -ENODEV ; -QETH_DBF_TEXT_ (SETUP ,2 ,"%s" , gdev->dev.bus_id); +QETH_DBF_TEXT_ (SETUP ,2 ,"%s" ,dev_name (&gdev->dev)); card =qeth_alloc_card ();if (!card) {
drivers/s390/scsi/zfcp_def.h +1 -1
@@ -870,7 +870,7 @@ struct zfcp_data {struct semaphore config_sema;/* serialises configuration changes */ atomic_t loglevel;/* current loglevel */ -char init_busid[BUS_ID_SIZE ]; +char init_busid[20 ];wwn_t init_wwpn;fcp_lun_t init_fcp_lun;char *driver_version;
drivers/s390/cio/cio.c cio_validate_subchannel (struct subchann · line 535
Quoted 9 lines · Greg KH
drivers/s390/cio/cio.c +1
-1@@ -529,7 +529,7 @@ cio_validate_subchannel (struct subchann }mutex_init (&sch->reg_mutex);/* Set a name for the subchannel */ -snprintf (sch->dev.bus_id,BUS_ID_SIZE ,"0.%x.%04x" , schid.ssid, +snprintf (dev_name (&sch->dev),BUS_ID_SIZE ,"0.%x.%04x" , schid.ssid, schid.sch_no);/*
This hunk does not make much sense. Better just leave it alone until the dev_set_name()/init_name conversion later.
Quoted 11 lines · Cornelia Huck
Quoted 8 lines · Greg KH
drivers/s390/cio/cio.c +1
-1@@ -529,7 +529,7 @@ cio_validate_subchannel (struct subchann }mutex_init (&sch->reg_mutex);/* Set a name for the subchannel */ -snprintf (sch->dev.bus_id,BUS_ID_SIZE ,"0.%x.%04x" , schid.ssid, +snprintf (dev_name (&sch->dev),BUS_ID_SIZE ,"0.%x.%04x" , schid.ssid, schid.sch_no);
Quoted 4 lines
Review cio_validate_subchannel (struct subchann · line 535
Quoted 1 line
(quoted diff) +0
-0/*This hunk does not make much sense. Better just leave it alone until the dev_set_name()/init_name conversion later.
You are right.
390 maintainers, can you drop this hunk, or do you want me to respin it and the other 3 patches (if needed)?
thanks,
greg k-h
Quoted 17 lines · Greg KH
Quoted 11 lines · Cornelia Huck
Quoted 8 lines · Greg KH
drivers/s390/cio/cio.c +1
-1@@ -529,7 +529,7 @@ cio_validate_subchannel (struct subchann }mutex_init (&sch->reg_mutex);/* Set a name for the subchannel */ -snprintf (sch->dev.bus_id,BUS_ID_SIZE ,"0.%x.%04x" , schid.ssid, +snprintf (dev_name (&sch->dev),BUS_ID_SIZE ,"0.%x.%04x" , schid.ssid, schid.sch_no);Quoted 4 lines
Review cio_validate_subchannel (struct subchann · line 535
Quoted 1 line
(quoted diff) +0
-0/*This hunk does not make much sense. Better just leave it alone until the dev_set_name()/init_name conversion later.
Quoted 4 lines
You are right.
390 maintainers, can you drop this hunk, or do you want me to respin it and the other 3 patches (if needed)?
Please resend, since patch 2 needs to be changed as well, right?
Thanks! :)