Skip to contentSkip to conversation

powerpc: add FHCI USB, FSL MCU, FSL UPM and GPIO LEDs bindings

PATCH Superseded Anton Vorontsov 3 participants 11 messages Jul 3, 2008 – Jul 15, 2008 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: add FHCI USB, FSL MCU, FSL UPM and GPIO LEDs bindings

This patch adds few bindings for the new drivers to be submitted through the appropriate maintainers.

---

Segher, thanks for the comments on the previous version. Do you see any issues with this one or anything I could improve further?

And if there are no issues... Kumar, could you apply this for powerpc-next?

Thanks.

 Documentation/powerpc/booting-without-of.txt |  111 ++++++++++++++++++++++++++
 1 files changed, 111 insertions(+), 0 deletions(-)
Documentation/powerpc/booting-without-of.txt +111 -0
index b68684d..a7ea549 100644
@@ -62,6 +62,10 @@ Table of Contents
       s) Freescale on board FPGA
       t) Freescael MSI interrupt controller
       u) Freescale General-purpose Timers Module
+      v) Freescale QUICC Engine USB Controller
+      w) Freescale MCU with MPC8349E-mITX compatible firmware
+      x) Freescale Localbus UPM programmed to work with NAND flash
+      y) LEDs on GPIOs
 
   VII - Marvell Discovery mv64[345]6x System Controller chips
     1) The /system-controller node
@@ -2967,6 +2971,113 @@ platforms are moved over to use the flattened-device-tree model.
 	clock-frequency = <0>;
     };
 
+    v) Freescale QUICC Engine USB Controller
+
+    Required properties:
+      - compatible : should be "fsl,<chip>-qe-usb", "fsl,mpc8323-qe-usb";
+      - reg : the first two cells should contain usb registers location and
+        length, the next two two cells should contain PRAM location and
+        length.
+      - interrupts : should contain USB interrupt.
+      - interrupt-parent : interrupt source phandle.
+      - fsl,fullspeed-clock : specifies the full speed USB clock source:
+        "none": clock source is disabled
+        "brg1" through "brg16": clock source is BRG1-BRG16, respectively
+        "clk1" through "clk24": clock source is CLK1-CLK24, respectively
+      - fsl,lowspeed-clock : specifies the low speed USB clock source:
+        "none": clock source is disabled
+        "brg1" through "brg16": clock source is BRG1-BRG16, respectively
+        "clk1" through "clk24": clock source is CLK1-CLK24, respectively
+      - hub-power-budget : optional, USB power budget for the root hub, in mA.
+      - gpios : should specify GPIOs in this order: USBOE, USBTP, USBTN, USBRP,
+        USBRN, SPEED (optional), and POWER (optional).
+
+    Example:
+
+	usb@6c0 {
+		compatible = "fsl,mpc8360-qe-usb", "fsl,mpc8323-qe-usb";
+		reg = <0x6c0 0x40 0x8b00 0x100>;
+		interrupts = <11>;
+		interrupt-parent = <&qeic>;
+		fsl,fullspeed-clock = "clk21";
+		gpios = <&qe_pio_b  2 0 /* USBOE */
+			 &qe_pio_b  3 0 /* USBTP */
+			 &qe_pio_b  8 0 /* USBTN */
+			 &qe_pio_b  9 0 /* USBRP */
+			 &qe_pio_b 11 0 /* USBRN */
+			 &qe_pio_e 20 0 /* SPEED */
+			 &qe_pio_e 21 0 /* POWER */>;
+	};
+
+    w) Freescale MCU with MPC8349E-mITX compatible firmware
+
+    Required properties:
+      - compatible : "fsl,<mcu-chip>-<board>", "fsl,mcu-mpc8349emitx";
+      - reg : should specify I2C address (0x0a).
+      - #gpio-cells : should be 2.
+      - gpio-controller : should be present;
+
+    Example:
+
+	mcu_pio: mcu@0a {
+		#gpio-cells = <2>;
+		compatible = "fsl,mc9s08qg8-mpc8349emitx",
+			     "fsl,mcu-mpc8349emitx";
+		reg = <0x0a>;
+		gpio-controller;
+	};
+
+    x) Freescale Localbus UPM programmed to work with NAND flash
+
+      Required properties:
+      - compatible : "fsl,upm-nand".
+      - reg : should specify localbus chip select and size used for the chip.
+      - fsl,upm-addr-offset : UPM pattern offset for the address latch.
+      - fsl,upm-cmd-offset : UPM pattern offset for the command latch.
+      - gpios : may specify optional GPIO connected to the Ready-Not-Busy pin.
+
+      Example:
+
+	upm@1,0 {
+		compatible = "fsl,upm-nand";
+		reg = <1 0 1>;
+		fsl,upm-addr-offset = <16>;
+		fsl,upm-cmd-offset = <8>;
+		gpios = <&qe_pio_e 18 0>;
+
+		flash {
+			#address-cells = <1>;
+			#size-cells = <1>;
+			compatible = "...";
+
+			partition@0 {
+				...
+			};
+		};
+	};
+
+    y) LEDs on GPIOs
+
+    Required properties:
+      - compatible : should be "gpio-led".
+      - label : (optional) the label for this LED. If omitted, the label is
+        taken from the node name (excluding the unit address).
+      - gpios : should specify LED GPIO.
+
+    Example:
+
+	led@0 {
+		compatible = "gpio-led";
+		label = "hdd";
+		gpios = <&mcu_pio 0 1>;
+	};
+
+	led@1 {
+		compatible = "gpio-led";
+		label = "pwr";
+		gpios = <&mcu_pio 1 0>;
+	};
+
 VII - Marvell Discovery mv64[345]6x System Controller chips
 ===========================================================
 
Signature · 1 line
1.5.5.4
#1 lore raw
Quoted 22 lines · Anton Vorontsov

This patch adds few bindings for the new drivers to be submitted through the appropriate maintainers.

---

Segher, thanks for the comments on the previous version. Do you see any issues with this one or anything I could improve further?

And if there are no issues... Kumar, could you apply this for powerpc-next?

Thanks.

Documentation/powerpc/booting-without-of.txt | 111 +++++++++++++++++
+++++++++

1 files changed, 111 insertions(+), 0 deletions(-)
Documentation/powerpc/booting-without-of.txt +0 -0
index b68684d..a7ea549 100644

Documentation/powerpc/booting-without-of.txt Table of Contents · line 66

Quoted 5 lines
Documentation/powerpc/booting-without-of.txt +2 -0
@@ -62,6 +62,10 @@ Table of Contents
      s) Freescale on board FPGA
      t) Freescael MSI interrupt controller
      u) Freescale General-purpose Timers Module
+      v) Freescale QUICC Engine USB Controller
+      w) Freescale MCU with MPC8349E-mITX compatible firmware

MCU doesn't mean much to me. Its good to expand out the acronym at least once.

- k

#2 lore raw
Quoted 23 lines · Kumar Gala
Quoted 20 lines · Anton Vorontsov

This patch adds few bindings for the new drivers to be submitted through
the appropriate maintainers.

---

Segher, thanks for the comments on the previous version. Do you see any
issues with this one or anything I could improve further?

And if there are no issues... Kumar, could you apply this for powerpc-next?

Thanks.

Documentation/powerpc/booting-without-of.txt | 111 +++++++++++++++++
+++++++++

1 files changed, 111 insertions(+), 0 deletions(-)
Quoted 14 lines

Documentation/powerpc/booting-without-of.txt Table of Contents · line 66

Quoted 11 lines
(quoted diff) renamed from Documentation/powerpc/booting-without-of.txt +0 -0

Documentation/powerpc/booting-without-of.txt
index b68684d..a7ea549 100644

Documentation/powerpc/booting-without-of.txt +2 -0
@@ -62,6 +62,10 @@ Table of Contents
      s) Freescale on board FPGA
      t) Freescael MSI interrupt controller
      u) Freescale General-purpose Timers Module
+      v) Freescale QUICC Engine USB Controller
+      w) Freescale MCU with MPC8349E-mITX compatible firmware

MCU doesn't mean much to me. Its good to expand out the acronym at least once.

MCU stands for MicroController Unit, and even expanded this doesn't mean much to anybody. :-) Freescale documentation names it as boards' "MCU Subsystem", that is, the chip provides fan control, GPIOs, software halt, etc. Basically, it is boards' power management companion chip. I don't know how to name it more correctly, so I adhered to documentation's naming (they simply call it MCU).

^^ I'll add some of these words to the node description though.

Thanks,

Signature · 3 lines
Anton Vorontsov
email: [email protected]
irc://irc.freenode.net/bd2
#3 lore raw
Quoted 40 lines · Anton Vorontsov
Quoted 24 lines · Kumar Gala
Quoted 21 lines · Anton Vorontsov

This patch adds few bindings for the new drivers to be submitted through
the appropriate maintainers.

---

Segher, thanks for the comments on the previous version. Do you see any
issues with this one or anything I could improve further?

And if there are no issues... Kumar, could you apply this for powerpc-next?

Thanks.

Documentation/powerpc/booting-without-of.txt | 111 +++++++++++++++ ++
+++++++++

1 files changed, 111 insertions(+), 0 deletions(-)
Quoted 14 lines

Documentation/powerpc/booting-without-of.txt Table of Contents · line 66

Quoted 11 lines
(quoted diff) renamed from Documentation/powerpc/booting-without-of.txt +0 -0

Documentation/powerpc/booting-without-of.txt
index b68684d..a7ea549 100644

Documentation/powerpc/booting-without-of.txt +2 -0
@@ -62,6 +62,10 @@ Table of Contents
     s) Freescale on board FPGA
     t) Freescael MSI interrupt controller
     u) Freescale General-purpose Timers Module
+      v) Freescale QUICC Engine USB Controller
+      w) Freescale MCU with MPC8349E-mITX compatible firmware

MCU doesn't mean much to me. Its good to expand out the acronym at least once.

Quoted 8 lines

MCU stands for MicroController Unit, and even expanded this doesn't mean much to anybody. :-) Freescale documentation names it as boards' "MCU Subsystem", that is, the chip provides fan control, GPIOs, software halt, etc. Basically, it is boards' power management companion chip. I don't know how to name it more correctly, so I adhered to documentation's naming (they simply call it MCU).

^^ I'll add some of these words to the node description though.

I agree, but MicroController lets me a know a bit more than the random letters M-C-U. Just one reference in the heading is sufficient.

- k

#4 lore raw

PATCH v2 1/1 powerpc: add FHCI USB, FSL MCU, FSL UPM and GPIO LEDs bindings

This patch adds few bindings for the new drivers to be submitted through the appropriate maintainers.

---

Updated to decrypt MCU, and to split the bindings into appropriate files.

 .../powerpc/device-tree/fsl/mcu-mpc8349emitx.txt   |   17 +++++++++
 Documentation/powerpc/device-tree/fsl/qe/usb.txt   |   37 ++++++++++++++++++++
 Documentation/powerpc/device-tree/fsl/upm-nand.txt |   28 +++++++++++++++
 Documentation/powerpc/device-tree/gpio/led.txt     |   15 ++++++++
 4 files changed, 97 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/powerpc/device-tree/fsl/mcu-mpc8349emitx.txt
 create mode 100644 Documentation/powerpc/device-tree/fsl/qe/usb.txt
 create mode 100644 Documentation/powerpc/device-tree/fsl/upm-nand.txt
 create mode 100644 Documentation/powerpc/device-tree/gpio/led.txt
Documentation/powerpc/device-tree/fsl/mcu-mpc8349emitx.txt new file +17 -0
new file mode 100644
index 0000000..0f76633
@@ -0,0 +1,17 @@
+Freescale MPC8349E-mITX-compatible Power Management Micro Controller Unit (MCU)
+
+Required properties:
+- compatible : "fsl,<mcu-chip>-<board>", "fsl,mcu-mpc8349emitx".
+- reg : should specify I2C address (0x0a).
+- #gpio-cells : should be 2.
+- gpio-controller : should be present.
+
+Example:
+
+mcu@0a {
+	#gpio-cells = <2>;
+	compatible = "fsl,mc9s08qg8-mpc8349emitx",
+		     "fsl,mcu-mpc8349emitx";
+	reg = <0x0a>;
+	gpio-controller;
+};
Documentation/powerpc/device-tree/fsl/qe/usb.txt new file +37 -0
new file mode 100644
index 0000000..9ccd5f3
@@ -0,0 +1,37 @@
+Freescale QUICC Engine USB Controller
+
+Required properties:
+- compatible : should be "fsl,<chip>-qe-usb", "fsl,mpc8323-qe-usb".
+- reg : the first two cells should contain usb registers location and
+  length, the next two two cells should contain PRAM location and
+  length.
+- interrupts : should contain USB interrupt.
+- interrupt-parent : interrupt source phandle.
+- fsl,fullspeed-clock : specifies the full speed USB clock source:
+  "none": clock source is disabled
+  "brg1" through "brg16": clock source is BRG1-BRG16, respectively
+  "clk1" through "clk24": clock source is CLK1-CLK24, respectively
+- fsl,lowspeed-clock : specifies the low speed USB clock source:
+  "none": clock source is disabled
+  "brg1" through "brg16": clock source is BRG1-BRG16, respectively
+  "clk1" through "clk24": clock source is CLK1-CLK24, respectively
+- hub-power-budget : USB power budget for the root hub, in mA.
+- gpios : should specify GPIOs in this order: USBOE, USBTP, USBTN, USBRP,
+  USBRN, SPEED (optional), and POWER (optional).
+
+Example:
+
+usb@6c0 {
+	compatible = "fsl,mpc8360-qe-usb", "fsl,mpc8323-qe-usb";
+	reg = <0x6c0 0x40 0x8b00 0x100>;
+	interrupts = <11>;
+	interrupt-parent = <&qeic>;
+	fsl,fullspeed-clock = "clk21";
+	gpios = <&qe_pio_b  2 0 /* USBOE */
+		 &qe_pio_b  3 0 /* USBTP */
+		 &qe_pio_b  8 0 /* USBTN */
+		 &qe_pio_b  9 0 /* USBRP */
+		 &qe_pio_b 11 0 /* USBRN */
+		 &qe_pio_e 20 0 /* SPEED */
+		 &qe_pio_e 21 0 /* POWER */>;
+};
Documentation/powerpc/device-tree/fsl/upm-nand.txt new file +28 -0
new file mode 100644
index 0000000..84a04d5
@@ -0,0 +1,28 @@
+Freescale Localbus UPM programmed to work with NAND flash
+
+Required properties:
+- compatible : "fsl,upm-nand".
+- reg : should specify localbus chip select and size used for the chip.
+- fsl,upm-addr-offset : UPM pattern offset for the address latch.
+- fsl,upm-cmd-offset : UPM pattern offset for the command latch.
+- gpios : may specify optional GPIO connected to the Ready-Not-Busy pin.
+
+Example:
+
+upm@1,0 {
+	compatible = "fsl,upm-nand";
+	reg = <1 0 1>;
+	fsl,upm-addr-offset = <16>;
+	fsl,upm-cmd-offset = <8>;
+	gpios = <&qe_pio_e 18 0>;
+
+	flash {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "...";
+
+		partition@0 {
+			...
+		};
+	};
+};
Documentation/powerpc/device-tree/gpio/led.txt new file +15 -0
new file mode 100644
index 0000000..ff51f4c
@@ -0,0 +1,15 @@
+LED connected to GPIO
+
+Required properties:
+- compatible : should be "gpio-led".
+- label : (optional) the label for this LED. If omitted, the label is
+  taken from the node name (excluding the unit address).
+- gpios : should specify LED GPIO.
+
+Example:
+
+led@0 {
+	compatible = "gpio-led";
+	label = "hdd";
+	gpios = <&mcu_pio 0 1>;
+};
Signature · 1 line
1.5.5.4
Applied
#5 lore raw
Quoted 14 lines · Anton Vorontsov

This patch adds few bindings for the new drivers to be submitted through the appropriate maintainers.

---

Updated to decrypt MCU, and to split the bindings into appropriate files.

.../powerpc/device-tree/fsl/mcu-mpc8349emitx.txt   |   17 +++++++++
Documentation/powerpc/device-tree/fsl/qe/usb.txt   |   37 +++++++++++ 

+++++++++
Documentation/powerpc/device-tree/fsl/upm-nand.txt | 28 +++++++++++
++++
Documentation/powerpc/device-tree/gpio/led.txt | 15 ++++++++

Quoted 5 lines
4 files changed, 97 insertions(+), 0 deletions(-)

create mode 100644 Documentation/powerpc/device-tree/fsl/mcu-mpc8349emitx.txt create mode 100644 Documentation/powerpc/device-tree/fsl/qe/usb.txt create mode 100644 Documentation/powerpc/device-tree/fsl/upm-nand.txt create mode 100644 Documentation/powerpc/device-tree/gpio/led.txt

applied.

- k

#6 lore raw
Quoted 26 lines · Kumar Gala
Quoted 16 lines · Anton Vorontsov

This patch adds few bindings for the new drivers to be submitted through
the appropriate maintainers.

---

Updated to decrypt MCU, and to split the bindings into appropriate files.

.../powerpc/device-tree/fsl/mcu-mpc8349emitx.txt   |   17 +++++++++
Documentation/powerpc/device-tree/fsl/qe/usb.txt   |   37 +++++++++++ 

+++++++++
Documentation/powerpc/device-tree/fsl/upm-nand.txt | 28 +++++++++++
++++
Documentation/powerpc/device-tree/gpio/led.txt | 15 ++++++++

Quoted 6 lines
4 files changed, 97 insertions(+), 0 deletions(-)

create mode 100644 Documentation/powerpc/device-tree/fsl/mcu- mpc8349emitx.txt
create mode 100644 Documentation/powerpc/device-tree/fsl/qe/usb.txt create mode 100644 Documentation/powerpc/device-tree/fsl/upm-nand.txt create mode 100644 Documentation/powerpc/device-tree/gpio/led.txt

Quoted 1 line

applied.

Ugh, you fixed bindings' directory in Jochen's CPM patch, but not in my patch:

commit 91993d56812fd09b6cccea12d3c83df623cb0ea6

Author: Anton Vorontsov <[email protected]>
Date:   Fri Jul 4 20:53:28 2008 +0400

powerpc: add FHCI USB, FSL MCU, FSL UPM and GPIO LEDs bindings

This patch adds few bindings for the new drivers to be submitted through the appropriate maintainers.

Documentation/powerpc/device-tree/fsl/mcu-mpc8349emitx.txt new file +0 -0
new file mode 100644
index 0000000..0f76633

....

Signature · 3 lines
Anton Vorontsov
email: [email protected]
irc://irc.freenode.net/bd2
#7 lore raw
Quoted 22 lines
Quoted 1 line

Ugh, you fixed bindings' directory in Jochen's CPM patch, but not in my patch:

commit 91993d56812fd09b6cccea12d3c83df623cb0ea6

Author: Anton Vorontsov <[email protected]>
Date:   Fri Jul 4 20:53:28 2008 +0400

powerpc: add FHCI USB, FSL MCU, FSL UPM and GPIO LEDs bindings

This patch adds few bindings for the new drivers to be submitted
through
the appropriate maintainers.

Documentation/powerpc/device-tree/fsl/mcu-mpc8349emitx.txt new file +0 -0
new file mode 100644
index 0000000..0f76633

Documentation/powerpc/device-tree/fsl/mcu-mpc8349emitx.txt

Quoted 1 line
Documentation/powerpc/device-tree/fsl/mcu-mpc8349emitx.txt new file +0 -0
....

Rebased the tree and fixed it. Can you look over the files and make sure everything looks ok. (I'm partially concerned about the QE usb node).

- k

#8 lore raw
Quoted 17 lines · Kumar Gala
Quoted 17 lines
Quoted 1 line

Ugh, you fixed bindings' directory in Jochen's CPM patch, but not in my patch:

commit 91993d56812fd09b6cccea12d3c83df623cb0ea6

Author: Anton Vorontsov <[email protected]>
Date:   Fri Jul 4 20:53:28 2008 +0400

powerpc: add FHCI USB, FSL MCU, FSL UPM and GPIO LEDs bindings

This patch adds few bindings for the new drivers to be submitted
through
the appropriate maintainers.

Quoted 12 lines

Documentation/powerpc/device-tree/fsl/mcu-mpc8349emitx.txt

Quoted 8 lines
(quoted diff) +0 -0

mpc8349emitx.txt b/Documentation/powerpc/device-tree/fsl/mcu- mpc8349emit
new file mode 100644
index 0000000..0f76633

Documentation/powerpc/device-tree/fsl/mcu-mpc8349emitx.txt new file +0 -0
....

Rebased the tree and fixed it. Can you look over the files and make sure everything looks ok. (I'm partially concerned about the QE usb node).

Yes, everything looks fine. b-w-of specified old QE USB bindings, and no single driver actually used them.

Thanks,

Signature · 3 lines
Anton Vorontsov
email: [email protected]
irc://irc.freenode.net/bd2
#9 lore raw
In reply to Anton Vorontsov
Quoted 22 lines
Quoted 1 line

Ugh, you fixed bindings' directory in Jochen's CPM patch, but not in my patch:

commit 91993d56812fd09b6cccea12d3c83df623cb0ea6

Author: Anton Vorontsov <[email protected]>
Date:   Fri Jul 4 20:53:28 2008 +0400

powerpc: add FHCI USB, FSL MCU, FSL UPM and GPIO LEDs bindings

This patch adds few bindings for the new drivers to be submitted
through
the appropriate maintainers.

Documentation/powerpc/device-tree/fsl/mcu-mpc8349emitx.txt new file +0 -0
new file mode 100644
index 0000000..0f76633

Documentation/powerpc/device-tree/fsl/mcu-mpc8349emitx.txt

Quoted 1 line
Documentation/powerpc/device-tree/fsl/mcu-mpc8349emitx.txt new file +0 -0
....

duh. will fix it up.

- k

#10 lore raw
In reply to Anton Vorontsov

Hi Anton,

Quoted 10 lines · Anton Vorontsov

This patch adds few bindings for the new drivers to be submitted through the appropriate maintainers.

---

Segher, thanks for the comments on the previous version. Do you see any issues with this one or anything I could improve further?

And if there are no issues... Kumar, could you apply this for powerpc-next?

As you know, I have some additions to your bindings and I posted a patch recently:

http://ozlabs.org/pipermail/linuxppc-dev/2008-June/058617.html

Segher did not comment yet, maybe you would like to have a look. And do you have some news about the corresponding NAND support from the MTD people?

I really appreciate breaking booting-without-of.txt up. Will this happen already for powerpc-next (for 2.6.27)?

Thanks,

Wolfgang.