Skip to contentSkip to conversation

git-clone --quiet broken?

DISCUSSION Dave Jones 4 participants 5 messages Jun 15, 2016

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

The server I run various git snapshots on recently got upgraded to git 1.5.6, and I started getting a lot more mail from cron than usual.
It seems that passing -q to git-clone at some point changed from 'silent' to 'slightly less noisy'. Only the difference is so slight that it may as well be nil..

Here's a normal clone..

Initialize git/.git
Initialized empty Git repository in /home/davej/git-trees/git/.git/
remote: Counting objects: 76925, done.
remote: Compressing objects: 100% (25373/25373), done.
remote: Total 76925 (delta 55699), reused 70336 (delta 50160) Receiving objects: 100% (76925/76925), 17.09 MiB | 1111 KiB/s, done. Resolving deltas: 100% (55699/55699), done.

And here's the 'quiet' clone..

Initialize git/.git
remote: Counting objects: 76925, done.
remote: Compressing objects: 100% (25373/25373), done.
remote: Total 76925 (delta 55699), reused 70336 (delta 50160) Receiving objects: 100% (76925/76925), 17.09 MiB | 1128 KiB/s, done. Resolving deltas: 100% (55699/55699), done.

Spot the difference :)

It looks even worse in mail from cron, where you get one line of text for every % that git progresses through.

I could run the clone with 2>/dev/null, but I'd really like to get mail when something breaks instead of it being totally silent.

I'm assuming this was an unintentional side-effect of some other recent change?

Dave

Signature · 1 line
http://www.codemonkey.org.uk
#1 lore raw
Quoted 6 lines · Dave Jones

The server I run various git snapshots on recently got upgraded to git 1.5.6,
...
I could run the clone with 2>/dev/null, but I'd really like to get mail when something breaks instead of it being totally silent.

I'm assuming this was an unintentional side-effect of some other recent change?

Yeah, I would assume so, too ;-)

Daniel, is this enough? From re-reading the scripted version of git-clone, it appears that we *might* need to squelch no-progress if the stdout is not tty; I do not offhand if you got that right when you rewrote this in C.

 transport.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
transport.c +2 -1
index 3ff8519..b2f0d8a 100644
@@ -645,7 +645,8 @@ static int fetch_refs_via_pack(struct transport *transport,
 	args.lock_pack = 1;
 	args.use_thin_pack = data->thin;
 	args.include_tag = data->followtags;
-	args.verbose = transport->verbose > 0;
+	args.verbose = (transport->verbose > 0);
+	args.quiet = (transport->verbose < 0);
 	args.depth = data->depth;
 
 	for (i = 0; i < nr_heads; i++)
#2 lore raw
Quoted 7 lines · Junio C Hamano
Quoted 5 lines · Dave Jones

The server I run various git snapshots on recently got upgraded to git 1.5.6,
...
I could run the clone with 2>/dev/null, but I'd really like to get mail when something breaks instead of it being totally silent.

Quoted 8 lines
Quoted 1 line

I'm assuming this was an unintentional side-effect of some other recent change?

Yeah, I would assume so, too ;-)

Daniel, is this enough? From re-reading the scripted version of git-clone, it appears that we *might* need to squelch no-progress if the stdout is not tty; I do not offhand if you got that right when you rewrote this in C.

This is probably enough for what people actually care about (when stdout isn't a tty and isn't /dev/null, people are likely to ask for "quiet" anyway, because this command's output isn't interesting after the fact). But no-progress is probably a good idea anyway.

Oh, and you're fixing the corresponding regressions in fetch, which nobody seems to have mentioned previously.

Quoted 8 lines
 transport.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
transport.c +0 -0
index 3ff8519..b2f0d8a 100644

transport.c static int fetch_refs_via_pack(struct transport *transport, · line 649

Quoted 6 lines
transport.c +2 -1
@@ -645,7 +645,8 @@ static int fetch_refs_via_pack(struct transport *transport,
 	args.lock_pack = 1;
 	args.use_thin_pack = data->thin;
 	args.include_tag = data->followtags;
-	args.verbose = transport->verbose > 0;
+	args.verbose = (transport->verbose > 0);
+	args.quiet = (transport->verbose < 0);

And:
+ args.no_progress = !isatty(1);

Quoted 3 lines
transport.c +0 -0
 	args.depth = data->depth;
 
 	for (i = 0; i < nr_heads; i++)
#3 lore raw
In reply to Junio C Hamano

Junio C Hamano, Sun, Jul 06, 2008 02:56:17 +0200:

Quoted 7 lines
Quoted 5 lines · Dave Jones

The server I run various git snapshots on recently got upgraded to git 1.5.6,
...
I could run the clone with 2>/dev/null, but I'd really like to get mail when something breaks instead of it being totally silent.

Quoted 8 lines
Quoted 1 line

I'm assuming this was an unintentional side-effect of some other recent change?

Yeah, I would assume so, too ;-)

Daniel, is this enough? From re-reading the scripted version of git-clone, it appears that we *might* need to squelch no-progress if the stdout is not tty; I do not offhand if you got that right when you rewrote this in C.

While at it, could we please have the first "Initialize" message removed?

Initialize git/.git
Initialized empty Git repository in /home/davej/git-trees/git/.git/

The default output looks redundant (that of init_db too, but the full path can be useful sometimes). Something like this, perhaps:

builtin-clone.c +0 -1
index 643c7d4..4a0f1ab 100644
@@ -421,7 +421,6 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
 		die("could not create leading directories of '%s'", git_dir);
 	set_git_dir(make_absolute_path(git_dir));
 
-	fprintf(stderr, "Initialize %s\n", git_dir);
 	init_db(option_template, option_quiet ? INIT_DB_QUIET : 0);
 
 	/*
#4 lore raw
Quoted 14 lines · Alex Riesen

While at it, could we please have the first "Initialize" message removed?

Initialize git/.git
Initialized empty Git repository in /home/davej/git-trees/git/.git/

The default output looks redundant (that of init_db too, but the full path can be useful sometimes). Something like this, perhaps:

builtin-clone.c +0 -0
index 643c7d4..4a0f1ab 100644

builtin-clone.c int cmd_clone(int argc, const char **argv, const char *prefix) · line 426

Quoted 7 lines
builtin-clone.c +0 -1
@@ -421,7 +421,6 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
 		die("could not create leading directories of '%s'", git_dir);
 	set_git_dir(make_absolute_path(git_dir));
 
-	fprintf(stderr, "Initialize %s\n", git_dir);
 	init_db(option_template, option_quiet ? INIT_DB_QUIET : 0);
 
 	/*

Yeah, that's clearly left-over debugging, and I think that's the only one left from this conversion, anyway.