Skip to contentSkip to conversation

:arm926ejs: Regression to remove inappropriate LED control code from arch init start.S

PATCH New Daniel Allred 3 participants 3 messages May 19, 2008 – Jul 5, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 :arm926ejs: Regression to remove inappropriate LED control code from arch init start.S

cpu/arm926ejs/start.S:

Removed code to LED init since it is not specific to the ARM CPU, but rather should go in the board/platform specific files.

Signed-off-by Daniel Allred <djallred <at> gmail...>
cpu/arm926ejs/start.S renamed from cpu/arm926ejs/start.S.orig +0 -3
@@ -182,9 +182,6 @@ clbss_l:str	r2, [r0]		/* clear loop...
 	cmp	r0, r1
 	ble	clbss_l
 
-	bl coloured_LED_init
-	bl red_LED_on
-
 	ldr	pc, _start_armboot
 
 _start_armboot:
#1 lore raw

PATCH 1/1 :arm926ejs: Regression to remove inappropriate LED control code from arch init start.S

Hi,

Quoted 2 lines
Quoted 2 lines

Removed code to LED init since it is not specific to the ARM CPU, but rather should go in the board/platform specific files.

I second that

Regards
Gururaja

Signature · 2 lines
View this message in context: http://www.nabble.com/-PATCH-%3Aarm926ejs%3A-Regression-to-remove-inappropriate-LED-control-code-from-arch-init-start.S-tp17328568p17333758.html
Sent from the Uboot - Users mailing list archive at Nabble.com.
#2 lore raw

PATCH 1/1 :arm926ejs: Regression to remove inappropriate LED control code from arch init start.S

In reply to Daniel Allred
Quoted 6 lines · In message <[email protected]> you…

cpu/arm926ejs/start.S:

Removed code to LED init since it is not specific to the ARM CPU, but rather should go in the board/platform specific files.

Signed-off-by Daniel Allred <djallred <at> gmail...>

Please provide a non-garbled, working mail address in your Signed-off-by line.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
He is truly wise who gains wisdom from another's mishap.