Skip to contentSkip to conversation

query about change to $(MAKE) definition

Buildroot Hamish Moffatt 3 participants 4 messages Jul 8, 2008 Kbuild

lore
Share & tools
lore
#0 lore raw

Peter,

Can you explain the rationale behind the following change to package/Makefile.in you made last week?

It's causing my kernel builds to be very noisy now. I have a custom makefile for my kernel build, and I'm now getting a ton of

make[5]: warning: -jN forced in submake: disabling jobserver mode.

warnings from it, because $(MAKE) has changed from '/usr/bin/make -j2' to: '/usr/bin/make MAKE=/usr/bin/make -j2'.

So now -j2 is passed to every submake instance, rather than letting make itself do the right thing. I'm guessing other builds that do anything tricky might also suffer.

Thanks
Hamish

Makefile.in +4 -5
Index: package/Makefile.in
===================================================================
@@ -6,15 +6,14 @@
 endif
 HOSTMAKE :=$(shell $(CONFIG_SHELL) -c "which $(HOSTMAKE)" || type -p $(HOSTMAKE) || echo make)
 
-MAKE1:=$(HOSTMAKE) MAKE="$(firstword $(HOSTMAKE)) -j1"
-MAKE:=$(HOSTMAKE) -j$(BR2_JLEVEL)
-
 # honor silent mode
 ifeq (s,$(findstring s,$(MAKEFLAGS)))
-MAKE1+= -s
-MAKE+= -s
+MAKESILENT:=-s
 endif
 
+MAKE1:=$(HOSTMAKE) MAKE='$(firstword $(HOSTMAKE)) -j1 $(MAKESILENT)'
+MAKE:=$(HOSTMAKE) MAKE='$(firstword $(HOSTMAKE)) -j$(BR2_JLEVEL) $(MAKESILENT)'
+
 ifeq ($(BR2_OPTIMIZE_0),y)
 TARGET_OPTIMIZATION=-O0
 endif
Signature · 1 line
Hamish Moffatt VK3SB <[email protected]> <[email protected]>
#1 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Hamish" == Hamish Moffatt <[email protected]> writes:

Hi,

Hamish> Peter,
Hamish> Can you explain the rationale behind the following change to Hamish> package/Makefile.in you made last week?

Sure.

Hamish> It's causing my kernel builds to be very noisy now. I have a Hamish> custom makefile for my kernel build, and I'm now getting a Hamish> ton of

Hamish> make[5]: warning: -jN forced in submake: disabling jobserver mode.

Strange, I haven't seen that before.

Hamish> warnings from it, because $(MAKE) has changed from Hamish> '/usr/bin/make -j2' to: '/usr/bin/make MAKE=/usr/bin/make -j2'. Hamish> So now -j2 is passed to every submake instance, rather than Hamish> letting make itself do the right thing. I'm guessing other Hamish> builds that do anything tricky might also suffer.

Yeah, I wanted to propagate the HOSTMAKE setting to the sub makes and get -j and -s correct.

But now reading the make manual in details
(http://www.gnu.org/software/make/manual/html_node/Options_002fRecursion.html#Options_002fRecursion)
it seems like -s and -j are handled automatically, and from a quick test it indeed seems to be the case for -s. Strange, that's afaik no what I was seing before, hence the extra code.

The easiest would actually be if would get rid of the BR2_JLEVEL stuff completely and just let people use -j<whatever> on the top level make instead, then make should handle it all automatically. Why don't we do it like that? Is something in the toplevel makefile broken for parallel builds? (I know lots of other buildroot stuff is broken for parallel). Then we could also get rid of the HOSTMAKE thing and it would all boil down to:

MAKE1=$(MAKE) -j1

What do you say?

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw
Quoted 10 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Hamish" == Hamish Moffatt <[email protected]> writes:

The easiest would actually be if would get rid of the BR2_JLEVEL stuff completely and just let people use -j<whatever> on the top level make instead, then make should handle it all automatically. Why don't we do it like that? Is something in the toplevel makefile broken for parallel builds? (I know lots of other buildroot stuff is broken for parallel). Then we could also get rid of the HOSTMAKE thing and it would all boil down to:

Quoted 3 lines

MAKE1=$(MAKE) -j1

What do you say?

See ML archives where i talked about parallel builds and toplevel parallel builds.

HTH,

#3 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Bernhard" == Bernhard Fischer <[email protected]> writes:

Hi,

Quoted 1 line
Quoted 1 line

What do you say?

Bernhard> See ML archives where i talked about parallel builds and toplevel Bernhard> parallel builds.

Can you be more specific, I don't find anything right away on gmane.

Signature · 1 line
Bye, Peter Korsgaard