Skip to contentSkip to conversation

UIO: Change driver name of uio_pdrv

PATCH In review Hans J. Koch 2 participants 2 messages Jul 7, 2008 – Jul 8, 2008 Userspace I/O (UIO)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 UIO: Change driver name of uio_pdrv

Hi Greg,
I'm just about to use the generic UIO platform device driver in a project. I noticed the driver registers itself simply as "uio". We should choose a more unique name here. The oneliner below goes on top of the other UIO patches you've got in your queue right now. This is not in mainline yet.

Thanks,
Hans

-------------------------

The generic UIO platform device driver should be given a unique driver ID and not just "uio". This is especially important since Magnus Damm announced a similar driver named uio_pdrv_genirq. We should get the names right before this hits mainline.

---
 drivers/uio/uio_pdrv.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/uio/uio_pdrv.c +1 -1
Index: linux-2.6.26-rc/drivers/uio/uio_pdrv.c
===================================================================
@@ -12,7 +12,7 @@
 #include <linux/uio_driver.h>
 #include <linux/stringify.h>
 
-#define DRIVER_NAME "uio"
+#define DRIVER_NAME "uio_pdrv"
 
 struct uio_platdata {
 	struct uio_info *uioinfo;
#1 lore raw

Hi Hans,

Quoted 5 lines · Hans J. Koch

I'm just about to use the generic UIO platform device driver in a project. I noticed the driver registers itself simply as "uio". We should choose a more unique name here. The oneliner below goes on top of the other UIO patches you've got in your queue right now. This is not in mainline yet.

I don't care much, but IMHO "uio" is fine, because the name has a context (i.e. it's the name of a platform device) and so adding "_pdrv" doesn't yield a more clear result.

I don't claim to know all or even many platform drivers, the ones I currently use (and that are in mainline, too) are:

	gpio-keys
	i2c-gpio
	leds-gpio
	physmap-flash
	serial8250

and for all of these I consider it right not to have a "pdrv" suffix.

Quoted 4 lines

The generic UIO platform device driver should be given a unique driver ID and not just "uio". This is especially important since Magnus Damm announced a similar driver named uio_pdrv_genirq. We should get the names right before this hits mainline.

So using uio_genirq here would be the logical consequence.

But as I said, I don't care much and both options are fine for me.

Best regards
Uwe

Signature · 3 lines
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962