lxfb: Fix console blanking
PATCH 1/1 lxfb: Fix console blanking
The attached patch fixes console blanking in the Geode LX framebuffer. The current code blanks the DACs, but that does not appear to be enough to actually blank the screen (some characters remain visible).
The new code turns off the CRT enable bit for all modes, which forces blanking. Also, to save power the DAC is powered down in the more aggressive blanking modes.
Signature · 3 lines
Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc.
LXFB: Fix DAC blanking
From: Jordan Crouse <[email protected]>
Simply enabling DAC blanking without turning off the CRT seems to be resulting in characters remaining on the screen when the monitor blanks. This patch turns off the CRT for all modes, and also powers down the DACs when vsync and/or hsync are disabled.
---
drivers/video/geode/lxfb_ops.c | 28 ++++++++++++++++++---------- 1 files changed, 18 insertions(+), 10 deletions(-)
drivers/video/geode/lxfb_ops.c +18 -10
@@ -517,25 +517,25 @@ void lx_set_palette_reg(struct fb_info *info, unsigned regno,int lx_blank_display (struct fb_info *info,int blank_mode) {struct lxfb_par *par = info->par; -u32 dcfg, fp_pm; -int blank, hsync, vsync, crt; +u32 dcfg, misc, fp_pm; +int blank, hsync, vsync;/* CRT power saving modes. */ switch (blank_mode) {case FB_BLANK_UNBLANK : - blank =0 ; hsync =1 ; vsync =1 ; crt =1 ; + blank =0 ; hsync =1 ; vsync =1 ;break ;case FB_BLANK_NORMAL : - blank =1 ; hsync =1 ; vsync =1 ; crt =1 ; + blank =1 ; hsync =1 ; vsync =1 ;break ;case FB_BLANK_VSYNC_SUSPEND : - blank =1 ; hsync =1 ; vsync =0 ; crt =1 ; + blank =1 ; hsync =1 ; vsync =0 ;break ;case FB_BLANK_HSYNC_SUSPEND : - blank =1 ; hsync =0 ; vsync =1 ; crt =1 ; + blank =1 ; hsync =0 ; vsync =1 ;break ;case FB_BLANK_POWERDOWN : - blank =1 ; hsync =0 ; vsync =0 ; crt =0 ; + blank =1 ; hsync =0 ; vsync =0 ;break ;default :return -EINVAL ;
@@ -545,15 +545,23 @@ int lx_blank_display(struct fb_info *info, int blank_mode) dcfg &= ~(VP_DCFG_DAC_BL_EN |VP_DCFG_HSYNC_EN |VP_DCFG_VSYNC_EN |VP_DCFG_CRT_EN );if (!blank) - dcfg |=VP_DCFG_DAC_BL_EN ; + dcfg |=VP_DCFG_DAC_BL_EN |VP_DCFG_CRT_EN ;if (hsync) dcfg |=VP_DCFG_HSYNC_EN ;if (vsync) dcfg |=VP_DCFG_VSYNC_EN ; -if (crt) - dcfg |=VP_DCFG_CRT_EN ; +write_vp (par,VP_DCFG , dcfg); + misc =read_vp (par,VP_MISC ); + +if (vsync && hsync) + misc &= ~VP_MISC_DACPWRDN ; +else + misc |=VP_MISC_DACPWRDN ; + +write_vp (par,VP_MISC , misc); +/* Power on/off flat panel */ if (par->output &OUTPUT_PANEL ) {
-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
Linux-fbdev-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel
A message that is not in the archive (sent off-list or not yet received): [email protected]
Andres Salomon
Acked-byQuoted 8 lines · On Wed, 9 Jul 2008 10:35:44 -0600 Jordan Crouse…
The attached patch fixes console blanking in the Geode LX framebuffer. The current code blanks the DACs, but that does not appear to be enough to actually blank the screen (some characters remain visible).
The new code turns off the CRT enable bit for all modes, which forces blanking. Also, to save power the DAC is powered down in the more aggressive blanking modes.