mtd: SPI Flash: Winbond W25X16/WX2532/WX2564 support

PATCH New Jason McMullan 3 participants 7 messages Jun 18, 2008 – Nov 22, 2009 Memory technology devices (MTD)

lore

Share & tools

lore

Jason McMullan

author

2008-06-18 21:22 UTC #0 lore raw

PATCH 1/1 mtd: SPI Flash: Winbond W25X16/WX2532/WX2564 support

Add support for the Winbond W25X16/32/64 series of SPI Flash devices.

---
 drivers/mtd/spi/Makefile             |    1 +
 drivers/mtd/spi/spi_flash.c          |    5 +
 drivers/mtd/spi/spi_flash_internal.h |    1 +
 drivers/mtd/spi/winbond.c            |  331 ++++++++++++++++++++++++++++++++++
 4 files changed, 338 insertions(+), 0 deletions(-)
 create mode 100644 drivers/mtd/spi/winbond.c

drivers/mtd/spi/Makefile +1 -0

index 01b288a..5941235 100644
@@ -28,6 +28,7 @@ LIB	:= $(obj)libspi_flash.a
 COBJS-$(CONFIG_SPI_FLASH)	+= spi_flash.o
 COBJS-$(CONFIG_SPI_FLASH_ATMEL)	+= atmel.o
 COBJS-$(CONFIG_SPI_FLASH_STMICRO) += stmicro.o
+COBJS-$(CONFIG_SPI_FLASH_WINBOND) += winbond.o
 
 COBJS	:= $(COBJS-y)
 SRCS	:= $(COBJS:.o=.c)

drivers/mtd/spi/spi_flash.c +5 -0

index 35ce822..e81b1be 100644
@@ -134,6 +134,11 @@ struct spi_flash *spi_flash_probe(unsigned int bus, unsigned int cs,
 		flash = spi_flash_probe_atmel(spi, idcode);
 		break;
 #endif
+#ifdef CONFIG_SPI_FLASH_WINBOND
+	case 0xef:
+		flash = spi_flash_probe_winbond(spi, idcode);
+		break;
+#endif
 #ifdef CONFIG_SPI_FLASH_STMICRO
 	case 0x00:
 	case 0xff:

drivers/mtd/spi/spi_flash_internal.h +1 -0

index e5f758e..1eacb5c 100644
@@ -44,3 +44,4 @@ int spi_flash_read_common(struct spi_flash *flash, const u8 *cmd,
 struct spi_flash *spi_flash_probe_spansion(struct spi_slave *spi, u8 *idcode);
 struct spi_flash *spi_flash_probe_atmel(struct spi_slave *spi, u8 *idcode);
 struct spi_flash *spi_flash_probe_stmicro(struct spi_slave *spi, u8 *idcode);
+struct spi_flash *spi_flash_probe_winbond(struct spi_slave *spi, u8 *idcode);

drivers/mtd/spi/winbond.c new file +331 -0

331 lines not on this page · raw message

Signature · 1 line

1.5.4.3

Wolfgang Denk

2008-07-09 22:37 UTC #1 lore raw

PATCH 1/1 mtd: SPI Flash: Winbond W25X16/WX2532/WX2564 support

Quoted 2 lines · In message <[email protected]> you wrote:

Add support for the Winbond W25X16/32/64 series of SPI Flash devices.

Signed-off-by line is missing.

drivers/mtd/spi/winbond.c line 5

Quoted 8 lines

drivers/mtd/spi/winbond.c new file +5 -0

@@ -0,0 +1,331 @@
+/*
+ * Copyright 2008, Network Appliance Inc.
+ * Author: Jason McMullan <[email protected]>
+ *
+ */

GPL header is missing.

Please fix and resubmit.

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
        Ordnung ist die Lust der Vernunft,
        aber Unordnung die Wonne der Phantasie         - Paul Claudel

Mike Frysinger

2008-12-11 21:16 UTC #2 lore raw

PATCH 1/1 mtd: SPI Flash: Winbond W25X16/WX2532/WX2564 support

Quoted 18 lines · On Wednesday 09 July 2008 18:37:06 Wolfgang Denk wrote:

Quoted 2 lines · In message Jason McMullan
Add support for the Winbond W25X16/32/64 series of SPI Flash devices.
Signed-off-by line is missing.
drivers/mtd/spi/winbond.c line 5
Quoted 8 lines
drivers/mtd/spi/winbond.c new file +5 -0
@@ -0,0 +1,331 @@
+/*
+ * Copyright 2008, Network Appliance Inc.
+ * Author: Jason McMullan <[email protected]>
+ *
+ */
GPL header is missing.

Quoted 1 line

Please fix and resubmit.

Jason: could you fix these two minor issues so we can get this in ? :)
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20081211/c5a13fbd/attachment-0001.pgp

Mike Frysinger

2009-04-02 10:54 UTC #3 lore raw

PATCH 1/1 mtd: SPI Flash: Winbond W25X16/WX2532/WX2564 support

Quoted 19 lines · On Thursday 11 December 2008 16:16:29 Mike Frysinger wrote:

Quoted 18 lines · On Wednesday 09 July 2008 18:37:06 Wolfgang Denk wrote:
Quoted 2 lines · In message Jason McMullan
Add support for the Winbond W25X16/32/64 series of SPI Flash devices.
Signed-off-by line is missing.
drivers/mtd/spi/winbond.c line 5
Quoted 8 lines
drivers/mtd/spi/winbond.c new file +5 -0
@@ -0,0 +1,331 @@
+/*
+ * Copyright 2008, Network Appliance Inc.
+ * Author: Jason McMullan <[email protected]>
+ *
+ */
GPL header is missing.

Quoted 3 lines

Quoted 1 line
Please fix and resubmit.
Jason: could you fix these two minor issues so we can get this in ? :)

pretty pretty please ? ive merged and been maintaining this in the Blackfin git repo because we have some winbond parts, but it'd be nice to get this into mainline. i cant push it without your sign off :(.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090402/2470aa53/attachment.pgp

Mike Frysinger

2009-09-22 21:27 UTC #4 lore raw

PATCH 1/1 mtd: SPI Flash: Winbond W25X16/WX2532/WX2564 support

Quoted 20 lines · On Thursday 02 April 2009 06:54:59 Mike Frysinger wrote:

Quoted 19 lines · On Thursday 11 December 2008 16:16:29 Mike Frysinger wrote:
Quoted 18 lines · On Wednesday 09 July 2008 18:37:06 Wolfgang Denk wrote:
Quoted 2 lines · In message Jason McMullan
Add support for the Winbond W25X16/32/64 series of SPI Flash devices.
Signed-off-by line is missing.
drivers/mtd/spi/winbond.c line 5
Quoted 8 lines
drivers/mtd/spi/winbond.c new file +5 -0
@@ -0,0 +1,331 @@
+/*
+ * Copyright 2008, Network Appliance Inc.
+ * Author: Jason McMullan <[email protected]>
+ *
+ */
GPL header is missing.

Quoted 7 lines

Quoted 3 lines
Quoted 1 line
Please fix and resubmit.
Jason: could you fix these two minor issues so we can get this in ? :)
pretty pretty please ? ive merged and been maintaining this in the
Blackfin git repo because we have some winbond parts, but it'd be nice to get this into mainline. i cant push it without your sign off :(.

not sure if doing a routine 6-month ping is getting us anywhere. does anybody know people at netapp.com who can get this moving ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090922/963cebc8/attachment.pgp

Mike Frysinger

2009-10-09 21:12 UTC #5 lore raw

PATCH v2 1/1 sf: new driver for Winbond W25X16/32/64 devices

In reply to Wolfgang Denk

From: Jason McMullan <[email protected]>

Signed-off-by Jason McMullan <[email protected]>

Signed-off-by Mike Frysinger <[email protected]>

---
v2
- fix up issues after talking to Jason

Wolfgang: is this ok to merge for this release ? it's been sitting around for a long time and the only problem with it was legal stuff from Jason. i found his new e-mail address and was able to sort that out. it's a new driver, so shouldnt cause regressions.

 drivers/mtd/spi/Makefile             |    1 +
 drivers/mtd/spi/spi_flash.c          |    5 +
 drivers/mtd/spi/spi_flash_internal.h |    1 +
 drivers/mtd/spi/winbond.c            |  332 ++++++++++++++++++++++++++++++++++
 4 files changed, 339 insertions(+), 0 deletions(-)
 create mode 100644 drivers/mtd/spi/winbond.c

drivers/mtd/spi/Makefile +1 -0

index e3e0292..4f11b36 100644
@@ -31,6 +31,7 @@ COBJS-$(CONFIG_SPI_FLASH_MACRONIX)	+= macronix.o
 COBJS-$(CONFIG_SPI_FLASH_SPANSION)	+= spansion.o
 COBJS-$(CONFIG_SPI_FLASH_SST)	+= sst.o
 COBJS-$(CONFIG_SPI_FLASH_STMICRO)	+= stmicro.o
+COBJS-$(CONFIG_SPI_FLASH_WINBOND)	+= winbond.o
 COBJS-$(CONFIG_SPI_M95XXX) += eeprom_m95xxx.o
 
 COBJS	:= $(COBJS-y)

drivers/mtd/spi/spi_flash.c +5 -0

index 0c83231..0e1495b 100644
@@ -139,6 +139,11 @@ struct spi_flash *spi_flash_probe(unsigned int bus, unsigned int cs,
 		flash = spi_flash_probe_macronix(spi, idcode);
 		break;
 #endif
+#ifdef CONFIG_SPI_FLASH_WINBOND
+	case 0xef:
+		flash = spi_flash_probe_winbond(spi, idcode);
+		break;
+#endif
 #ifdef CONFIG_SPI_FLASH_STMICRO
 	case 0x20:
 		flash = spi_flash_probe_stmicro(spi, idcode);

drivers/mtd/spi/spi_flash_internal.h +1 -0

index 0612383..08546fb 100644
@@ -49,3 +49,4 @@ struct spi_flash *spi_flash_probe_atmel(struct spi_slave *spi, u8 *idcode);
 struct spi_flash *spi_flash_probe_macronix(struct spi_slave *spi, u8 *idcode);
 struct spi_flash *spi_flash_probe_sst(struct spi_slave *spi, u8 *idcode);
 struct spi_flash *spi_flash_probe_stmicro(struct spi_slave *spi, u8 *idcode);
+struct spi_flash *spi_flash_probe_winbond(struct spi_slave *spi, u8 *idcode);

drivers/mtd/spi/winbond.c new file +332 -0

332 lines not on this page · raw message

Signature · 1 line

1.6.5.rc2

Wolfgang Denk

Applied

2009-11-22 22:54 UTC #6 lore raw

PATCH v2 1/1 sf: new driver for Winbond W25X16/32/64 devices

Dear Mike Frysinger,

Quoted 13 lines · In message <[email protected]> you wrote:

From: Jason McMullan <[email protected]>
Signed-off-by Jason McMullan <[email protected]>
Signed-off-by Mike Frysinger <[email protected]>
---
v2
- fix up issues after talking to Jason
Wolfgang: is this ok to merge for this release ? it's been sitting around for a long time and the only problem with it was legal stuff from Jason. i found his new e-mail address and was able to sort that out. it's a new driver, so shouldnt cause regressions.

Quoted 6 lines

 drivers/mtd/spi/Makefile             |    1 +
 drivers/mtd/spi/spi_flash.c          |    5 +
 drivers/mtd/spi/spi_flash_internal.h |    1 +
 drivers/mtd/spi/winbond.c            |  332 ++++++++++++++++++++++++++++++++++
 4 files changed, 339 insertions(+), 0 deletions(-)
 create mode 100644 drivers/mtd/spi/winbond.c

Applied to "master", thanks.

Best regards,

Wolfgang Denk

Signature · 6 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
All these theories, diverse as they are, have two things  in  common:
they explain the observed facts, and they are completeley and utterly
wrong.                       - Terry Pratchett, _The Light Fantastic_