nohz: don't stop idle tick if softirqs are pending.
PATCH 1/1 nohz: don't stop idle tick if softirqs are pending.
Subject: [PATCH] nohz: don't stop idle tick if softirqs are pending.
From: Heiko Carstens <[email protected]>
In case a cpu goes idle but softirqs are pending only an error message is printed to the console. It may take a very long time until the pending softirqs will finally be executed. Worst case would be a hanging system.
With this patch the timer tick just continues and the softirqs will be executed after the next interrupt. Still a delay but better than a hanging system.
Currently we have at least two device drivers on s390 which under certain circumstances schedule a tasklet from process context. This is a reason why we can end up with pending softirqs when going idle. Fixing these drivers seems to be non-trivial.
However there is no question that the drivers should be fixed. This patch shouldn't be considered as a bug fix. It just is intended to keep a system running even if device drivers are buggy.
--- kernel/time/tick-sched.c | 1 + 1 file changed, 1 insertion(+)
kernel/time/tick-sched.c +1 -0
@@ -228,6 +228,7 @@ void tick_nohz_stop_sched_tick(void) local_softirq_pending()); ratelimit++; } + goto end; } ts->idle_calls++;
Ingo Molnar
AppliedQuoted 1 line · Heiko Carstens
Subject: [PATCH] nohz: don't stop idle tick if softirqs are pending.
applied to tip/timers/nohz, thanks Heiko.
Quoted 3 lines
However there is no question that the drivers should be fixed. This patch shouldn't be considered as a bug fix. It just is intended to keep a system running even if device drivers are buggy.
agreed.
Ingo