Skip to contentSkip to conversation

vt: do not update when the console is blanked

PATCH In review Stefano Stabellini 2 participants 2 messages Jul 11, 2008 – Jul 13, 2008

Subsystems (2)
Framebuffer layer Char and misc drivers
lore
Share & tools
lore

Stefano Stabellini

author
#0 lore raw

PATCH 1/1 vt: do not update when the console is blanked

Hi all,
vt.c DO_UPDATE macro checks if the console is visible but doesn't check if the console is blanked.
In fact updating fbcon while the console is blanked is not only unnecessary but can even cause screen corruption.
Therefore I am adding a simple check on console_blanked in DO_UPDATE.

Signed-off-by [email protected]

---

drivers/char/vt.c +1 -1
index 935f1c2..8d4bd3c 100644
@@ -261,7 +261,7 @@ static void notify_update(struct vc_data *vc)
 #ifdef VT_BUF_VRAM_ONLY
 #define DO_UPDATE(vc)	0
 #else
-#define DO_UPDATE(vc)	CON_IS_VISIBLE(vc)
+#define DO_UPDATE(vc)	(CON_IS_VISIBLE(vc) && !console_blanked)
 #endif
 
 static inline unsigned short *screenpos(struct vc_data *vc, int offset, int viewed)
#1 lore raw

(cc linux-fbdev-devel)

Quoted 17 lines · On Fri, 11 Jul 2008 15:50:18 +0100 Stefano Stabellini…

Hi all,
vt.c DO_UPDATE macro checks if the console is visible but doesn't check if the console is blanked.
In fact updating fbcon while the console is blanked is not only unnecessary but can even cause screen corruption.
Therefore I am adding a simple check on console_blanked in DO_UPDATE.

Signed-off-by [email protected]

---

drivers/char/vt.c +0 -0
index 935f1c2..8d4bd3c 100644

drivers/char/vt.c static void notify_update(struct vc_data *vc) · line 267

Quoted 8 lines
drivers/char/vt.c +1 -1
@@ -261,7 +261,7 @@ static void notify_update(struct vc_data *vc)
 #ifdef VT_BUF_VRAM_ONLY
 #define DO_UPDATE(vc)	0
 #else
-#define DO_UPDATE(vc)	CON_IS_VISIBLE(vc)
+#define DO_UPDATE(vc)	(CON_IS_VISIBLE(vc) && !console_blanked)
 #endif
 
 static inline unsigned short *screenpos(struct vc_data *vc, int offset, int viewed)

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08