ath5k: use positive logic for HP laptop LEDs

PATCH In review Bob Copeland 2 participants 3 messages Jul 15, 2008 – Jul 21, 2008 Networking drivers (wireless)

Share & tools

Bob Copeland

author

2008-07-15 17:07 UTC #0 lore raw

PATCH 1/1 ath5k: use positive logic for HP laptop LEDs

Helge Deller reports that HP laptops (NC4010 and NC6000) use active- high signals to turn on the LEDs. Previous code used active-low for all devices.

Signed-off-by Bob Copeland <[email protected]>

---
Other ath5k devs, any issues with this patch? Thread here for reference:

http://marc.info/?l=linux-wireless&m=121555862316630&w=2

 drivers/net/wireless/ath5k/base.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

drivers/net/wireless/ath5k/base.c +2 -2

index 217d506..3394b35 100644
@@ -2550,8 +2550,6 @@ ath5k_init_leds(struct ath5k_softc *sc)
 	struct pci_dev *pdev = sc->pdev;
 	char name[ATH5K_LED_MAX_NAME_LEN + 1];
 
-	sc->led_on = 0;  /* active low */
-
 	/*
 	 * Auto-enable soft led processing for IBM cards and for
 	 * 5211 minipci cards.

@@ -2560,11 +2558,13 @@ ath5k_init_leds(struct ath5k_softc *sc)
 	    pdev->device == PCI_DEVICE_ID_ATHEROS_AR5211) {
 		__set_bit(ATH_STAT_LEDSOFT, sc->status);
 		sc->led_pin = 0;
+		sc->led_on = 0;  /* active low */
 	}
 	/* Enable softled on PIN1 on HP Compaq nc6xx, nc4000 & nx5000 laptops */
 	if (pdev->subsystem_vendor == PCI_VENDOR_ID_COMPAQ) {
 		__set_bit(ATH_STAT_LEDSOFT, sc->status);
 		sc->led_pin = 1;
+		sc->led_on = 1;  /* active high */
 	}
 	if (!test_bit(ATH_STAT_LEDSOFT, sc->status))
 		goto out;

Signature · 4 lines

1.5.4.2.182.gb3092

-- 
Bob Copeland %% www.bobcopeland.com

Helge Deller

2008-07-21 21:43 UTC #1 lore raw

Bob, I think your patch below somehow got truncated and you wanted to send this patch ?
http://marc.info/?l=linux-wireless&m=121557127930799&w=2

Quoted 23 lines · Bob Copeland

Helge Deller reports that HP laptops (NC4010 and NC6000) use active- high signals to turn on the LEDs. Previous code used active-low for all devices.
Signed-off-by Bob Copeland <[email protected]>
---
Other ath5k devs, any issues with this patch? Thread here for reference:
http://marc.info/?l=linux-wireless&m=121555862316630&w=2
 drivers/net/wireless/ath5k/base.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0
b/drivers/net/wireless/ath5k/base.c index 217d506..3394b35 100644
drivers/net/wireless/ath5k/base.c +0 -1
@@ -2550,8 +2550,6 @@ ath5k_init_leds(struct ath5k_softc *sc)
 struct pci_dev *pdev = sc->pdev;
 char name[ATH5K_LED_MAX_NAME_LEN + 1];
 
-     sc->led_on = 0;  /* active low */

Bob Copeland

author

2008-07-21 21:58 UTC #2 lore raw

Quoted 4 lines · Helge Deller

Bob, I think your patch below somehow got truncated and you wanted to send this patch ?
http://marc.info/?l=linux-wireless&m=121557127930799&w=2

[...]

Quoted 2 lines

Quoted 2 lines
- sc->led_on = 0; /* active low */

Hmm, well it definitely didn't end there, but the version from this thread on marc's archive wasn't truncated. Maybe my mailer hiccuped when CCing you?

Anyway, yep, the patch is unchanged from the earlier posting.

Signature · 1 line

Bob Copeland %% www.bobcopeland.com