Skip to contentSkip to conversation

: Remove unused code from uboot-1.3.3/lib_arm/bootm.c

PATCH New Gururaja Hebbar K R 2 participants 4 messages Jul 15, 2008 – Jul 20, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : Remove unused code from uboot-1.3.3/lib_arm/bootm.c

Hi,

This patch removes an unused part of the code.

This code is only used in lib_avr32/bootm.c and in lib_arm/bootm.c it is under #if 0

Comments are welcome.

Regards
Gururaja

Signed off by: Gururaja Hebbar <[email protected]>

bootm.c renamed from bootm_orig.c +0 -3
@@ -43,9 +43,6 @@ static void setup_memory_tags (bd_t *bd)
 # endif
 static void setup_commandline_tag (bd_t *bd, char *commandline);
 
-#if 0
-static void setup_ramdisk_tag (bd_t *bd);
-#endif
 # ifdef CONFIG_INITRD_TAG
 static void setup_initrd_tag (bd_t *bd, ulong initrd_start,
 			      ulong initrd_end);

-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove_disabled_code.patch
Type: application/octet-stream
Size: 412 bytes
Desc: remove_disabled_code.patch
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080715/a82f3359/attachment.obj

#1 lore raw

PATCH 1/1 : Remove unused code from uboot-1.3.3/lib_arm/bootm.c

Quoted 2 lines · In message <[email protected]> you…

This patch removes an unused part of the code.

Sorry, this patch cannot be applied.

bootm.c

Quoted 2 lines
bootm.c renamed from bootm_orig.c +0 -0

...

error: bootm.c: does not exist in index
fatal: sha1 information is lacking or useless (bootm.c). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge.
...

Please read http://www.denx.de/wiki/UBoot/Patches for instructions how to prepare patches. I strongly recommend to use git0format-patch .

Please fix and resubmit

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Once upon a time, "PC" meant "personal computer".  Now  it  seems  to
only  mean  "Prisoner  of Bill". Alas! All my PCs run Unix, and those
include Intel, Sparc, and other processors.
          -- Tom "Bring back the non-PC meaning of `PC'" Christiansen
author
#2 lore raw

PATCH 1/1 : Remove unused code from uboot-1.3.3/lib_arm/bootm.c

Hi,

Sorry i had generated the patch from with uboot/lib_arm directory and hence i think it failed. now i have created the diff for the root directory where the uboot-1.3.3 folder resides. sorry for the trouble.

Thanks in advance.

Regards
Gururaja

Signed off by: Gururaja Hebbar <gururajakr@...>

lib_arm/bootm.c renamed from lib_arm_orig/bootm.c +0 -3
diff -purN uboot/lib_arm_orig/bootm.c uboot/lib_arm/bootm.c
@@ -43,9 +43,6 @@ static void setup_memory_tags (bd_t *bd)
 # endif
 static void setup_commandline_tag (bd_t *bd, char *commandline);
 
-#if 0
-static void setup_ramdisk_tag (bd_t *bd);
-#endif
 # ifdef CONFIG_INITRD_TAG
 static void setup_initrd_tag (bd_t *bd, ulong initrd_start,
 			      ulong initrd_end);

http://www.nabble.com/file/p18477587/removed_unused_code_lib_arm_bootm.patch
removed_unused_code_lib_arm_bootm.patch

Signature · 2 lines
View this message in context: http://www.nabble.com/-PATCH--%3A-Remove-unused-code-from-uboot-1.3.3-lib_arm-bootm.c-tp18460213p18477587.html
Sent from the Uboot - Users mailing list archive at Nabble.com.
#3 lore raw

PATCH 1/1 : Remove unused code from uboot-1.3.3/lib_arm/bootm.c

Quoted 4 lines · In message <[email protected]> you wrote:

Sorry i had generated the patch from with uboot/lib_arm directory and hence i think it failed. now i have created the diff for the root directory where the uboot-1.3.3 folder resides. sorry for the trouble.

Please use git tools (git-format-patch) to create the patch. Otherwise, at least put comments that are not intended to go into the commit message belo a line containing only three dashes:

---

Quoted 1 line

Signed off by: Gururaja Hebbar <gururajakr@...>

Please provide a valid mail address, and write "Signed-off-by:"

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"No problem is so formidable that you can't walk away from it."
- C. Schulz