Skip to contentSkip to conversation

powerpc: correct CMO feature flag enablement

PATCH In review Robert Jennings 2 participants 2 messages Jul 15, 2008 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: correct CMO feature flag enablement

Correct string conversion for rtas value being read for CMO configuration. A value of -1 in the string indicates that CMO is not enabled and we had used simple_strtoul rather than simple_strtol which caused problems.

---

This patch applies on top of the CMO patchset sent to the list.

---
 arch/powerpc/platforms/pseries/setup.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/powerpc/platforms/pseries/setup.c +2 -2
Index: b/arch/powerpc/platforms/pseries/setup.c
===================================================================
@@ -366,9 +366,9 @@ void pSeries_cmo_feature_init(void)
 			}
 
 			if (0 == strcmp(key, "PrPSP"))
-				PrPSP = simple_strtoul(value, NULL, 10);
+				PrPSP = simple_strtol(value, NULL, 10);
 			else if (0 == strcmp(key, "SecPSP"))
-				SecPSP = simple_strtoul(value, NULL, 10);
+				SecPSP = simple_strtol(value, NULL, 10);
 			value = key = ptr + 1;
 		}
 		ptr++;
#1 lore raw

Acked by: Brian King <[email protected]>

Quoted 30 lines · Robert Jennings

Correct string conversion for rtas value being read for CMO configuration. A value of -1 in the string indicates that CMO is not enabled and we had used simple_strtoul rather than simple_strtol which caused problems.

---

This patch applies on top of the CMO patchset sent to the list.

---
 arch/powerpc/platforms/pseries/setup.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: b/arch/powerpc/platforms/pseries/setup.c
===================================================================

arch/powerpc/platforms/pseries/setup.c +2 -2
@@ -366,9 +366,9 @@ void pSeries_cmo_feature_init(void)
 			}
 
 			if (0 == strcmp(key, "PrPSP"))
-				PrPSP = simple_strtoul(value, NULL, 10);
+				PrPSP = simple_strtol(value, NULL, 10);
 			else if (0 == strcmp(key, "SecPSP"))
-				SecPSP = simple_strtoul(value, NULL, 10);
+				SecPSP = simple_strtol(value, NULL, 10);
 			value = key = ptr + 1;
 		}
 		ptr++;
Signature · 3 lines
Brian King
Linux on Power Virtualization
IBM Linux Technology Center