Change Kbuild message to match default
PATCH 1/1 Change Kbuild message to match default
Change the Kbuild "If unsure" message to match the default.
init/Kconfig +1 -1
@@ -522,7 +522,7 @@ config CC_OPTIMIZE_FOR_SIZE Enabling this option will pass "-Os" instead of "-O2" to gcc resulting in a smaller kernel. - If unsure, say N. + If unsure, say Y. config SYSCTL bool
Quoted 10 lines · jkacur
Change the
Kbuild"If unsure" message to match the default.Signed-off-by John Kacur <jkacur at gmail dot com>Index: linux-2.6.26/init/Kconfig
===================================================================
init/Kconfig config CC_OPTIMIZE_FOR_SIZE · line 528
Quoted 8 lines
init/Kconfig +1
-1@@ -522,7 +522,7 @@ config CC_OPTIMIZE_FOR_SIZE Enabling this option will pass "-Os" instead of "-O2" to gcc resulting in a smaller kernel. - If unsure, say N. + If unsure, say Y. config SYSCTL bool
This seems like a no-brainer to me that the default and the "If unsure" message should match, any reason you haven't picked-it up?
Thanks
John Kacur
Quoted 16 lines · John Kacur
Quoted 15 lines · jkacur
Change the
Kbuild"If unsure" message to match the default.Signed-off-by John Kacur <jkacur at gmail dot com>Index: linux-2.6.26/init/Kconfig
===================================================================init/Kconfig +1
-1@@ -522,7 +522,7 @@ config CC_OPTIMIZE_FOR_SIZE Enabling this option will pass "-Os" instead of "-O2" to gcc resulting in a smaller kernel. - If unsure, say N. + If unsure, say Y.
Quoted 6 lines
init/Kconfig config CC_OPTIMIZE_FOR_SIZE · line 528
Quoted 3 lines
init/Kconfig +0
-0config SYSCTL boolThis seems like a no-brainer to me that the default and the "If unsure" message should match, any reason you haven't picked-it up?
Two reasons:
1) I have not started to look at new patches until now
And this is due to several reasons.
First off I have been without internet for a while. And secondly I do try to avoid new patches during the merge window which does not fix merge issues.
2) I am not convinced that "default y" is really what we want. What does popular distroes use (aka what gets wide testing?).
Sam
Quoted 24 lines · Sam Ravnborg
Quoted 16 lines · John Kacur
Quoted 15 lines · jkacur
Change the
Kbuild"If unsure" message to match the default.Signed-off-by John Kacur <jkacur at gmail dot com>Index: linux-2.6.26/init/Kconfig
===================================================================init/Kconfig +1
-1@@ -522,7 +522,7 @@ config CC_OPTIMIZE_FOR_SIZE Enabling this option will pass "-Os" instead of "-O2" to gcc resulting in a smaller kernel. - If unsure, say N. + If unsure, say Y.Quoted 6 lines
init/Kconfig config CC_OPTIMIZE_FOR_SIZE · line 528
Quoted 3 lines
init/Kconfig +0
-0config SYSCTL boolThis seems like a no-brainer to me that the default and the "If unsure" message should match, any reason you haven't picked-it up?
Quoted 8 lines
Two reasons:
1) I have not started to look at new patches until now
And this is due to several reasons.
First off I have been without internet for a while. And secondly I do try to avoid new patches during the merge window which does not fix merge issues.
Ok, no problem!
Quoted 4 lines
2) I am not convinced that "default y" is really what we want. What does popular distroes use (aka what gets wide testing?).
Hmnn, good point, in any case there is an inconsistency here. I can only speak for my laptop here running openSUSE 11.0 (X86-64)
gunzip -c /proc/config.gz | grep CC_OPTIMIZE_FOR_SIZE CONFIG_CC_OPTIMIZE_FOR_SIZE=y
uname -a
Linux linux-ipxk 2.6.25.11-0.1-default #1 SMP 2008-07-13 20:48:28 +0200 x86_64 x86_64 x86_64 GNU/Linux
Quoted 41 lines · John Kacur
Quoted 24 lines · Sam Ravnborg
Quoted 16 lines · John Kacur
Quoted 15 lines · jkacur
Change the
Kbuild"If unsure" message to match the default.Signed-off-by John Kacur <jkacur at gmail dot com>Index: linux-2.6.26/init/Kconfig
===================================================================init/Kconfig +1
-1@@ -522,7 +522,7 @@ config CC_OPTIMIZE_FOR_SIZE Enabling this option will pass "-Os" instead of "-O2" to gcc resulting in a smaller kernel. - If unsure, say N. + If unsure, say Y.Quoted 6 lines
init/Kconfig config CC_OPTIMIZE_FOR_SIZE · line 528
Quoted 3 lines
init/Kconfig +0
-0config SYSCTL boolThis seems like a no-brainer to me that the default and the "If unsure" message should match, any reason you haven't picked-it up?
Quoted 8 lines
Two reasons:
1) I have not started to look at new patches until now
And this is due to several reasons.
First off I have been without internet for a while. And secondly I do try to avoid new patches during the merge window which does not fix merge issues.Ok, no problem!
Quoted 4 lines
2) I am not convinced that "default y" is really what we want. What does popular distroes use (aka what gets wide testing?).
Quoted 8 lines
Hmnn, good point, in any case there is an inconsistency here. I can only speak for my laptop here running openSUSE 11.0 (X86-64)
gunzip -c
/proc/config.gz| grepCC_OPTIMIZE_FOR_SIZECONFIG_CC_OPTIMIZE_FOR_SIZE=y
uname -a
Linux linux-ipxk 2.6.25.11-0.1-default #1 SMP 2008-07-13 20:48:28 +0200x86_64x86_64x86_64GNU/Linux
Thanks - I applied your patch.
Sam