Make the git URL match usage
Quoted 12 lines · Jan Engelhardt
Review
Quoted 5 lines · jkacur
Change the
MAINTAINERSfile so that the git URL reads EXACTLY the way someone would use it.(quoted diff) +1
-1-T: git kernel.org:/pub/scm/linux/kernel/ericvh/v9fs.git +T: git://git.kernel.org:/pub/scm/linux/kernel/ericvh/v9fs.gitI would not use it that^ way.
Review
Quoted 2 lines
(quoted diff) +1
-1-git://git.kernel.org:/pub/scm/linux/kernel/ericvh/v9fs.git +git://git.kernel.org/pub/scm/linux/kernel/ericvh/v9fs.git
Yikes! Good catch, thank you, I've respun the patch below.
Subject: Make the git URL match the usage
Change the MAINTAINERS file so that the git URL reads EXACTLY the way someone would use it. They should only have to copy and paste it and not guess how to modify it. Secondly, drop the "git" type when the protocol is already git://
MAINTAINERS +67 -67
@@ -154,7 +154,7 @@ P: Latchesar Ionkov M: [email protected] L: [email protected] W: http://swik.net/v9fs -T: git kernel.org:/pub/scm/linux/kernel/ericvh/v9fs.git +T: git://git.kernel.org/pub/scm/linux/kernel/ericvh/v9fs.git S: Maintained A2232 SERIAL BOARD DRIVER
@@ -221,7 +221,7 @@ M: [email protected] M: [email protected] L: [email protected] W: http://www.lesswatts.org/projects/acpi/ -T: git kernel.org:/pub/scm/linux/kernel/git/lenb/linux-acpi-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux-acpi-2.6.git S: Supported ACPI BATTERY DRIVERS
@@ -298,7 +298,7 @@ P: Michael Wu M: [email protected] L: [email protected] W: http://linuxwireless.org/ -T: git kernel.org:/pub/scm/linux/kernel/git/mwu/mac80211-drivers.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/mwu/mac80211-drivers.git S: Maintained ADT746X FAN DRIVER
@@ -325,7 +325,7 @@ S: Maintained AGPGART DRIVER P: David Airlie M: [email protected] -T: git kernel.org:/pub/scm/linux/kernel/git/airlied/drm-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6.git S: Maintained AHA152X SCSI DRIVER
@@ -758,7 +758,7 @@ P: Eric Paris M: [email protected] L: [email protected] (subscribers-only) W: http://people.redhat.com/sgrubb/audit/ -T: git git.kernel.org/pub/scm/linux/kernel/git/viro/audit-current.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/viro/audit-current.git S: Maintained AUXILIARY DISPLAY DRIVERS
@@ -877,7 +877,7 @@ BLOCK LAYER P: Jens Axboe M: [email protected] L: [email protected] -T: git kernel.org:/pub/scm/linux/kernel/git/axboe/linux-2.6-block.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-2.6-block.git S: Maintained BLOCK2MTD DRIVER
@@ -895,7 +895,7 @@ L: [email protected] W: http://bluez.sf.net W: http://www.bluez.org W: http://www.holtmann.org/linux/bluetooth/ -T: git kernel.org:/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git S: Maintained BLUETOOTH RFCOMM LAYER
@@ -1019,7 +1019,7 @@ M: [email protected] M: [email protected] L: [email protected] W: http://linuxtv.org -T: git kernel.org:/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git S: Maintained CAFE CMOS INTEGRATED CAMERA CONTROLLER DRIVER
@@ -1091,7 +1091,7 @@ M: [email protected] L: [email protected] L: [email protected] W: http://linux-cifs.samba.org/ -T: git kernel.org:/pub/scm/linux/kernel/git/sfrench/cifs-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/sfrench/cifs-2.6.git S: Supported CONFIGFS
@@ -1190,7 +1190,7 @@ P: Dave Jones M: [email protected] L: [email protected] W: http://www.codemonkey.org.uk/projects/cpufreq/ -T: git kernel.org/pub/scm/linux/kernel/git/davej/cpufreq.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/davej/cpufreq.git S: Maintained CPUID/MSR DRIVER
@@ -1227,7 +1227,7 @@ M: [email protected] P: David S. Miller M: [email protected] L: [email protected] -T: git kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git S: Maintained CS5535 Audio ALSA driver
@@ -1389,7 +1389,7 @@ P: David Teigland M: [email protected] L: [email protected] W: http://sources.redhat.com/cluster/ -T: git kernel.org:/pub/scm/linux/kernel/git/teigland/dlm.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/dlm.git S: Supported DAVICOM FAST ETHERNET (DMFE) NETWORK DRIVER
@@ -1448,7 +1448,7 @@ DRM DRIVERS P: David Airlie M: [email protected] L: [email protected] -T: git kernel.org:/pub/scm/linux/kernel/git/airlied/drm-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6.git S: Maintained DSCC4 DRIVER
@@ -1462,7 +1462,7 @@ P: LinuxTV.org Project M: [email protected] L: [email protected] (subscription required) W: http://linuxtv.org/ -T: git kernel.org:/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git S: Maintained DZ DECSTATION DZ11 SERIAL DRIVER
@@ -1739,7 +1739,7 @@ P: Kristian Hoegsberg, Stefan Richter M: [email protected], [email protected] L: [email protected] W: http://www.linux1394.org/ -T: git kernel.org:/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6.git S: Maintained FIRMWARE LOADER (request_firmware)
@@ -1805,8 +1805,8 @@ P: Steven Whitehouse M: [email protected] L: [email protected] W: http://sources.redhat.com/cluster/ -T: git kernel.org:/pub/scm/linux/kernel/git/steve/gfs2-2.6-fixes.git -T: git kernel.org:/pub/scm/linux/kernel/git/steve/gfs2-2.6-nmw.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-2.6-fixes.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-2.6-nmw.git S: Supported GIGASET ISDN DRIVERS
@@ -1823,8 +1823,8 @@ P: Mark M. Hoffman M: [email protected] L: [email protected] W: http://www.lm-sensors.org/ -T: git lm-sensors.org:/kernel/mhoffman/hwmon-2.6.git testing -T: git lm-sensors.org:/kernel/mhoffman/hwmon-2.6.git release +T: git://git.lm-sensors.org/kernel/mhoffman/hwmon-2.6.git testing +T: git://git.lm-sensors.org/kernel/mhoffman/hwmon-2.6.git release S: Maintained HARDWARE RANDOM NUMBER GENERATOR CORE
@@ -1867,7 +1867,7 @@ HID CORE LAYER P: Jiri Kosina M: [email protected] L: [email protected] -T: git kernel.org:/pub/scm/linux/kernel/git/jikos/hid.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git S: Maintained HIGH-RESOLUTION TIMERS, CLOCKEVENTS, DYNTICKS
@@ -1993,7 +1993,7 @@ S: Maintained i386 SETUP CODE / CPU ERRATA WORKAROUNDS P: H. Peter Anvin M: [email protected] -T: git.kernel.org:/pub/scm/linux/kernel/git/hpa/linux-2.6-x86setup.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/hpa/linux-2.6-x86setup.git S: Maintained IA64 (Itanium) PLATFORM
@@ -2001,7 +2001,7 @@ P: Tony Luck M: [email protected] L: [email protected] W: http://www.ia64-linux.org/ -T: git kernel.org:/pub/scm/linux/kernel/git/aegl/linux-2.6.git +T: git://git kernel.org/pub/scm/linux/kernel/git/aegl/linux-2.6.git S: Maintained SN-IA64 (Itanium) SUB-PLATFORM
@@ -2068,7 +2068,7 @@ P: Stefan Richter M: [email protected] L: [email protected] W: http://www.linux1394.org/ -T: git kernel.org:/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6.git S: Maintained IEEE 1394 RAW I/O DRIVER (raw1394)
@@ -2092,7 +2092,7 @@ P: Hal Rosenstock M: [email protected] L: [email protected] W: http://www.openib.org/ -T: git kernel.org:/pub/scm/linux/kernel/git/roland/infiniband.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git S: Supported INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN) DRIVERS
@@ -2100,7 +2100,7 @@ P: Dmitry Torokhov M: [email protected] M: [email protected] L: [email protected] -T: git kernel.org:/pub/scm/linux/kernel/git/dtor/input.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git S: Maintained INOTIFY
@@ -2198,7 +2198,7 @@ M: [email protected] L: [email protected] L: [email protected] W: http://intellinuxwireless.org -T: git kernel.org:/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-2.6.git S: Supported IOC3 ETHERNET DRIVER
@@ -2232,7 +2232,7 @@ IPATH DRIVER: P: Ralph Campbell M: [email protected] L: [email protected] -T: git git://git.qlogic.com/ipath-linux-2.6 +T: git://git.qlogic.com/ipath-linux-2.6 S: Supported IPMI SUBSYSTEM
@@ -2268,7 +2268,7 @@ P: Mike Christie M: [email protected] L: [email protected] W: www.open-iscsi.org -T: git kernel.org:/pub/scm/linux/kernel/mnc/linux-2.6-iscsi.git +T: git://git.kernel.org/pub/scm/linux/kernel/mnc/linux-2.6-iscsi.git S: Maintained ISAPNP
@@ -2281,7 +2281,7 @@ P: Karsten Keil M: [email protected] L: [email protected] (subscribers-only) W: http://www.isdn4linux.de -T: git kernel.org:/pub/scm/linux/kernel/kkeil/isdn-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/kkeil/isdn-2.6.git S: Maintained ISDN SUBSYSTEM (Eicon active card driver)
@@ -2312,7 +2312,7 @@ P: Dave Kleikamp M: [email protected] L: [email protected] W: http://jfs.sourceforge.net/ -T: git kernel.org:/pub/scm/linux/kernel/git/shaggy/jfs-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/shaggy/jfs-2.6.git S: Supported JOURNALLING LAYER FOR BLOCK DEVICES (JBD)
@@ -2358,8 +2358,8 @@ S: Maintained KERNEL BUILD (kbuild: Makefile, scripts/Makefile.*) P: Sam Ravnborg M: [email protected] -T: git kernel.org:/pub/scm/linux/kernel/git/sam/kbuild-next.git -T: git kernel.org:/pub/scm/linux/kernel/git/sam/kbuild-fixes.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/sam/kbuild-next.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/sam/kbuild-fixes.git L: [email protected] S: Maintained
@@ -2493,7 +2493,7 @@ P: Benjamin Herrenschmidt M: [email protected] W: http://www.penguinppc.org/ L: [email protected] -T: git kernel.org:/pub/scm/linux/kernel/git/paulus/powerpc.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git S: Supported LINUX FOR POWER MACINTOSH
@@ -2520,7 +2520,7 @@ P: Matt Porter M: [email protected] W: http://www.penguinppc.org/ L: [email protected] -T: git kernel.org:/pub/scm/linux/kernel/git/jwboyer/powerpc.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/jwboyer/powerpc.git S: Maintained LINUX FOR POWERPC EMBEDDED XILINX VIRTEX
@@ -2562,7 +2562,7 @@ LINUX SECURITY MODULE (LSM) FRAMEWORK P: Chris Wright M: [email protected] L: [email protected] -T: git kernel.org:/pub/scm/linux/kernel/git/chrisw/lsm-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/chrisw/lsm-2.6.git S: Supported LM83 HARDWARE MONITOR DRIVER
@@ -2646,7 +2646,7 @@ P: Michael Wu M: [email protected] L: [email protected] W: http://linuxwireless.org/ -T: git kernel.org:/pub/scm/linux/kernel/git/linville/wireless-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git S: Maintained MAC80211 PID RATE CONTROL
@@ -2656,7 +2656,7 @@ P: Mattias Nissler M: [email protected] L: [email protected] W: http://linuxwireless.org/en/developers/Documentation/mac80211/RateControl/PID -T: git kernel.org:/pub/scm/linux/kernel/git/linville/wireless-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git S: Maintained MACVLAN DRIVER
@@ -2743,7 +2743,7 @@ P: David Woodhouse M: [email protected] W: http://www.linux-mtd.infradead.org/ L: [email protected] -T: git git://git.infradead.org/mtd-2.6.git +T: git://git.infradead.org/mtd-2.6.git S: Maintained UNSORTED BLOCK IMAGES (UBI)
@@ -2751,7 +2751,7 @@ P: Artem Bityutskiy M: [email protected] W: http://www.linux-mtd.infradead.org/ L: [email protected] -T: git git://git.infradead.org/~dedekind/ubi-2.6.git +T: git://git.infradead.org/~dedekind/ubi-2.6.git S: Maintained MICROTEK X6 SCANNER
@@ -2764,7 +2764,7 @@ P: Ralf Baechle M: [email protected] W: http://www.linux-mips.org/ L: [email protected] -T: git www.linux-mips.org:/pub/scm/linux.git +T: git://www.linux-mips.org/pub/scm/linux.git S: Supported MISCELLANEOUS MCA-SUPPORT
@@ -2934,7 +2934,7 @@ NETWORK DEVICE DRIVERS P: Jeff Garzik M: [email protected] L: [email protected] -T: git kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git S: Maintained NETWORKING [GENERAL]
@@ -2958,7 +2958,7 @@ M: [email protected] P: Patrick McHardy M: [email protected] L: [email protected] -T: git kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.git S: Maintained NETWORKING [LABELED] (NetLabel, CIPSO, Labeled IPsec, SECMARK)
@@ -2971,7 +2971,7 @@ NETWORKING [WIRELESS] P: John W. Linville M: [email protected] L: [email protected] -T: git kernel.org:/pub/scm/linux/kernel/git/linville/wireless-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git S: Maintained NETXEN (1/10) GbE SUPPORT
@@ -2996,7 +2996,7 @@ P: Trond Myklebust M: [email protected] L: [email protected] W: http://client.linux-nfs.org -T: git git://git.linux-nfs.org/pub/linux/nfs-2.6.git +T: git://git.linux-nfs.org/pub/linux/nfs-2.6.git S: Maintained NI5010 NETWORK DRIVER
@@ -3027,7 +3027,7 @@ M: [email protected] L: [email protected] L: [email protected] W: http://linux-ntfs.sf.net/ -T: git kernel.org:/pub/scm/linux/kernel/git/aia21/ntfs-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/aia21/ntfs-2.6.git S: Maintained NVIDIA (rivafb and nvidiafb) FRAMEBUFFER DRIVER
@@ -3049,7 +3049,7 @@ P: Joel Becker M: [email protected] L: [email protected] (moderated for non-subscribers) W: http://oss.oracle.com/projects/ocfs2/ -T: git git://git.kernel.org/pub/scm/linux/kernel/git/mfasheh/ocfs2.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/mfasheh/ocfs2.git S: Supported OMNIKEY CARDMAN 4000 DRIVER
@@ -3130,7 +3130,7 @@ P: Grant Grundler M: [email protected] L: [email protected] W: http://www.parisc-linux.org/ -T: git kernel.org:/pub/scm/linux/kernel/git/kyle/parisc-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/kyle/parisc-2.6.git S: Maintained PARAVIRT_OPS INTERFACE
@@ -3169,7 +3169,7 @@ P: Jesse Barnes M: [email protected] L: [email protected] L: [email protected] -T: git kernel.org:/pub/scm/linux/kernel/git/jbarnes/pci-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci-2.6.git S: Supported PCI HOTPLUG CORE
@@ -3187,7 +3187,7 @@ PCMCIA SUBSYSTEM P: Linux PCMCIA Team L: [email protected] W: http://lists.infradead.org/mailman/listinfo/linux-pcmcia -T: git kernel.org:/pub/scm/linux/kernel/git/brodo/pcmcia-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/brodo/pcmcia-2.6.git S: Maintained PCNET32 NETWORK DRIVER
@@ -3232,7 +3232,7 @@ M: [email protected] P: David Woodhouse M: [email protected] L: [email protected] -T: git git.infradead.org/battery-2.6.git +T: git://git.infradead.org/battery-2.6.git S: Maintained POWERPC 4xx EMAC DRIVER
@@ -3288,7 +3288,7 @@ P: Michael Wu M: [email protected] L: [email protected] W: http://prism54.org -T: git kernel.org:/pub/scm/linux/kernel/git/mwu/mac80211-drivers.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/mwu/mac80211-drivers.git S: Maintained PRISM54 WIRELESS DRIVER
@@ -3386,7 +3386,7 @@ L: [email protected] L: [email protected] W: http://rt2x00.serialmonkey.com/ S: Maintained -T: git kernel.org:/pub/scm/linux/kernel/git/ivd/rt2x00.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/ivd/rt2x00.git F: drivers/net/wireless/rt2x00/ RAMDISK RAM BLOCK DEVICE DRIVER
@@ -3475,7 +3475,7 @@ P: Andrea Merello M: [email protected] L: [email protected] W: http://linuxwireless.org/ -T: git kernel.org:/pub/scm/linux/kernel/git/mwu/mac80211-drivers.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/mwu/mac80211-drivers.git S: Maintained S3 SAVAGE FRAMEBUFFER DRIVER
@@ -3559,9 +3559,9 @@ SCSI SUBSYSTEM P: James E.J. Bottomley M: [email protected] L: [email protected] -T: git kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6.git -T: git kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6.git -T: git kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-pending-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-pending-2.6.git S: Maintained SCSI TAPE DRIVER
@@ -3620,7 +3620,7 @@ SERIAL ATA (SATA) SUBSYSTEM: P: Jeff Garzik M: [email protected] L: [email protected] -T: git kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git S: Supported SGI SN-IA64 (Altix) SERIAL CONSOLE DRIVER
@@ -3777,7 +3777,7 @@ P: Liam Girdwood M: [email protected] P: Mark Brown M: [email protected] -T: git opensource.wolfsonmicro.com/linux-2.6-asoc +T: git://opensource.wolfsonmicro.com/linux-2.6-asoc L: [email protected] (subscribers-only) S: Supported
@@ -3879,7 +3879,7 @@ P: Paul Mundt M: [email protected] L: [email protected] W: http://www.linux-sh.org -T: git kernel.org:/pub/scm/linux/kernel/git/lethal/sh-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/lethal/sh-2.6.git S: Maintained SUN3/3X
@@ -3943,7 +3943,7 @@ M: [email protected] L: [email protected] W: http://ibm-acpi.sourceforge.net W: http://thinkwiki.org/wiki/Ibm-acpi -T: git repo.or.cz/linux-2.6/linux-acpi-2.6/ibm-acpi-2.6.git +T: git://repo.or.cz/linux-2.6/linux-acpi-2.6/ibm-acpi-2.6.git S: Maintained TI FLASH MEDIA INTERFACE DRIVER
@@ -3973,7 +3973,7 @@ M: [email protected] L: [email protected] W: http://tipc.sourceforge.net/ W: http://tipc.cslab.ericsson.net/ -T: git tipc.cslab.ericsson.net:/pub/git/tipc.git +T: git://tipc.cslab.ericsson.net/pub/git/tipc.git S: Maintained TLAN NETWORK DRIVER
@@ -4083,7 +4083,7 @@ UltraSPARC (sparc64): P: David S. Miller M: [email protected] L: [email protected] -T: git kernel.org:/pub/scm/linux/kernel/git/davem/sparc-2.6.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc-2.6.git S: Maintained UNIFORM CDROM DRIVER
@@ -4164,7 +4164,7 @@ USB HID/HIDBP DRIVERS (USB KEYBOARDS, MI P: Jiri Kosina M: [email protected] L: [email protected] -T: git kernel.org:/pub/scm/linux/kernel/git/jikos/hid.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git S: Maintained USB ISP116X DRIVER
@@ -4415,7 +4415,7 @@ M: [email protected] M: [email protected] L: [email protected] W: http://linuxtv.org -T: git kernel.org:/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git S: Maintained VLAN (802.1Q)
@@ -4462,7 +4462,7 @@ S: Maintained WATCHDOG DEVICE DRIVERS P: Wim Van Sebroeck M: [email protected] -T: git kernel.org:/pub/scm/linux/kernel/git/wim/linux-2.6-watchdog.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/wim/linux-2.6-watchdog.git S: Maintained WAVELAN NETWORK DRIVER & WIRELESS EXTENSIONS
@@ -4496,7 +4496,7 @@ M: [email protected] P: Liam Girdwood M: [email protected] L: [email protected] -T: git git://opensource.wolfsonmicro.com/linux-2.6-touch +T: git://opensource.wolfsonmicro.com/linux-2.6-touch W: http://opensource.wolfsonmicro.com/node/7 S: Supported
@@ -4521,7 +4521,7 @@ P: Tim Shimmin M: [email protected] L: [email protected] W: http://oss.sgi.com/projects/xfs -T: git git://oss.sgi.com:8090/xfs/xfs-2.6.git +T: git://oss.sgi.com:8090/xfs/xfs-2.6.git S: Supported XILINX SYSTEMACE DRIVER
Quoted 30 lines · jkacur
Quoted 12 lines · Jan Engelhardt
Review
Quoted 5 lines · jkacur
Change the
MAINTAINERSfile so that the git URL reads EXACTLY the way someone would use it.(quoted diff) +1
-1-T: git kernel.org:/pub/scm/linux/kernel/ericvh/v9fs.git +T: git://git.kernel.org:/pub/scm/linux/kernel/ericvh/v9fs.gitI would not use it that^ way.
Review
Quoted 2 lines
(quoted diff) +1
-1-git://git.kernel.org:/pub/scm/linux/kernel/ericvh/v9fs.git +git://git.kernel.org/pub/scm/linux/kernel/ericvh/v9fs.gitYikes! Good catch, thank you, I've respun the patch below.
Subject: Make the git URL match the usage
Change theMAINTAINERSfile so that the git URL reads EXACTLY the way someone would use it. They should only have to copy and paste it and not guess how to modify it. Secondly, drop the "git" type when the protocol is alreadygit://Signed-off-by John Kacur <jkacur at gmail dot com>Index: linux-2.6.26/MAINTAINERS
===================================================================
MAINTAINERS P: Latchesar Ionkov · line 158
Quoted 6 lines
MAINTAINERS +1
-1@@ -154,7 +154,7 @@ P: Latchesar Ionkov M: [email protected] L: [email protected] W: http://swik.net/v9fs -T: git kernel.org:/pub/scm/linux/kernel/ericvh/v9fs.git +T: git://git.kernel.org/pub/scm/linux/kernel/ericvh/v9fs.git S: Maintained
This now looses information. Although it is obvious that this particular example (after conversion) is a git repository over git protocol this falls down for other forms, for example a git repository exported over http://
would appear as below:
T: http://www.kernel.org/pub/scm/linux/kernel/ericvh/v9fs.git
which would be indistiguishable from a quilt series such as Greg KH's which, if I follow your scheme logically ie. convert it to the same form, would also be represented as below:
T: http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/
I think your conversion makes sense in that the URL part should be exactly what one would use with the tool but you still need the tool designator:
T: git git://git.kernel.org/pub/scm/linux/kernel/ericvh/v9fs.git
T: git http://www.kernel.org/pub/scm/linux/kernel/ericvh/v9fs.git
T: guilt http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/
-apw
Quoted 55 lines · Andy Whitcroft
Quoted 30 lines · jkacur
Quoted 12 lines · Jan Engelhardt
Review
Quoted 5 lines · jkacur
Change the
MAINTAINERSfile so that the git URL reads EXACTLY the way someone would use it.(quoted diff) +1
-1-T: git kernel.org:/pub/scm/linux/kernel/ericvh/v9fs.git +T: git://git.kernel.org:/pub/scm/linux/kernel/ericvh/v9fs.gitI would not use it that^ way.
Review
Quoted 2 lines
(quoted diff) +1
-1-git://git.kernel.org:/pub/scm/linux/kernel/ericvh/v9fs.git +git://git.kernel.org/pub/scm/linux/kernel/ericvh/v9fs.gitYikes! Good catch, thank you, I've respun the patch below.
Subject: Make the git URL match the usage
Change theMAINTAINERSfile so that the git URL reads EXACTLY the way someone would use it. They should only have to copy and paste it and not guess how to modify it. Secondly, drop the "git" type when the protocol is alreadygit://Signed-off-by John Kacur <jkacur at gmail dot com>Index: linux-2.6.26/MAINTAINERS
===================================================================MAINTAINERS P: Latchesar Ionkov · line 158
Quoted 6 lines
MAINTAINERS +1
-1@@ -154,7 +154,7 @@ P: Latchesar Ionkov M: [email protected] L: [email protected] W: http://swik.net/v9fs -T: git kernel.org:/pub/scm/linux/kernel/ericvh/v9fs.git +T: git://git.kernel.org/pub/scm/linux/kernel/ericvh/v9fs.git S: MaintainedThis now looses information. Although it is obvious that this particular example (after conversion) is a git repository over git protocol this falls down for other forms, for example a git repository exported over http://
would appear as below:T: http://www.kernel.org/pub/scm/linux/kernel/ericvh/v9fs.git
which would be indistiguishable from a quilt series such as Greg KH's which, if I follow your scheme logically ie. convert it to the same form, would also be represented as below:
T: http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/I think your conversion makes sense in that the URL part should be exactly what one would use with the tool but you still need the tool designator:
Quoted 6 lines
T: git
git://git.kernel.org/pub/scm/linux/kernel/ericvh/v9fs.git
T: git http://www.kernel.org/pub/scm/linux/kernel/ericvh/v9fs.git
T: guilt http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/-apw
Hi Andy, I only dropped the "git" designator in cases where the URL protocol was git:// as in git://git.kernel.org
I believe there is no ambiguity there. I did not touch the designator for something like quilt where http: is ambiguous.
I could leave the git designator in but I don't think it adds any information, and it makes the line longer, and I'd rather avoid any line wrap.
Quoted 4 lines · John Kacur
Quoted 4 lines
This now looses information. Although it is obvious that this particular example (after conversion) is a git repository over git protocol this falls down for other forms, for example a git repository exported over http://
[...]
git over http really is no fun at the moment and one should really use git:// whenever possible. Where it is not possible due to tightknotted corporate firewalls, well, that's (a) their problem and
(b) they probably know already how to go around it.
If in doubt, just add a paragraph that one can exchange git://
by http://, but I would not make it that obvious to use an inferior transfer protocol.
Quoted 8 lines · Jan Engelhardt
Quoted 4 lines · John Kacur
Quoted 4 lines
This now looses information. Although it is obvious that this particular example (after conversion) is a git repository over git protocol this falls down for other forms, for example a git repository exported over http://
[...]
Quoted 9 lines
git over http really is no fun at the moment and one should really use
git://whenever possible. Where it is not possible due to tightknotted corporate firewalls, well, that's (a) their problem and
(b) they probably know already how to go around it.If in doubt, just add a paragraph that one can exchange
git://
by http://, but I would not make it that obvious to use an inferior transfer protocol.
Luckily I didn't see any use of http:// with git listed in the MAINTAINERS file.