Skip to contentSkip to conversation

net: missing lock initialization

PATCH In review Stephen Hemminger 2 participants 2 messages Jul 18, 2008 – Jul 19, 2008 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20080718161048.678a9629@extreme

#1 lore raw

PATCH 1/1 net: missing lock initialization

Looks like the xmit_lock is not being initialized in net-next

net/core/dev.c +1 -0
@@ -4175,6 +4175,7 @@ static void netdev_init_one_queue(struct
 				  struct netdev_queue *queue,
 				  void *_unused)
 {
+	spin_lock_init(&queue->_xmit_lock);
 	queue->dev = dev;
 }
 
maintainer
#2 lore raw

From: Stephen Hemminger <[email protected]>
Date: Fri, 18 Jul 2008 16:38:36 -0700

Quoted 3 lines

Looks like the xmit_lock is not being initialized in net-next

I guess you can't find the call in __netdev_init_queue_locks_one().

With your patch we'll now be initializing it twice.