um: fix a build error

PATCH NAK WANG Cong 2 participants 2 messages Jul 21, 2008 User-mode Linux (UML)

lore

Share & tools

lore

WANG Cong

author

2008-07-21 16:55 UTC #0 lore raw

PATCH 1/1 um: fix a build error

Fixed this build error:

/home/wangcong/Projects/linux-2.6/arch/um/drivers/line.c: In function ‘line_write_interrupt’:
/home/wangcong/Projects/linux-2.6/arch/um/drivers/line.c:366: error:
‘struct tty_ldisc’ has no member named ‘write_wakeup’ /home/wangcong/Projects/linux-2.6/arch/um/drivers/line.c:367: error:
‘struct tty_ldisc’ has no member named ‘write_wakeup’ make[2]: *** [arch/um/drivers/line.o] Error 1
make[1]: *** [arch/um/drivers] Error 2
make: *** [sub-make] Error 2

Sigend-off-by WANG Cong <[email protected]>

Cc [email protected]

---

arch/um/drivers/line.c +2 -2

index 5047490..c872dad 100644
@@ -363,8 +363,8 @@ static irqreturn_t line_write_interrupt(int irq, void *data)
 		return IRQ_NONE;
 
 	if (test_bit(TTY_DO_WRITE_WAKEUP, &tty->flags) &&
-	   (tty->ldisc.write_wakeup != NULL))
-		(tty->ldisc.write_wakeup)(tty);
+	   (tty->ldisc.ops->write_wakeup != NULL))
+		(tty->ldisc.ops->write_wakeup)(tty);
 
 	/*
 	 * BLOCKING mode

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Alan Cox

NAK

2008-07-21 20:53 UTC #1 lore raw

Quoted 13 lines · On Mon, 21 Jul 2008 17:54:09 +0100 WANG Cong <[email protected]> wrote:

Fixed this build error:
/home/wangcong/Projects/linux-2.6/arch/um/drivers/line.c: In function ‘line_write_interrupt’:
/home/wangcong/Projects/linux-2.6/arch/um/drivers/line.c:366: error:
‘struct tty_ldisc’ has no member named ‘write_wakeup’ /home/wangcong/Projects/linux-2.6/arch/um/drivers/line.c:367: error:
‘struct tty_ldisc’ has no member named ‘write_wakeup’ make[2]: *** [arch/um/drivers/line.o] Error 1
make[1]: *** [arch/um/drivers] Error 2
make: *** [sub-make] Error 2

Quoted 1 line

Sigend-off-by WANG Cong <[email protected]>

NAK - drivers shouldn't be poking around in tty innards in the first place then this wouldn't break. Use tty_wakeup(tty); insteaad

Alan