Skip to contentSkip to conversation

Fix util-linux dependencies

PATCH New Wade Berrier 3 participants 5 messages Jul 22, 2008

lore
Share & tools
lore
#2 lore raw

PATCH 1/1 Fix util-linux dependencies

Review

Quoted 5 lines · Wade Berrier

Patch to apply against trunk.

(quoted diff) +3 -0
+
+comment "util-linux requires a toolchain with 'Enable RPC' selected"
+	depends on !BR2_INET_RPC

what's that good for? You would be better off to use busybox anyway.

#3 lore raw

PATCH 1/1 Fix util-linux dependencies

In reply to Wade Berrier
Quoted 4 lines · Wade Berrier
Quoted 2 lines · Wade Berrier

util-linux appears to depend on RPC support.

Before making a wholesale change like this, you should probably look at the 'configure' and 'MCONFIG' files and discover exactly what RPC support is needed. If changing a config option to not include certain utilities depending on RPC is possible, then the preferred method is to add a patch for that instead of blindly enabling an option for the entire buildroot.

-Steve

#4 lore raw

PATCH 1/1 Fix util-linux dependencies

Hi,

Quoted 11 lines · On Tue, Jul 22, 2008 at 9:10 AM, <[email protected]> wrote:
Quoted 4 lines · Wade Berrier
Quoted 2 lines · Wade Berrier

util-linux appears to depend on RPC support.

Before making a wholesale change like this, you should probably look at the 'configure' and 'MCONFIG' files and discover exactly what RPC support is needed. If changing a config option to not include certain utilities depending on RPC is possible, then the preferred method is to add a patch for that instead of blindly enabling an option for the entire buildroot.

This patch came about because I noticed that util-linux was failing to build at the link stage. I looked up the symbols and it turns out they are rpc calls. (probably nfs mount related)

So, I basically copied the same mechanism that nfs-utils uses to only be availalbe if RPC is enabled.

But, as previously mentioned, since most people are probably going to use busybox in lieu of util-linux, I don't see this dependency affecting that many people (and at least it fixes the build, which is currently broken).

Otherwise, if it's really important to have util-linux without rpc I can go dig some more and resubmit.

Thanks!

Wade