Skip to contentSkip to conversation

sky2: don't stop queue on shutdown

PATCH Applied Stephen Hemminger 2 participants 2 messages Jul 23, 2008

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Stephen Hemminger

author
#0 lore raw

PATCH 1/1 sky2: don't stop queue on shutdown

It is unnecessary, to stop queue and turn off carrier in shutdown routine. With new netdev_queue this causes warnings.

Signed-off-by Stephen Hemminger <[email protected]>
drivers/net/sky2.c +0 -5
@@ -1829,9 +1829,6 @@ static int sky2_down(struct net_device *
 	if (netif_msg_ifdown(sky2))
 		printk(KERN_INFO PFX "%s: disabling interface\n", dev->name);
 
-	/* Stop more packets from being queued */
-	netif_stop_queue(dev);
-
 	/* Disable port IRQ */
 	imask = sky2_read32(hw, B0_IMSK);
 	imask &= ~portirq_msk[port];

@@ -1887,8 +1884,6 @@ static int sky2_down(struct net_device *
 
 	sky2_phy_power_down(hw, port);
 
-	netif_carrier_off(dev);
-
 	/* turn off LED's */
 	sky2_write16(hw, B0_Y2LED, LED_STAT_OFF);