Skip to contentSkip to conversation

fix the noquota mount option

PATCH In review Christoph Hellwig 2 participants 4 messages May 25, 2008 – Aug 28, 2008 XFS filesystem

lore
Share & tools
lore

Christoph Hellwig

author
#0 lore raw

PATCH 3/4 fix the noquota mount option

Noquota should clear all mount options, and not just user and group quota. Probably doesn't matter very much in real life.

Signed-off-by Christoph Hellwig <[email protected]>
fs/xfs/linux-2.6/xfs_super.c +1 -0
Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_super.c
===================================================================
@@ -337,6 +337,7 @@ xfs_parseargs(
 		} else if (!strcmp(this_char, MNTOPT_NOQUOTA)) {
 			mp->m_qflags &= ~(XFS_UQUOTA_ACCT | XFS_UQUOTA_ACTIVE |
 					  XFS_GQUOTA_ACCT | XFS_GQUOTA_ACTIVE |
+					  XFS_PQUOTA_ACCT | XFS_PQUOTA_ACTIVE |
 					  XFS_UQUOTA_ENFD | XFS_OQUOTA_ENFD);
 		} else if (!strcmp(this_char, MNTOPT_QUOTA) ||
 			   !strcmp(this_char, MNTOPT_UQUOTA) ||
author
#1 lore raw

ping?

Quoted 11 lines · Christoph Hellwig

Noquota should clear all mount options, and not just user and group quota. Probably doesn't matter very much in real life.

Signed-off-by Christoph Hellwig <[email protected]>

Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_super.c
===================================================================

fs/xfs/linux-2.6/xfs_super.c xfs_parseargs( · line 343

Quoted 7 lines
fs/xfs/linux-2.6/xfs_super.c +1 -0
@@ -337,6 +337,7 @@ xfs_parseargs(
 		} else if (!strcmp(this_char, MNTOPT_NOQUOTA)) {
 			mp->m_qflags &= ~(XFS_UQUOTA_ACCT | XFS_UQUOTA_ACTIVE |
 					  XFS_GQUOTA_ACCT | XFS_GQUOTA_ACTIVE |
+					  XFS_PQUOTA_ACCT | XFS_PQUOTA_ACTIVE |
 					  XFS_UQUOTA_ENFD | XFS_OQUOTA_ENFD);
 		} else if (!strcmp(this_char, MNTOPT_QUOTA) ||
 			   !strcmp(this_char, MNTOPT_UQUOTA) ||

---end quoted text---

author
#2 lore raw

ping^2?

Quoted 9 lines · Christoph Hellwig

ping?

Quoted 6 lines · Christoph Hellwig

Noquota should clear all mount options, and not just user and group quota. Probably doesn't matter very much in real life.

Signed-off-by Christoph Hellwig <[email protected]>
Quoted 13 lines

fs/xfs/linux-2.6/xfs_super.c xfs_parseargs( · line 343

Quoted 12 lines

Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_super.c
===================================================================

fs/xfs/linux-2.6/xfs_super.c +1 -0
@@ -337,6 +337,7 @@ xfs_parseargs(
 		} else if (!strcmp(this_char, MNTOPT_NOQUOTA)) {
 			mp->m_qflags &= ~(XFS_UQUOTA_ACCT | XFS_UQUOTA_ACTIVE |
 					  XFS_GQUOTA_ACCT | XFS_GQUOTA_ACTIVE |
+					  XFS_PQUOTA_ACCT | XFS_PQUOTA_ACTIVE |
 					  XFS_UQUOTA_ENFD | XFS_OQUOTA_ENFD);
 		} else if (!strcmp(this_char, MNTOPT_QUOTA) ||
 			   !strcmp(this_char, MNTOPT_UQUOTA) ||

---end quoted text---

---end quoted text---

#3 lore raw
In reply to Christoph Hellwig
Quoted 2 lines · Christoph Hellwig

Noquota should clear all mount options, and not just user and group quota. Probably doesn't matter very much in real life.

ACK. I noticed this discrepency reviewing the previous patch and wondered about it.

Cheers,

Dave.

Signature · 2 lines
Dave Chinner
[email protected]