Skip to contentSkip to conversation

__down_common: use signal_pending_state()

PATCH New Oleg Nesterov 1 participant 1 message Jul 24, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 __down_common: use signal_pending_state()

Change __down_common() to use signal_pending_state() instead of open coding.

The changes in kernel/semaphore.o are just artefacts, the state checks are optimized away.

kernel/semaphore.c renamed from kernel/semaphore.c~2_SPS_DOWN +1 -3
@@ -211,9 +211,7 @@ static inline int __sched __down_common(
 	waiter.up = 0;
 
 	for (;;) {
-		if (state == TASK_INTERRUPTIBLE && signal_pending(task))
-			goto interrupted;
-		if (state == TASK_KILLABLE && fatal_signal_pending(task))
+		if (signal_pending_state(state, task))
 			goto interrupted;
 		if (timeout <= 0)
 			goto timed_out;