Skip to contentSkip to conversation

blackfin_mac: unneeded assignment

PATCH Applied Stephen Hemminger 3 participants 3 messages Jul 25, 2008 – Jul 29, 2008

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Stephen Hemminger

author
#0 lore raw

PATCH 1/1 blackfin_mac: unneeded assignment

skb->dev is set by eth_type_trans already.

Signed-off-by Stephen Hemminger <[email protected]>
drivers/net/bfin_mac.c +0 -1
@@ -691,7 +691,6 @@ static void bfin_mac_rx(struct net_devic
 					 (unsigned long)skb->tail);
 
 	dev->last_rx = jiffies;
-	skb->dev = dev;
 	skb->protocol = eth_type_trans(skb, dev);
 #if defined(BFIN_MAC_CSUM_OFFLOAD)
 	skb->csum = current_rx_ptr->status.ip_payload_csum;
Acked-by on v1 1/1
#1 lore raw
Quoted 2 lines · Stephen Hemminger

skb->dev is set by eth_type_trans already.

Right, I'd love to add it into my queue.
Applied.

Acked-by Bryan Wu <[email protected]>
Quoted 18 lines
Signed-off-by Stephen Hemminger <[email protected]>
drivers/net/bfin_mac.c 2008-07-25 10:20:53.000000000 -0700 renamed from drivers/net/bfin_mac.c 2008-07-25 10:19:53.000000000 -0700 +0 -2
@@ -691,7 +691,6 @@ static void bfin_mac_rx(struct net_devic
                                        (unsigned long)skb->tail);
 
       dev->last_rx = jiffies;
-       skb->dev = dev;
       skb->protocol = eth_type_trans(skb, dev);
 #if defined(BFIN_MAC_CSUM_OFFLOAD)
       skb->csum = current_rx_ptr->status.ip_payload_csum;
--

To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html