Skip to contentSkip to conversation

module: fix build warning with !CONFIG_KALLSYMS

PATCH New Rusty Russell 1 participant 1 message Jul 25, 2008

lore
Share & tools
lore

Rusty Russell

author
#0 lore raw

PATCH 1/1 module: fix build warning with !CONFIG_KALLSYMS

Date: Thu, 24 Jul 2008 15:41:48 +0100
From: WANG Cong <[email protected]>

This patch fixed the warning:

CC kernel/module.o
/home/wangcong/Projects/linux-2.6/kernel/module.c:332: warning:
‘lookup_symbol’ defined but not used

Signed-off-by WANG Cong <[email protected]>
Signed-off-by Rusty Russell <[email protected]>
---
 kernel/module.c |   25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)
kernel/module.c +13 -12
index d8b5605..d861bd5 100644
@@ -325,18 +325,6 @@ static unsigned long find_symbol(const char *name,
 	return -ENOENT;
 }
 
-/* lookup symbol in given range of kernel_symbols */
-static const struct kernel_symbol *lookup_symbol(const char *name,
-	const struct kernel_symbol *start,
-	const struct kernel_symbol *stop)
-{
-	const struct kernel_symbol *ks = start;
-	for (; ks < stop; ks++)
-		if (strcmp(ks->name, name) == 0)
-			return ks;
-	return NULL;
-}
-
 /* Search for module by name: must hold module_mutex. */
 static struct module *find_module(const char *name)
 {

@@ -1703,6 +1691,19 @@ static void setup_modinfo(struct module *mod, Elf_Shdr *sechdrs,
 }
 
 #ifdef CONFIG_KALLSYMS
+
+/* lookup symbol in given range of kernel_symbols */
+static const struct kernel_symbol *lookup_symbol(const char *name,
+	const struct kernel_symbol *start,
+	const struct kernel_symbol *stop)
+{
+	const struct kernel_symbol *ks = start;
+	for (; ks < stop; ks++)
+		if (strcmp(ks->name, name) == 0)
+			return ks;
+	return NULL;
+}
+
 static int is_exported(const char *name, const struct module *mod)
 {
 	if (!mod && lookup_symbol(name, __start___ksymtab, __stop___ksymtab))