hptiop: add more PCI device IDs

PATCH In review HighPoint Linux Team 3 participants 5 messages Jul 25, 2008 – Jul 31, 2008

Subsystems (2)

SCSI Highpoint rocketraid 3xxx RAID driver

lore

Share & tools

lore

HighPoint Linux Team

author maintainer

2008-07-25 05:36 UTC #0 lore raw

PATCH 1/1 hptiop: add more PCI device IDs

Add PCI device ID for new adapter models.

Signed-off-by HighPoint Linux Team <[email protected]>

---

 drivers/scsi/hptiop.c |    7 +++++++
 1 file changed, 7 insertions(+)

drivers/scsi/hptiop.c +7 -0

diff -purN linux-2.6.26-rc8/drivers/scsi/hptiop.c linux-2.6.26-rc8-hpt/drivers/scsi/hptiop.c
@@ -1249,6 +1249,13 @@ static struct pci_device_id hptiop_id_ta
 	{ PCI_VDEVICE(TTI, 0x3522), (kernel_ulong_t)&hptiop_itl_ops },
 	{ PCI_VDEVICE(TTI, 0x3410), (kernel_ulong_t)&hptiop_itl_ops },
 	{ PCI_VDEVICE(TTI, 0x3540), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x3530), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x3560), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4322), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4210), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4211), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4310), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4311), (kernel_ulong_t)&hptiop_itl_ops },
 	{ PCI_VDEVICE(TTI, 0x3120), (kernel_ulong_t)&hptiop_mv_ops },
 	{ PCI_VDEVICE(TTI, 0x3122), (kernel_ulong_t)&hptiop_mv_ops },
 	{ PCI_VDEVICE(TTI, 0x3020), (kernel_ulong_t)&hptiop_mv_ops },

Andrew Morton

2008-07-29 07:34 UTC #1 lore raw

Quoted 15 lines · On Fri, 25 Jul 2008 13:29:24 +0800 HighPoint Linux Team…

Add PCI device ID for new adapter models.
Signed-off-by HighPoint Linux Team <[email protected]>
---
 drivers/scsi/hptiop.c |    7 +++++++
 1 file changed, 7 insertions(+)
diff -purN linux-2.6.26-rc8/drivers/scsi/hptiop.c linux-2.6.26-rc8-hpt/drivers/scsi/hptiop.c
drivers/scsi/hptiop.c +0 -0
@@ -1249,6 +1249,13 @@ static struct pci_device_id hptiop_id_ta
 	{ PCI_VDEVICE(TTI, 0x3522), (kernel_ulong_t)&hptiop_itl_ops },
 	{ PCI_VDEVICE(TTI, 0x3410), (kernel_ulong_t)&hptiop_itl_ops },
 	{ PCI_VDEVICE(TTI, 0x3540), (kernel_ulong_t)&hptiop_itl_ops },

drivers/scsi/hptiop.c static struct pci_device_id hptiop_id_ta · line 1261

Quoted 10 lines

drivers/scsi/hptiop.c +7 -0

+	{ PCI_VDEVICE(TTI, 0x3530), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x3560), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4322), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4210), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4211), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4310), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4311), (kernel_ulong_t)&hptiop_itl_ops },
 	{ PCI_VDEVICE(TTI, 0x3120), (kernel_ulong_t)&hptiop_mv_ops },
 	{ PCI_VDEVICE(TTI, 0x3122), (kernel_ulong_t)&hptiop_mv_ops },
 	{ PCI_VDEVICE(TTI, 0x3020), (kernel_ulong_t)&hptiop_mv_ops },

I assume that this patch makes new devices work, whereas they do not work correctly in unpatched kernels, yes?

If so, then this patch should be backported into 2.6.25.x and 2.6.26.x. Users of these kernels would presumably like their devices to work.

HighPoint Linux Team

author maintainer

2008-07-29 07:59 UTC #2 lore raw

Quoted 33 lines · Andrew Morton

Quoted 16 lines · On Fri, 25 Jul 2008 13:29:24 +0800 HighPoint Linux Team…
Add PCI device ID for new adapter models.
Signed-off-by HighPoint Linux Team <[email protected]>
---
 drivers/scsi/hptiop.c |    7 +++++++
 1 file changed, 7 insertions(+)
diff -purN linux-2.6.26-rc8/drivers/scsi/hptiop.c linux-2.6.26-rc8-hpt/drivers/scsi/hptiop.c
drivers/scsi/hptiop.c +0 -0
@@ -1249,6 +1249,13 @@ static struct pci_device_id hptiop_id_ta
 	{ PCI_VDEVICE(TTI, 0x3522), (kernel_ulong_t)&hptiop_itl_ops },
 	{ PCI_VDEVICE(TTI, 0x3410), (kernel_ulong_t)&hptiop_itl_ops },
 	{ PCI_VDEVICE(TTI, 0x3540), (kernel_ulong_t)&hptiop_itl_ops },
drivers/scsi/hptiop.c static struct pci_device_id hptiop_id_ta · line 1261
Quoted 10 lines
drivers/scsi/hptiop.c +7 -0
+	{ PCI_VDEVICE(TTI, 0x3530), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x3560), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4322), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4210), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4211), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4310), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4311), (kernel_ulong_t)&hptiop_itl_ops },
 	{ PCI_VDEVICE(TTI, 0x3120), (kernel_ulong_t)&hptiop_mv_ops },
 	{ PCI_VDEVICE(TTI, 0x3122), (kernel_ulong_t)&hptiop_mv_ops },
 	{ PCI_VDEVICE(TTI, 0x3020), (kernel_ulong_t)&hptiop_mv_ops },
I assume that this patch makes new devices work, whereas they do not work correctly in unpatched kernels, yes?

Quoted 3 lines

If so, then this patch should be backported into 2.6.25.x and 2.6.26.x. Users of these kernels would presumably like their devices to work.

Yes, this patch should also be backported to 2.6.25.x and 2.6.26.x.

Greg KH

2008-07-31 19:41 UTC #3 lore raw

Quoted 34 lines · HighPoint Linux Team

Quoted 33 lines · Andrew Morton
Quoted 16 lines · On Fri, 25 Jul 2008 13:29:24 +0800 HighPoint Linux Team…
Add PCI device ID for new adapter models.
Signed-off-by HighPoint Linux Team <[email protected]>
---
 drivers/scsi/hptiop.c |    7 +++++++
 1 file changed, 7 insertions(+)
diff -purN linux-2.6.26-rc8/drivers/scsi/hptiop.c linux-2.6.26-rc8-hpt/drivers/scsi/hptiop.c
drivers/scsi/hptiop.c +0 -0
@@ -1249,6 +1249,13 @@ static struct pci_device_id hptiop_id_ta
 	{ PCI_VDEVICE(TTI, 0x3522), (kernel_ulong_t)&hptiop_itl_ops },
 	{ PCI_VDEVICE(TTI, 0x3410), (kernel_ulong_t)&hptiop_itl_ops },
 	{ PCI_VDEVICE(TTI, 0x3540), (kernel_ulong_t)&hptiop_itl_ops },
drivers/scsi/hptiop.c static struct pci_device_id hptiop_id_ta · line 1261
Quoted 10 lines
drivers/scsi/hptiop.c +7 -0
+	{ PCI_VDEVICE(TTI, 0x3530), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x3560), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4322), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4210), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4211), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4310), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4311), (kernel_ulong_t)&hptiop_itl_ops },
 	{ PCI_VDEVICE(TTI, 0x3120), (kernel_ulong_t)&hptiop_mv_ops },
 	{ PCI_VDEVICE(TTI, 0x3122), (kernel_ulong_t)&hptiop_mv_ops },
 	{ PCI_VDEVICE(TTI, 0x3020), (kernel_ulong_t)&hptiop_mv_ops },
I assume that this patch makes new devices work, whereas they do not work correctly in unpatched kernels, yes?

Quoted 4 lines

Quoted 3 lines
If so, then this patch should be backported into 2.6.25.x and 2.6.26.x. Users of these kernels would presumably like their devices to work.
Yes, this patch should also be backported to 2.6.25.x and 2.6.26.x.

What is the git commit id for this patch in Linus's tree? I couldn't find it when I last looked.

thanks,

greg k-h

Andrew Morton

2008-07-31 20:07 UTC #4 lore raw

Quoted 35 lines · On Thu, 31 Jul 2008 09:50:50 -0700 Greg KH <[email protected]> wrote:

Quoted 34 lines · HighPoint Linux Team
Quoted 33 lines · Andrew Morton
Quoted 16 lines · On Fri, 25 Jul 2008 13:29:24 +0800 HighPoint Linux Team…
Add PCI device ID for new adapter models.
Signed-off-by HighPoint Linux Team <[email protected]>
---
 drivers/scsi/hptiop.c |    7 +++++++
 1 file changed, 7 insertions(+)
diff -purN linux-2.6.26-rc8/drivers/scsi/hptiop.c linux-2.6.26-rc8-hpt/drivers/scsi/hptiop.c
drivers/scsi/hptiop.c +0 -0
@@ -1249,6 +1249,13 @@ static struct pci_device_id hptiop_id_ta
 	{ PCI_VDEVICE(TTI, 0x3522), (kernel_ulong_t)&hptiop_itl_ops },
 	{ PCI_VDEVICE(TTI, 0x3410), (kernel_ulong_t)&hptiop_itl_ops },
 	{ PCI_VDEVICE(TTI, 0x3540), (kernel_ulong_t)&hptiop_itl_ops },
drivers/scsi/hptiop.c static struct pci_device_id hptiop_id_ta · line 1261
Quoted 10 lines
drivers/scsi/hptiop.c +7 -0
+	{ PCI_VDEVICE(TTI, 0x3530), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x3560), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4322), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4210), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4211), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4310), (kernel_ulong_t)&hptiop_itl_ops },
+	{ PCI_VDEVICE(TTI, 0x4311), (kernel_ulong_t)&hptiop_itl_ops },
 	{ PCI_VDEVICE(TTI, 0x3120), (kernel_ulong_t)&hptiop_mv_ops },
 	{ PCI_VDEVICE(TTI, 0x3122), (kernel_ulong_t)&hptiop_mv_ops },
 	{ PCI_VDEVICE(TTI, 0x3020), (kernel_ulong_t)&hptiop_mv_ops },
I assume that this patch makes new devices work, whereas they do not work correctly in unpatched kernels, yes?

Quoted 8 lines

Quoted 4 lines
Quoted 3 lines
If so, then this patch should be backported into 2.6.25.x and 2.6.26.x. Users of these kernels would presumably like their devices to work.
Yes, this patch should also be backported to 2.6.25.x and 2.6.26.x.
What is the git commit id for this patch in Linus's tree? I couldn't find it when I last looked.

It's presently mastered in James's git-scsi-rc-fixes tree, so I'd expect it to turn up in mainline soonish.