optimize xfs_ichgtime
PATCH 2/3 optimize xfs_ichgtime
Port a little optmization from file_update_time to xfs_ichgtime, and only update the timestamp and mark the inode dirty if the timestamp actually changes in the timer tick resultion supported by the running kernel.
fs/xfs/linux-2.6/xfs_iops.c +15 -7
@@ -97,17 +97,23 @@ xfs_ichgtime( {struct inode *inode =VFS_I (ip);timespec_t tv; +int sync_it =0 ; -nanotime (&tv); -if (flags &XFS_ICHGTIME_MOD ) { + tv =current_fs_time (inode->i_sb); + +if ((flags &XFS_ICHGTIME_MOD ) && + !timespec_equal (&inode->i_mtime, &tv)) { inode->i_mtime = tv; ip->i_d.di_mtime.t_sec = (__int32_t )tv.tv_sec; ip->i_d.di_mtime.t_nsec = (__int32_t )tv.tv_nsec; + sync_it =1 ; } -if (flags &XFS_ICHGTIME_CHG ) { +if ((flags &XFS_ICHGTIME_CHG ) && + !timespec_equal (&inode->i_ctime, &tv)) { inode->i_ctime = tv; ip->i_d.di_ctime.t_sec = (__int32_t )tv.tv_sec; ip->i_d.di_ctime.t_nsec = (__int32_t )tv.tv_nsec; + sync_it =1 ; }/*
@@ -119,10 +125,12 @@ xfs_ichgtime(* ensure that the compiler does not reorder the update * of i_update_core above the timestamp updates above. */ -SYNCHRONIZE (); - ip->i_update_core =1 ; -if (!(inode->i_state &I_NEW )) -mark_inode_dirty_sync (inode); +if (sync_it) { +SYNCHRONIZE (); + ip->i_update_core =1 ; +if (!(inode->i_state &I_NEW )) +mark_inode_dirty_sync (inode); + } }/*
Quoted 4 lines · Christoph Hellwig
Port a little optmization from
file_update_timetoxfs_ichgtime, and only update the timestamp and mark the inode dirty if the timestamp actually changes in the timer tick resultion supported by the running kernel.
Looks ok.
Cheers,
Dave.
Signature · 2 lines
Dave Chinner [email protected]
Quoted 7 lines · Dave Chinner
Quoted 4 lines · Christoph Hellwig
Port a little optmization from
file_update_timetoxfs_ichgtime, and only update the timestamp and mark the inode dirty if the timestamp actually changes in the timer tick resultion supported by the running kernel.Looks ok.
Updated version that removes the I_NEW check (I could do this in patch 1, but doing it here causes less churn)
fs/xfs/linux-2.6/xfs_iops.c +13 -6
@@ -97,17 +97,23 @@ xfs_ichgtime( {struct inode *inode =VFS_I (ip);timespec_t tv; +int sync_it =0 ; -nanotime (&tv); -if (flags &XFS_ICHGTIME_MOD ) { + tv =current_fs_time (inode->i_sb); + +if ((flags &XFS_ICHGTIME_MOD ) && + !timespec_equal (&inode->i_mtime, &tv)) { inode->i_mtime = tv; ip->i_d.di_mtime.t_sec = (__int32_t )tv.tv_sec; ip->i_d.di_mtime.t_nsec = (__int32_t )tv.tv_nsec; + sync_it =1 ; } -if (flags &XFS_ICHGTIME_CHG ) { +if ((flags &XFS_ICHGTIME_CHG ) && + !timespec_equal (&inode->i_ctime, &tv)) { inode->i_ctime = tv; ip->i_d.di_ctime.t_sec = (__int32_t )tv.tv_sec; ip->i_d.di_ctime.t_nsec = (__int32_t )tv.tv_nsec; + sync_it =1 ; }/*
@@ -119,10 +125,11 @@ xfs_ichgtime(* ensure that the compiler does not reorder the update * of i_update_core above the timestamp updates above. */ -SYNCHRONIZE (); - ip->i_update_core =1 ; -if (!(inode->i_state &I_NEW )) +if (sync_it) { +SYNCHRONIZE (); + ip->i_update_core =1 ;mark_inode_dirty_sync (inode); + } }/*