remove <linux/hdreg.h>
PATCH 4/4 remove <linux/hdreg.h>
It has no in-kernel users now and can be removed.
--- include/linux/Kbuild | 1 include/linux/hdreg.h | 454 -------------------------------------------------- 2 files changed, 455 deletions(-)
include/linux/Kbuild +0 -1
@@ -213,7 +213,6 @@ unifdef-y += hayesesp.h unifdef-y += hdio_ioctls.h unifdef-y += hdlcdrv.h unifdef-y += hdlc.h -unifdef-y += hdreg.h unifdef-y += hid.h unifdef-y += hiddev.h unifdef-y += hidraw.h
include/linux/hdreg.h deleted +0 -454
454 lines not on this page · raw message
Quoted 1 line · Bartlomiej Zolnierkiewicz
It has no in-kernel users now and can be removed.
But beeing an exported header it has userspace users. Plese keep it and just leave the ioctl defintions as need by userspace in it instead of renaming that part to hdio_ioctls.h.
Quoted 6 lines · Christoph Hellwig
Quoted 1 line · Bartlomiej Zolnierkiewicz
It has no in-kernel users now and can be removed.
But beeing an exported header it has userspace users. Plese keep it and just leave the ioctl defintions as need by userspace in it instead of renaming that part to
hdio_ioctls.h.
Agreed w.r.t. to keeping it (the last patch was more of rfc than intended to be commited, sorry that I didn't mark it as such) but what's wrong with moving ioctl definitions to hdio_ioctls.h so we have clean separation of obsoleted userspace-only stuff & userspace/kernel stuff?
[ The hdio_ioctls.h include is also exported to userspace and included
by hdreg.h internally (patch #1) so userspace should be unaffected. ]
Thanks,
Bart
Quoted 4 lines · Bartlomiej Zolnierkiewicz
Quoted 3 lines · Christoph Hellwig
Quoted 1 line · Bartlomiej Zolnierkiewicz
It has no in-kernel users now and can be removed.
Quoted 8 lines
Quoted 3 lines
But beeing an exported header it has userspace users. Plese keep it and just leave the ioctl defintions as need by userspace in it instead of renaming that part to
hdio_ioctls.h.Agreed w.r.t. to keeping it (the last patch was more of rfc than intended to be commited, sorry that I didn't mark it as such) but what's wrong with moving ioctl definitions to
hdio_ioctls.hso we have clean separation of obsoleted userspace-only stuff & userspace/kernel stuff?
Well, if there was anything kernel-related left in hdreg.h I would agree to split it, although I'd prefer to move the kernel part out.
But given that you kill all the kernel only bits anyway, just leave the user interface in hdreg.h even if it's slightly misnamed.
Quoted 14 lines · Christoph Hellwig
Quoted 4 lines · Bartlomiej Zolnierkiewicz
Quoted 3 lines · Christoph Hellwig
Quoted 1 line · Bartlomiej Zolnierkiewicz
It has no in-kernel users now and can be removed.
Quoted 8 lines
Quoted 3 lines
But beeing an exported header it has userspace users. Plese keep it and just leave the ioctl defintions as need by userspace in it instead of renaming that part to
hdio_ioctls.h.Agreed w.r.t. to keeping it (the last patch was more of rfc than intended to be commited, sorry that I didn't mark it as such) but what's wrong with moving ioctl definitions to
hdio_ioctls.hso we have clean separation of obsoleted userspace-only stuff & userspace/kernel stuff?
Quoted 5 lines
Well, if there was anything kernel-related left in
hdreg.hI would agree to split it, although I'd prefer to move the kernel part out.But given that you kill all the kernel only bits anyway, just leave the user interface in
hdreg.heven if it's slightly misnamed.
Yep, no need to move it around. I reworked patchset accordingly.
Thanks,
Bart