Skip to contentSkip to conversation

Remove stray <6> in BogoMIPS printk

PATCH In review Rabin Vincent 3 participants 3 messages Jul 27, 2008 – Jul 28, 2008

lore
Share & tools
lore

Rabin Vincent

author
#0 lore raw

PATCH 1/1 Remove stray <6> in BogoMIPS printk

Remove the extra KERN_INFO which causes this:
Calibrating delay loop... <6>179.40 BogoMIPS (lpj=897024)

                          ^^^
Signed-off-by Rabin Vincent <[email protected]>
---
 init/calibrate.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
init/calibrate.c +3 -3
index 7963e3f..51c5cec 100644
@@ -170,7 +170,7 @@ void __cpuinit calibrate_delay(void)
 				loops_per_jiffy &= ~loopbit;
 		}
 	}
-	printk(KERN_INFO "%lu.%02lu BogoMIPS (lpj=%lu)\n",
-			loops_per_jiffy/(500000/HZ),
-			(loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
+	printk("%lu.%02lu BogoMIPS (lpj=%lu)\n",
+		loops_per_jiffy/(500000/HZ),
+		(loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
 }
Signature · 1 line
1.5.6.3
#1 lore raw

Review

Quoted 9 lines · Rabin Vincent

Remove the extra KERN_INFO which causes this:
Calibrating delay loop... <6>179.40 BogoMIPS (lpj=897024)

(quoted diff) +3 -3
-	printk(KERN_INFO "%lu.%02lu BogoMIPS (lpj=%lu)\n",
-			loops_per_jiffy/(500000/HZ),
-			(loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
+	printk("%lu.%02lu BogoMIPS (lpj=%lu)\n",
+		loops_per_jiffy/(500000/HZ),
+		(loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
 }

How about just using KERN_CONT and leaving the whitespace for a patch that does the entire file?

init/calibrate.c +1 -1
index 7963e3f..51c5cec 100644
@@ -170,7 +170,7 @@ void __cpuinit calibrate_delay(void)
 				loops_per_jiffy &= ~loopbit;
 		}
 	}
-	printk(KERN_INFO "%lu.%02lu BogoMIPS (lpj=%lu)\n",
+	printk(KERN_CONT "%lu.%02lu BogoMIPS (lpj=%lu)\n",
 			loops_per_jiffy/(500000/HZ),
 			(loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
 }
#2 lore raw
Quoted 19 lines · Joe Perches

Review

Quoted 9 lines · Rabin Vincent

Remove the extra KERN_INFO which causes this:
Calibrating delay loop... <6>179.40 BogoMIPS (lpj=897024)

(quoted diff) +3 -3
-	printk(KERN_INFO "%lu.%02lu BogoMIPS (lpj=%lu)\n",
-			loops_per_jiffy/(500000/HZ),
-			(loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
+	printk("%lu.%02lu BogoMIPS (lpj=%lu)\n",
+		loops_per_jiffy/(500000/HZ),
+		(loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
 }

How about just using KERN_CONT and leaving the whitespace for a patch that does the entire file?

init/calibrate.c +0 -0
index 7963e3f..51c5cec 100644

init/calibrate.c void __cpuinit calibrate_delay(void) · line 175

Quoted 7 lines
init/calibrate.c +1 -1
@@ -170,7 +170,7 @@ void __cpuinit calibrate_delay(void)
 				loops_per_jiffy &= ~loopbit;
 		}
 	}
-	printk(KERN_INFO "%lu.%02lu BogoMIPS (lpj=%lu)\n",
+	printk(KERN_CONT "%lu.%02lu BogoMIPS (lpj=%lu)\n",
 			loops_per_jiffy/(500000/HZ),
 			(loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);

ok - i've applied the patch below. Please send the full-file cleanup as a separate patch if anyone is interested in doing it.

Ingo

------------>

Quoted 1 line

From d7ba11d01cfedf63b50391fbe4a05274b6992b43 Mon Sep 17 00:00:00 2001

From: Joe Perches <[email protected]>
Date: Sun, 27 Jul 2008 12:02:04 -0700
Subject: [PATCH] x86: remove stray <6> in BogoMIPS printk

Rabin Vincent noticed that there's a stray <6> in BogoMIPS printk:

init/calibrate.c

Quoted 9 lines

Remove the extra KERN_INFO which causes this:
Calibrating delay loop... <6>179.40 BogoMIPS (lpj=897024)

init/calibrate.c +3 -3
-	printk(KERN_INFO "%lu.%02lu BogoMIPS (lpj=%lu)\n",
-			loops_per_jiffy/(500000/HZ),
-			(loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
+	printk("%lu.%02lu BogoMIPS (lpj=%lu)\n",
+		loops_per_jiffy/(500000/HZ),
+		(loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
 }

How about just using KERN_CONT and leaving the whitespace for a patch that does the entire file?

Reported-by Rabin Vincent <[email protected]>
---
 init/calibrate.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
init/calibrate.c +1 -1
index 7963e3f..a379c90 100644
@@ -170,7 +170,7 @@ void __cpuinit calibrate_delay(void)
 				loops_per_jiffy &= ~loopbit;
 		}
 	}
-	printk(KERN_INFO "%lu.%02lu BogoMIPS (lpj=%lu)\n",
+	printk(KERN_CONT "%lu.%02lu BogoMIPS (lpj=%lu)\n",
 			loops_per_jiffy/(500000/HZ),
 			(loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
 }