ide: ide_dev_is_sata() -> ata_id_is_sata()
PATCH 2/3 ide: ide_dev_is_sata() -> ata_id_is_sata()
* Use optimized ATA version check from Sergei in ata_id_is_sata().
* ide_dev_is_sata() -> ata_id_is_sata()
Cc Jeff Garzik <[email protected]>
Cc Sergei Shtylyov <[email protected]>
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
--- drivers/ide/ide-iops.c | 2 +- drivers/ide/pci/hpt366.c | 4 ++-- include/linux/ata.h | 10 +++++++++- include/linux/ide.h | 13 ------------- 4 files changed, 12 insertions(+), 17 deletions(-)
drivers/ide/ide-iops.c +1 -1
@@ -630,7 +630,7 @@ u8 eighty_ninty_three (ide_drive_t *drivprintk (KERN_DEBUG "%s: skipping word 93 validity check\n" , drive->name); -if (ide_dev_is_sata (id) && !ivb) +if (ata_id_is_sata (id) && !ivb)return 1 ;if (hwif->cbl !=ATA_CBL_PATA80 && !ivb)
drivers/ide/pci/hpt366.c +2 -2
@@ -648,7 +648,7 @@ static u8 hpt3xx_udma_filter(ide_drive_tcase HPT372A :case HPT372N :case HPT374 : -if (ide_dev_is_sata (drive->id)) +if (ata_id_is_sata (drive->id)) mask &= ~0x0e ;/* Fall thru */ default :
@@ -670,7 +670,7 @@ static u8 hpt3xx_mdma_filter(ide_drive_tcase HPT372A :case HPT372N :case HPT374 : -if (ide_dev_is_sata (drive->id)) +if (ata_id_is_sata (drive->id))return 0x00 ;/* Fall thru */ default :
include/linux/ata.h +9 -1
@@ -644,7 +644,15 @@ static inline unsigned int ata_id_major_static inline int ata_id_is_sata (const u16 *id) { -return ata_id_major_version (id) >=5 && id[ATA_ID_HW_CONFIG ] ==0 ; +/* +* See if word 93 is 0 AND drive is at least ATA-5 compatible +* verifying that word 80 by casting it to a signed type -- +* this trick allows us to filter out the reserved values of +* 0x0000 and 0xffff along with the earlier ATA revisions... +*/ +if (id[ATA_ID_HW_CONFIG ] ==0 && (short )id[ATA_ID_MAJOR_VER ] >=0x0020 ) +return 1 ; +return 0 ; }static inline int ata_id_has_tpm (const u16 *id)
include/linux/ide.h +0 -13
@@ -1391,19 +1391,6 @@ const char *ide_xfer_verbose(u8 mode);extern void ide_toggle_bounce (ide_drive_t *drive,int on);extern int ide_set_xfer_rate (ide_drive_t *drive,u8 rate); -static inline int ide_dev_is_sata (u16 *id) -{ -/* -* See if word 93 is 0 AND drive is at least ATA-5 compatible -* verifying that word 80 by casting it to a signed type -- -* this trick allows us to filter out the reserved values of -* 0x0000 and 0xffff along with the earlier ATA revisions... -*/ -if (id[ATA_ID_HW_CONFIG ] ==0 && (short )id[ATA_ID_MAJOR_VER ] >=0x0020 ) -return 1 ; -return 0 ; -} -u64 ide_get_lba_addr (struct ide_taskfile *,int );u8 ide_dump_status (ide_drive_t *,const char *,u8 );