sparc64: build failure at sys_sparc32.c
Hi
I am testing build using randconfig.
arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_chown16':arch/sparc64/kernel/sys_sparc32.c:63: error: implicit declaration of function 'low2highuid' arch/sparc64/kernel/sys_sparc32.c:63: error: implicit declaration of function 'low2highgid'arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_getresuid16':arch/sparc64/kernel/sys_sparc32.c:106: error: implicit declaration of function 'high2lowuid'arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_getresgid16':arch/sparc64/kernel/sys_sparc32.c:123: error: implicit declaration of function 'high2lowgid'
These functions are defined in linux/highuid.h only if CONFIG_UID16 is enabled.
From: Alexander Beregalov <[email protected]>
Date: Tue, 29 Jul 2008 10:59:14 +0400
Quoted 14 lines
I am testing build using randconfig.
arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_chown16':arch/sparc64/kernel/sys_sparc32.c:63: error: implicit declaration of function 'low2highuid'arch/sparc64/kernel/sys_sparc32.c:63: error: implicit declaration of function 'low2highgid'arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_getresuid16':arch/sparc64/kernel/sys_sparc32.c:106: error: implicit declaration of function 'high2lowuid'arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_getresgid16':arch/sparc64/kernel/sys_sparc32.c:123: error: implicit declaration of function 'high2lowgid'
Quoted 1 line
These functions are defined in
linux/highuid.honly ifCONFIG_UID16is enabled.
Thanks, what kernel version is this?
2008/7/29 David Miller <[email protected]>:
Quoted 17 lines
From: Alexander Beregalov <[email protected]>
Date: Tue, 29 Jul 2008 10:59:14 +0400Quoted 14 lines
I am testing build using randconfig.
arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_chown16':arch/sparc64/kernel/sys_sparc32.c:63: error: implicit declaration of function 'low2highuid'arch/sparc64/kernel/sys_sparc32.c:63: error: implicit declaration of function 'low2highgid'arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_getresuid16':arch/sparc64/kernel/sys_sparc32.c:106: error: implicit declaration of function 'high2lowuid'arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_getresgid16':arch/sparc64/kernel/sys_sparc32.c:123: error: implicit declaration of function 'high2lowgid'
Quoted 3 lines
Quoted 1 line
These functions are defined in
linux/highuid.honly ifCONFIG_UID16is enabled.Thanks, what kernel version is this?
It is current by default - .27-rc1. These files were not touched for a long time.
But, OK, I will mention the kernel version every time.
From: "Alexander Beregalov" <[email protected]>
Date: Tue, 29 Jul 2008 12:38:38 +0400
Quoted 18 lines
2008/7/29 David Miller <[email protected]>:
Quoted 17 lines
From: Alexander Beregalov <[email protected]>
Date: Tue, 29 Jul 2008 10:59:14 +0400Quoted 14 lines
I am testing build using randconfig.
arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_chown16':arch/sparc64/kernel/sys_sparc32.c:63: error: implicit declaration of function 'low2highuid'arch/sparc64/kernel/sys_sparc32.c:63: error: implicit declaration of function 'low2highgid'arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_getresuid16':arch/sparc64/kernel/sys_sparc32.c:106: error: implicit declaration of function 'high2lowuid'arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_getresgid16':arch/sparc64/kernel/sys_sparc32.c:123: error: implicit declaration of function 'high2lowgid'
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
These functions are defined in
linux/highuid.honly ifCONFIG_UID16is enabled.Thanks, what kernel version is this?
It is current by default - .27-rc1. These files were not touched for a long time.
But, OK, I will mention the kernel version every time.
This is basically setup to fail.
If SPARC64 && COMPAT this option should always be set. But it's left as an option the user can still disable in this case down in init/Kconfig.
This can be triggered very likely on other platforms too.
Can someone take a look at fixing this properly? Make it something that is selected on necessary platforms, for example.
Quoted 31 lines · David Miller
From: "Alexander Beregalov" <[email protected]>
Date: Tue, 29 Jul 2008 12:38:38 +0400Quoted 18 lines
2008/7/29 David Miller <[email protected]>:
Quoted 17 lines
From: Alexander Beregalov <[email protected]>
Date: Tue, 29 Jul 2008 10:59:14 +0400Quoted 14 lines
I am testing build using randconfig.
arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_chown16':arch/sparc64/kernel/sys_sparc32.c:63: error: implicit declaration of function 'low2highuid'arch/sparc64/kernel/sys_sparc32.c:63: error: implicit declaration of function 'low2highgid'arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_getresuid16':arch/sparc64/kernel/sys_sparc32.c:106: error: implicit declaration of function 'high2lowuid'arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_getresgid16':arch/sparc64/kernel/sys_sparc32.c:123: error: implicit declaration of function 'high2lowgid'Quoted 7 lines
Quoted 3 lines
Quoted 1 line
These functions are defined in
linux/highuid.honly ifCONFIG_UID16is enabled.Thanks, what kernel version is this?
It is current by default - .27-rc1. These files were not touched for a long time.
But, OK, I will mention the kernel version every time.This is basically setup to fail.
Quoted 8 lines
If SPARC64 && COMPAT this option should always be set. But it's left as an option the user can still disable in this case down in init/Kconfig.
This can be triggered very likely on other platforms too.
Can someone take a look at fixing this properly? Make it something that is selected on necessary platforms, for example.
The only platforms that do their own stuff instead of using the functions from kernel/uid16.c are sparc64 and s390.
Is there any reason why sparc64 has it's own functions?
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedFrom: Adrian Bunk <[email protected]>
Date: Mon, 4 Aug 2008 17:05:32 +0300
Quoted 4 lines
The only platforms that do their own stuff instead of using the functions from
kernel/uid16.care sparc64 and s390.Is there any reason why sparc64 has it's own functions?
Thanks for pointing it out, I'll take advantage of those helper routines.