Skip to contentSkip to conversation

omfs: fix sparse signedness warnings

PATCH In review Harvey Harrison 2 participants 2 messages Jul 29, 2008 Omfs filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 omfs: fix sparse signedness warnings

fs/omfs/bitmap.c:74:18: warning: incorrect type in argument 2 (different signedness)
fs/omfs/bitmap.c:74:18: expected unsigned long volatile *addr
fs/omfs/bitmap.c:74:18: got long *<noident>
fs/omfs/bitmap.c:77:20: warning: incorrect type in argument 2 (different signedness)
fs/omfs/bitmap.c:77:20: expected unsigned long volatile *addr
fs/omfs/bitmap.c:77:20: got long *<noident>
fs/omfs/bitmap.c:112:17: warning: incorrect type in argument 2 (different signedness)
fs/omfs/bitmap.c:112:17: expected unsigned long volatile *addr
fs/omfs/bitmap.c:112:17: got long *<noident>

---
Sorry, missed these in my other sparse warning fixes, feel free to fold it with the other one.

 fs/omfs/bitmap.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
fs/omfs/bitmap.c +3 -3
index dc75f22..697663b 100644
@@ -71,10 +71,10 @@ static int set_run(struct super_block *sb, int map,
 		}
 		if (set) {
 			set_bit(bit, sbi->s_imap[map]);
-			set_bit(bit, (long *) bh->b_data);
+			set_bit(bit, (unsigned long *)bh->b_data);
 		} else {
 			clear_bit(bit, sbi->s_imap[map]);
-			clear_bit(bit, (long *) bh->b_data);
+			clear_bit(bit, (unsigned long *)bh->b_data);
 		}
 	}
 	mark_buffer_dirty(bh);
@@ -109,7 +109,7 @@ int omfs_allocate_block(struct super_block *sb, u64 block)
 		if (!bh)
 			goto out;
 
-		set_bit(bit, (long *) bh->b_data);
+		set_bit(bit, (unsigned long *)bh->b_data);
 		mark_buffer_dirty(bh);
 		brelse(bh);
 	}
Signature · 1 line
1.6.0.rc1.154.ge3fc
maintainer
#1 lore raw
Quoted 2 lines · Harvey Harrison

Sorry, missed these in my other sparse warning fixes, feel free to fold it with the other one.

Looks good, thanks.

Signature · 1 line
Bob Copeland %% www.bobcopeland.com