Skip to contentSkip to conversation

IA64: only call up() in salinfo_work_to_do() if down_trylock() was successful

PATCH In review Simon Horman 3 participants 5 messages Jul 29, 2008 – Jul 30, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 IA64: only call up() in salinfo_work_to_do() if down_trylock() was successful

Aesthetic issues aside is it safe to call up() if down_trylock() failed?

arch/ia64/kernel/salinfo.c: In function `salinfo_work_to_do':
arch/ia64/kernel/salinfo.c:195: warning: ignoring return value of `down_trylock'

Index: linux-2.6/arch/ia64/kernel/salinfo.c
=================================--- linux-2.6.orig/arch/ia64/kernel/salinfo.c 2008-07-29 19:06:33.000000000 +1000
+++ linux-2.6/arch/ia64/kernel/salinfo.c 2008-07-29 19:40:02.000000000 +1000
@@ -192,8 +192,8 @@ struct salinfo_platform_oemdata_parms {
static void
salinfo_work_to_do(struct salinfo_data *data)
{
- down_trylock(&data->mutex);
- up(&data->mutex);
+ if (down_trylock(&data->mutex) = 0)
+ up(&data->mutex);
}

static void

#1 lore raw
Quoted 20 lines · Simon Horman (on Tue, 29 Jul 2008 19:47:20 +1000) wrote:

Aesthetic issues aside is it safe to call up() if down_trylock() failed?

arch/ia64/kernel/salinfo.c: In function `salinfo_work_to_do':
arch/ia64/kernel/salinfo.c:195: warning: ignoring return value of `down_trylock'

Index: linux-2.6/arch/ia64/kernel/salinfo.c
=================================>--- linux-2.6.orig/arch/ia64/kernel/salinfo.c 2008-07-29 19:06:33.000000000 +1000
+++ linux-2.6/arch/ia64/kernel/salinfo.c 2008-07-29 19:40:02.000000000 +1000

(quoted diff) +0 -0
@@ -192,8 +192,8 @@ struct salinfo_platform_oemdata_parms {

static void
salinfo_work_to_do(struct salinfo_data *data)
{

(quoted diff) +2 -2
-	down_trylock(&data->mutex);
-	up(&data->mutex);
+	if (down_trylock(&data->mutex) = 0)
+		up(&data->mutex);

}

Quoted 1 line

static void

NAK. The whole point of this function is to set the mutex to the up state, irrespective of whether it was already down or not. Tracking the state of data->mutex in all the possible contexts is just too fragile, especially since it can be modified from NMI context. salinfo_work_to_do() ensures that the mtuex ends in the up state.

To remove the warning, just stick '(void)' in front of down_trylock().

#2 lore raw
Quoted 29 lines · Keith Owens
Quoted 20 lines · Simon Horman (on Tue, 29 Jul 2008 19:47:20 +1000) wrote:

Aesthetic issues aside is it safe to call up() if down_trylock() failed?

arch/ia64/kernel/salinfo.c: In function `salinfo_work_to_do':
arch/ia64/kernel/salinfo.c:195: warning: ignoring return value of `down_trylock'

Index: linux-2.6/arch/ia64/kernel/salinfo.c
=================================> >--- linux-2.6.orig/arch/ia64/kernel/salinfo.c 2008-07-29 19:06:33.000000000 +1000
+++ linux-2.6/arch/ia64/kernel/salinfo.c 2008-07-29 19:40:02.000000000 +1000

(quoted diff) +0 -0
@@ -192,8 +192,8 @@ struct salinfo_platform_oemdata_parms {

static void
salinfo_work_to_do(struct salinfo_data *data)
{

(quoted diff) +2 -2
-	down_trylock(&data->mutex);
-	up(&data->mutex);
+	if (down_trylock(&data->mutex) = 0)
+		up(&data->mutex);

}

Quoted 1 line

static void

NAK. The whole point of this function is to set the mutex to the up state, irrespective of whether it was already down or not. Tracking the state of data->mutex in all the possible contexts is just too fragile, especially since it can be modified from NMI context. salinfo_work_to_do() ensures that the mtuex ends in the up state.

Quoted 1 line

To remove the warning, just stick '(void)' in front of down_trylock().

Thanks, will do.

Signature · 1 line
Horms
#3 lore raw
Quoted 22 lines · On Tue, 29 Jul 2008 23:07:45 +1000 Simon Horman <[email protected]> wrote:
Quoted 21 lines · Keith Owens
Quoted 20 lines · Simon Horman (on Tue, 29 Jul 2008 19:47:20 +1000) wrote:

Aesthetic issues aside is it safe to call up() if down_trylock() failed?

arch/ia64/kernel/salinfo.c: In function `salinfo_work_to_do':
arch/ia64/kernel/salinfo.c:195: warning: ignoring return value of `down_trylock'

Index: linux-2.6/arch/ia64/kernel/salinfo.c
=================================> > >--- linux-2.6.orig/arch/ia64/kernel/salinfo.c 2008-07-29 19:06:33.000000000 +1000
+++ linux-2.6/arch/ia64/kernel/salinfo.c 2008-07-29 19:40:02.000000000 +1000

(quoted diff) +0 -0
@@ -192,8 +192,8 @@ struct salinfo_platform_oemdata_parms {

static void
salinfo_work_to_do(struct salinfo_data *data)
{

(quoted diff) +2 -2
-	down_trylock(&data->mutex);
-	up(&data->mutex);
+	if (down_trylock(&data->mutex) = 0)
+		up(&data->mutex);

}

Quoted 7 lines
Quoted 7 lines
Quoted 1 line

static void

NAK. The whole point of this function is to set the mutex to the up state, irrespective of whether it was already down or not. Tracking the state of data->mutex in all the possible contexts is just too fragile, especially since it can be modified from NMI context. salinfo_work_to_do() ensures that the mtuex ends in the up state.

boggle. I daren't look.

Quoted 4 lines
Quoted 1 line

To remove the warning, just stick '(void)' in front of down_trylock().

Thanks, will do.

For gawd's sake add a comment there too.

#4 lore raw
Quoted 32 lines · Andrew Morton (on Wed, 30 Jul 2008 02:43:29 -0700) wrote:
Quoted 22 lines · On Tue, 29 Jul 2008 23:07:45 +1000 Simon Horman <[email protected]> wrote:
Quoted 21 lines · Keith Owens
Quoted 20 lines · Simon Horman (on Tue, 29 Jul 2008 19:47:20 +1000) wrote:

Aesthetic issues aside is it safe to call up() if down_trylock() failed?

arch/ia64/kernel/salinfo.c: In function `salinfo_work_to_do':
arch/ia64/kernel/salinfo.c:195: warning: ignoring return value of `down_trylock'

Index: linux-2.6/arch/ia64/kernel/salinfo.c
=================================>> > >--- linux-2.6.orig/arch/ia64/kernel/salinfo.c 2008-07-29 19:06:33.000000000 +1000
+++ linux-2.6/arch/ia64/kernel/salinfo.c 2008-07-29 19:40:02.000000000 +1000

(quoted diff) +0 -0
@@ -192,8 +192,8 @@ struct salinfo_platform_oemdata_parms {

static void
salinfo_work_to_do(struct salinfo_data *data)
{

(quoted diff) +2 -2
-	down_trylock(&data->mutex);
-	up(&data->mutex);
+	if (down_trylock(&data->mutex) = 0)
+		up(&data->mutex);

}

Quoted 7 lines
Quoted 7 lines
Quoted 1 line

static void

NAK. The whole point of this function is to set the mutex to the up state, irrespective of whether it was already down or not. Tracking the state of data->mutex in all the possible contexts is just too fragile, especially since it can be modified from NMI context. salinfo_work_to_do() ensures that the mtuex ends in the up state.

Quoted 8 lines

boggle. I daren't look.

Quoted 4 lines
Quoted 1 line

To remove the warning, just stick '(void)' in front of down_trylock().

Thanks, will do.

For gawd's sake add a comment there too.

You mean like the comment that is already in there?

/* Kick the mutex that tells user space that there is work to do. Instead of
* trying to track the state of the mutex across multiple cpus, in user
* context, interrupt context, non-maskable interrupt context and hotplug cpu,
* it is far easier just to grab the mutex if it is free then release it. *
* This routine must be called with data_saved_lock held, to make the down/up
* operation atomic.
*/