Skip to contentSkip to conversation

ia64: export cpu_core_map

PATCH In review Ben Hutchings 2 participants 3 messages Jul 29, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ia64: export cpu_core_map

cpu_core_map is referenced by the topology_core_siblings() macro, which is now used by the sfc driver. Matthew Wilcox reported that the driver failed to link because that symbol is not exported.

---
I have not yet tested this as we have limited ia64 kit here. Matthew, please could you check that this builds at least?

Ben.
---

arch/ia64/kernel/smpboot.c +1 -0
index 03f1a99..6cb0927 100644
@@ -138,6 +138,7 @@ cpumask_t cpu_possible_map = CPU_MASK_NONE;
 EXPORT_SYMBOL(cpu_possible_map);
 
 cpumask_t cpu_core_map[NR_CPUS] __cacheline_aligned;
+EXPORT_SYMBOL(cpu_core_map);
 DEFINE_PER_CPU_SHARED_ALIGNED(cpumask_t, cpu_sibling_map);
 EXPORT_PER_CPU_SYMBOL(cpu_sibling_map);
 
Signature · 2 lines
Ben Hutchings, Senior Software Engineer, Solarflare Communications
 ot speaking for my employer; that's the marketing department's job.
#1 lore raw
Quoted 8 lines · Ben Hutchings

cpu_core_map is referenced by the topology_core_siblings() macro, which is now used by the sfc driver. Matthew Wilcox reported that the driver failed to link because that symbol is not exported.

---
I have not yet tested this as we have limited ia64 kit here. Matthew, please could you check that this builds at least?

I had tested it last night when I CC'd you on the patch I sent to the ia64 mailing list.

I have booted it on a bunch of different sn2 ia64 boxes, but none with your sfc network adapter (whatever that is). It does, however, build ;)

Thanks,
Robin

#2 lore raw
In reply to Ben Hutchings
Quoted 5 lines · Robin Holt
Quoted 4 lines · Ben Hutchings

cpu_core_map is referenced by the topology_core_siblings() macro, which is now used by the sfc driver. Matthew Wilcox reported that the driver failed to link because that symbol is not exported.

Quoted 7 lines
Quoted 4 lines

---
I have not yet tested this as we have limited ia64 kit here. Matthew, please could you check that this builds at least?

I had tested it last night when I CC'd you on the patch I sent to the ia64 mailing list.

Sorry, not sure how I missed that. Now I look over the archive, I see Matthew also posted the same patch but didn't cc me.

Quoted 2 lines

I have booted it on a bunch of different sn2 ia64 boxes, but none with your sfc network adapter (whatever that is).

It's a PCI Express 10G Ethernet controller, but that's not important right now.

Quoted 1 line

It does, however, build ;)

Ben.

Signature · 2 lines
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.