OMAP: MENELAUS: Improvements on menelaus
cover OMAP: MENELAUS: Improvements on menelaus
Hi Tony and folks,
This patch series proposes some improvements on menelaus code.
Basically it makes menelaus to use macros instead of some magic constant numbers, making menelaus code more legible. The menelaus header was moved to include/linux/i2c and register map (including the macros created) were moved to include/linux/i2c/menelaus.h
Tested with MMC on N800 and looks fine.
BR,
Carlos.
PS: I would like to thanks Felipe Balbi for hints and orientation.
Signature · 7 lines
Carlos Eduardo Aguiar Software Engineer Mobile Linux Software Nokia Institute of Technology - INdT Phone: +55 92 2126-1079 Mobile: +55 92 8127-1797 E-mail: [email protected]
Quoted 10 lines · Carlos Aguiar
Hi Tony and folks,
This patch series proposes some improvements on menelaus code.
Basically it makes menelaus to use macros instead of some magic constant numbers, making menelaus code more legible. The menelaus header was moved to
include/linux/i2cand register map (including the macros created) were moved toinclude/linux/i2c/menelaus.hTested with MMC on N800 and looks fine.
They look quite ok. How about syncing l-o menelaus with mainline via lm-sensors mailing list and discuss all these there as well ??
It'd be only one extra patch before this one to make everything in sync.
Signature · 1 line
balbi
Hi,
2008/7/29 Felipe Balbi <[email protected]>:
Quoted 10 lines · Carlos Aguiar
Quoted 9 lines
Hi Tony and folks,
This patch series proposes some improvements on menelaus code.
Basically it makes menelaus to use macros instead of some magic constant numbers, making menelaus code more legible. The menelaus header was moved to
include/linux/i2cand register map (including the macros created) were moved toinclude/linux/i2c/menelaus.h
Quoted 4 lines
Quoted 1 line
Tested with MMC on N800 and looks fine.
They look quite ok. How about syncing l-o menelaus with mainline via lm-sensors mailing list and discuss all these there as well ??
How about renaming it to twl92230c before submitting upstream? As far as I can tell the name menelaus appears only in linux and makes it hard to associate with the real hardware. Does someone know why was it renamed that way?
Regards
Quoted 4 lines
How about renaming it to twl92230c before submitting upstream? As far as I can tell the name menelaus appears only in linux and makes it hard to associate with the real hardware. Does someone know why was it renamed that way?
The name was just an internal project name for that IO companion chip. It has the name Menelaus probably before it had a number designation.
A number does seem more understandable. Though some of these chips live under a few different numbers.
Regards,
Richard W.
Quoted 6 lines · Richard
Quoted 4 lines
How about renaming it to twl92230c before submitting upstream? As far as I can tell the name menelaus appears only in linux and makes it hard to associate with the real hardware. Does someone know why was it renamed that way?
A number does seem more understandable. Though some of these chips live under a few different numbers.
it does seem more understandable, but now that it has been used for so long I guess it would be nasty to change right now. Almost every one here knows that menelaus is the companion chip for omap2 hw. Personally, I never recall the correct number designation for menelaus.
I mean, I don't really have any problems in renaming the whole driver from menelaus to twl92230c.c but I can't help asking myself why. If everybody thinks it's a better choice, then why not ;-)
Signature · 1 line
balbi
2008/7/29 Felipe Balbi <[email protected]>:
Quoted 6 lines · Richard
Quoted 4 lines
Quoted 4 lines
How about renaming it to twl92230c before submitting upstream? As far as I can tell the name menelaus appears only in linux and makes it hard to associate with the real hardware. Does someone know why was it renamed that way?
Quoted 6 lines
Quoted 1 line
A number does seem more understandable. Though some of these chips live under a few different numbers.
it does seem more understandable, but now that it has been used for so long I guess it would be nasty to change right now. Almost every one here knows that menelaus is the companion chip for omap2 hw. Personally, I never recall the correct number designation for menelaus.
Well, menelaus is a friendly name now that I know what it is but it was difficult to find its datasheet without knowing the public name used by the manufacturer, it seemed like a nokia's own chip. Also iirc if you open the device you will only see the TWLxxx name on the chip.
I see TWLxxx is now mentioned in the Kconfig so I won't insist.
Cheers
Quoted 14 lines
2008/7/29 Felipe Balbi <[email protected]>:
Quoted 6 lines · Richard
Quoted 4 lines
Quoted 4 lines
How about renaming it to twl92230c before submitting upstream? As far as I can tell the name menelaus appears only in linux and makes it hard to associate with the real hardware. Does someone know why was it renamed that way?
Quoted 6 lines
Quoted 1 line
A number does seem more understandable. Though some of these chips live under a few different numbers.
it does seem more understandable, but now that it has been used for so long I guess it would be nasty to change right now. Almost every one here knows that menelaus is the companion chip for omap2 hw. Personally, I never recall the correct number designation for menelaus.
Quoted 8 lines
Well, menelaus is a friendly name now that I know what it is but it was difficult to find its datasheet without knowing the public name used by the manufacturer, it seemed like a nokia's own chip. Also iirc if you open the device you will only see the TWLxxx name on the chip.
I see TWLxxx is now mentioned in the
Kconfigso I won't insist.Cheers
I think it'll be hard for a newbie to figure out what this menelaus is. Google won't help either, (unless one really thinks there is a connection between Linux and Greek Mythology ;) ).
I second renaming the file to TWL92230. Mentioning this in Kconfig is simply not enough.
My 375 million ZWD,
Anand
Quoted 3 lines · Anand
I think it'll be hard for a newbie to figure out what this menelaus is. Google won't help either, (unless one really thinks there is a connection between Linux and Greek Mythology ;) ).
eheh, That's true :-)
Quoted 2 lines
I second renaming the file to TWL92230. Mentioning this in
Kconfigis simply not enough.
Hmm... are there any other devices which would work with the same driver ?
Signature · 1 line
balbi
Quoted 21 lines · Gadiyar, Anand
Quoted 21 lines
2008/7/29 Felipe Balbi <[email protected]>:
Quoted 6 lines · Richard
Quoted 4 lines
Quoted 4 lines
How about renaming it to twl92230c before submitting upstream? As far as I can tell the name menelaus appears only in linux and makes it hard to associate with the real hardware. Does someone know why was it renamed that way?
Quoted 6 lines
Quoted 1 line
A number does seem more understandable. Though some of these chips live under a few different numbers.
it does seem more understandable, but now that it has been used for so long I guess it would be nasty to change right now. Almost every one here knows that menelaus is the companion chip for omap2 hw. Personally, I never recall the correct number designation for menelaus.
Well, menelaus is a friendly name now that I know what it is but it was difficult to find its datasheet without knowing the public name used by the manufacturer, it seemed like a nokia's own chip. Also iirc if you open the device you will only see the TWLxxx name on the chip.
I see TWLxxx is now mentioned in the
Kconfigso I won't insist.
Quoted 8 lines
Quoted 1 line
Cheers
I think it'll be hard for a newbie to figure out what this menelaus is. Google won't help either, (unless one really thinks there is a connection between Linux and Greek Mythology ;) ).
I second renaming the file to TWL92230. Mentioning this in
Kconfigis simply not enough.
Yeah, let's rename it as it's not in mainline yet. I'll apply this series, then the next set of patches can take care of the renaming.
Tony
Felipe Balbi
Acked-by Alessandro ZummoQuoted 2 lines · Tony Lindgren
Yeah, let's rename it as it's not in mainline yet. I'll apply this series, then the next set of patches can take care of the renaming.
It it in mainline actually, check your drivers/i2c/chips and it was added by you :-p
commit 0c4a59fed41bdd4c30ce0999a87f30a812f29ee2
Author: Tony Lindgren <[email protected]> Date: Tue Jul 17 04:06:09 2007 -0700
OMAP: add TI TWL92330/Menelaus Power Management chip driver
Add Texas Instruments TWL92330/Menelaus Power Management chip driver. This includes voltage regulators, Dual slot memory card tranceivers and real-time clock(RTC).
The support for RTC is integrated with this driver only; it is not separate module. Passes 'rtctest' on OMAP H4 EVM, other than lack of "periodic" (1/N second) IRQs. System wakeup alarms (from suspend-to-RAM) work too.
The battery keeps the RTC active over power off, so once you set clock (rdate/ntpdate/etc, then "hwclock -w") then RTC_HCTOSYS at boot time will behave as expected.
Maybe someone sent that patch for you ?
Signature · 1 line
balbi
Quoted 33 lines · Felipe Balbi
Quoted 2 lines · Tony Lindgren
Yeah, let's rename it as it's not in mainline yet. I'll apply this series, then the next set of patches can take care of the renaming.
It it in mainline actually, check your
drivers/i2c/chipsand it was added by you :-pcommit
0c4a59fed41bdd4c30ce0999a87f30a812f29ee2Author: Tony Lindgren <[email protected]> Date: Tue Jul 17 04:06:09 2007 -0700OMAP: add TI TWL92330/Menelaus Power Management chip driver
Add Texas Instruments TWL92330/Menelaus Power Management chip driver. This includes voltage regulators, Dual slot memory card tranceivers and real-time clock(RTC).
The support for RTC is integrated with this driver only; it is not separate module. Passes 'rtctest' on OMAP H4 EVM, other than lack of "periodic" (1/N second) IRQs. System wakeup alarms (from suspend-to-RAM) work too.
The battery keeps the RTC active over power off, so once you set clock (rdate/ntpdate/etc, then "hwclock -w") then
RTC_HCTOSYSat boot time will behave as expected.Cc "Jean Delvare" <[email protected]>Cc "Tony Lindgren" <[email protected]>Cc "David Brownell" <[email protected]>Signed-off-by Trilok Soni <[email protected]>Acked-by Alessandro Zummo <[email protected]>Signed-off-by Andrew Morton <[email protected]>Signed-off-by Linus Torvalds <[email protected]>
Quoted 1 line
Maybe someone sent that patch for you ?
Oops :) I guess I'm over a year behind current developments after my vacation!
Anyways, sounds like people want to rename it. Carlos, can you send your patches to the i2c list for integration?
Tony
Quoted 39 lines · ext Tony Lindgren
Quoted 34 lines · Felipe Balbi
Quoted 3 lines · Tony Lindgren
Yeah, let's rename it as it's not in mainline yet. I'll apply this series, then the next set of patches can take care of the renaming.
It it in mainline actually, check your
drivers/i2c/chipsand it was added by you :-pcommit
0c4a59fed41bdd4c30ce0999a87f30a812f29ee2Author: Tony Lindgren <[email protected]> Date: Tue Jul 17 04:06:09 2007 -0700OMAP: add TI TWL92330/Menelaus Power Management chip driver
Add Texas Instruments TWL92330/Menelaus Power Management chip driver. This includes voltage regulators, Dual slot memory card tranceivers and real-time clock(RTC).
The support for RTC is integrated with this driver only; it is not separate module. Passes 'rtctest' on OMAP H4 EVM, other than lack of "periodic" (1/N second) IRQs. System wakeup alarms (from suspend-to-RAM) work too.
The battery keeps the RTC active over power off, so once you set clock (rdate/ntpdate/etc, then "hwclock -w") then
RTC_HCTOSYSat boot time will behave as expected.Cc "Jean Delvare" <[email protected]>Cc "Tony Lindgren" <[email protected]>Cc "David Brownell" <[email protected]>Signed-off-by Trilok Soni <[email protected]>Acked-by Alessandro Zummo <[email protected]>Signed-off-by Andrew Morton <[email protected]>Signed-off-by Linus Torvalds <[email protected]>Quoted 2 lines
Maybe someone sent that patch for you ?
Quoted 9 lines
Oops :) I guess I'm over a year behind current developments after my vacation!
Anyways, sounds like people want to rename it. Carlos, can you send your patches to the i2c list for integration?
Tony
Hi Tony and folks,
So, I'm going to preparing and send a new series by today to i2c list for integration so that such series:
- Align the code from l-o tree to mainline tree.
- Apply the series of four patches I just sent to l-o.
- And than a last one to rename files to twl92230, as folks agreeded.
BR,
Carlos.
Signature · 7 lines
Carlos Eduardo Aguiar Software Engineer Mobile Linux Software Nokia Institute of Technology - INdT Phone: +55 92 2126-1079 Mobile: +55 92 8127-1797 E-mail: [email protected]
Quoted 48 lines · Carlos Aguiar
Quoted 38 lines · ext Tony Lindgren
Quoted 33 lines · Felipe Balbi
Quoted 3 lines · Tony Lindgren
Yeah, let's rename it as it's not in mainline yet. I'll apply this series, then the next set of patches can take care of the renaming.
It it in mainline actually, check your
drivers/i2c/chipsand it was added by you :-pcommit
0c4a59fed41bdd4c30ce0999a87f30a812f29ee2Author: Tony Lindgren <[email protected]> Date: Tue Jul 17 04:06:09 2007 -0700OMAP: add TI TWL92330/Menelaus Power Management chip driver
Add Texas Instruments TWL92330/Menelaus Power Management chip
driver. This
includes voltage regulators, Dual slot memory card tranceivers and real-time clock(RTC).
The support for RTC is integrated with this driver only; it
is not separate
module. Passes 'rtctest' on OMAP H4 EVM, other than lack of "periodic" (1/N second) IRQs. System wakeup alarms (from suspend-to-RAM) work too.
The battery keeps the RTC active over power off, so once you
set clock
(rdate/ntpdate/etc, then "hwclock -w") thenRTC_HCTOSYSat boot time will behave as expected.Cc "Jean Delvare" <[email protected]>Cc "Tony Lindgren" <[email protected]>Cc "David Brownell" <[email protected]>Signed-off-by Trilok Soni <[email protected]>Acked-by Alessandro Zummo <[email protected]>Signed-off-by Andrew Morton <[email protected]>Signed-off-by Linus Torvalds <[email protected]>Quoted 2 lines
Maybe someone sent that patch for you ?
Quoted 9 lines
Oops :) I guess I'm over a year behind current developments after my vacation!
Anyways, sounds like people want to rename it. Carlos, can you send your patches to the i2c list for integration?
Tony
Quoted 8 lines
Hi Tony and folks,
So, I'm going to preparing and send a new series by today to i2c list for integration so that such series:
- Align the code from l-o tree to mainline tree.
- Apply the series of four patches I just sent to l-o.
- And than a last one to rename files to twl92230, as folks agreeded.
Sounds good to me!
Tony
Hi Felipe,
Quoted 6 lines · Felipe Balbi
Quoted 2 lines · Tony Lindgren
Yeah, let's rename it as it's not in mainline yet. I'll apply this series, then the next set of patches can take care of the renaming.
It it in mainline actually, check your
drivers/i2c/chipsand it was added by you :-p
Nope. It was added by me through I2C mailing list. :)
Quoted 1 line
Signature · 3 lines
---Trilok Soni http://triloksoni.wordpress.com http://www.linkedin.com/in/triloksoni