x86: apic - use SET_APIC_DEST_FIELD macro

PATCH New Cyrill Gorcunov 1 participant 1 message Aug 1, 2008 x86

lore

Share & tools

lore

Cyrill Gorcunov

author

2008-08-01 14:56 UTC #0 lore raw

PATCH 1/1 x86: apic - use SET_APIC_DEST_FIELD macro

Use predefined macro instead of hardcoded bit shifting

Signed-off-by Cyrill Gorcunov <[email protected]>

---

I'm on really sloooow gprs connection so fetching replies not that often and if there is some inconvenience with this patch i'll not answer fast, sorry.

arch/x86/kernel/apic_64.c +1 -1

Index: linux-2.6.git/arch/x86/kernel/apic_64.c
===================================================================
@@ -150,7 +150,7 @@ u32 safe_xapic_wait_icr_idle(void)
 
 void xapic_icr_write(u32 low, u32 id)
 {
-	apic_write(APIC_ICR2, id << 24);
+	apic_write(APIC_ICR2, SET_APIC_DEST_FIELD(id));
 	apic_write(APIC_ICR, low);
 }