Skip to contentSkip to conversation

omfs: fix warning

PATCH In review Alexander Beregalov 2 participants 2 messages Aug 2, 2008 Omfs filesystem

lore
Share & tools
lore

Alexander Beregalov

author
#0 lore raw

PATCH 1/1 omfs: fix warning

From: Alexander Beregalov <[email protected]>

omfs: fix warnings

fs/omfs/inode.c:495: warning: format '%llx' expects type 'long long
unsigned int', but argument 2 has type 'u64'
fs/omfs/inode.c:495: warning: format '%llx' expects type 'long
long unsigned int', but argument 3 has type '__be64'

Signed-off-by Alexander Beregalov <[email protected]>
Cc Bob Copeland <[email protected]>

---

 fs/omfs/inode.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
fs/omfs/inode.c +2 -1
index d865f55..a95fe59 100644
@@ -492,7 +492,8 @@ static int omfs_fill_super(struct super_block *sb, void *data, int silent)
 	if (sbi->s_num_blocks != be64_to_cpu(omfs_rb->r_num_blocks)) {
 		printk(KERN_ERR "omfs: block count discrepancy between "
 			"super and root blocks (%llx, %llx)\n",
-			sbi->s_num_blocks, be64_to_cpu(omfs_rb->r_num_blocks));
+			(unsigned long long)sbi->s_num_blocks,
+			(unsigned long long)be64_to_cpu(omfs_rb->r_num_blocks));
 		goto out_brelse_bh2;
 	}
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Alexander Beregalov

From: Alexander Beregalov <[email protected]>

omfs: fix warnings

fs/omfs/inode.c:495: warning: format '%llx' expects type 'long long
unsigned int', but argument 2 has type 'u64'
fs/omfs/inode.c:495: warning: format '%llx' expects type 'long
long unsigned int', but argument 3 has type '__be64'

Signed-off-by Alexander Beregalov <[email protected]>
Cc Bob Copeland <[email protected]>

Thanks!

Acked-by Bob Copeland <[email protected]>

(And I'm downloading cross compilers as I type this.)

Andrew, should I continue to send omfs patches through you, or do I need to publish a git repo?

Quoted 5 lines
fs/omfs/inode.c +2 -1
 			"super and root blocks (%llx, %llx)\n",
-			sbi->s_num_blocks, be64_to_cpu(omfs_rb->r_num_blocks));
+			(unsigned long long)sbi->s_num_blocks,
+			(unsigned long long)be64_to_cpu(omfs_rb->r_num_blocks));
 		goto out_brelse_bh2;
Signature · 1 line
Bob Copeland %% www.bobcopeland.com