drivers/mtd/mtdsuper.c: fix build error
PATCH 1/1 drivers/mtd/mtdsuper.c: fix build error
From: Alexander Beregalov <[email protected]>
drivers/mtd/mtdsuper.c: fix build error
drivers/mtd/mtdsuper.c:184: error: implicit declaration of
function 'lookup_bdev'drivers/mtd/mtdsuper.c:197: error: implicit declaration of
function 'bdput'
Introduced by commit d5686b444ff3f72808d2b3fbd58672a86cdf38e7
---
drivers/mtd/mtdsuper.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/mtd/mtdsuper.c +1 -0
@@ -13,6 +13,7 @@#include <linux/mtd/super.h> #include <linux/namei.h> #include <linux/ctype.h> +#include <linux/fs.h> /* * compare superblocks to see if they're equivalent
Quoted 8 lines · Alexander Beregalov
From: Alexander Beregalov <[email protected]>
drivers/mtd/mtdsuper.c: fix build error
drivers/mtd/mtdsuper.c:184: error: implicit declaration of
function 'lookup_bdev'drivers/mtd/mtdsuper.c:197: error: implicit declaration of
function 'bdput'
It already gets fs.h indirectly through linux/mtd/super.h, so while your patch might be correct it cannot fix a compile error.
If that's with CONFIG_BLOCK=n then it's
http://bugzilla.kernel.org/show_bug.cgi?id=11225
Otherwise please send your .config .
Quoted 15 lines
Introduced by commit
d5686b444ff3f72808d2b3fbd58672a86cdf38e7Signed-off-by Alexander Beregalov <[email protected]>Cc Al Viro <[email protected]>---
drivers/mtd/mtdsuper.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)drivers/mtd/mtdsuper.c +0
-0
drivers/mtd/mtdsuper.c line 19
Quoted 7 lines
drivers/mtd/mtdsuper.c +1
-0@@ -13,6 +13,7 @@#include <linux/mtd/super.h> #include <linux/namei.h> #include <linux/ctype.h> +#include <linux/fs.h> /* * compare superblocks to see if they're equivalent
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed2008/8/3 Adrian Bunk <[email protected]>:
Quoted 11 lines · Alexander Beregalov
Quoted 8 lines
From: Alexander Beregalov <[email protected]>
drivers/mtd/mtdsuper.c: fix build error
drivers/mtd/mtdsuper.c:184: error: implicit declaration of
function 'lookup_bdev'drivers/mtd/mtdsuper.c:197: error: implicit declaration of
function 'bdput'
Quoted 7 lines
It already gets
fs.hindirectly throughlinux/mtd/super.h, so while your patch might be correct it cannot fix a compile error.If that's with
CONFIG_BLOCK=nthen it's
http://bugzilla.kernel.org/show_bug.cgi?id=11225Otherwise please send your .config .
I do not have this config, I collect log from builds with randconfig and try to fix problems.
It seems it is the same bug.
Quoted 15 lines · Alexander Beregalov
2008/8/3 Adrian Bunk <[email protected]>:
Quoted 14 lines · Alexander Beregalov
Quoted 8 lines
From: Alexander Beregalov <[email protected]>
drivers/mtd/mtdsuper.c: fix build error
drivers/mtd/mtdsuper.c:184: error: implicit declaration of
function 'lookup_bdev'drivers/mtd/mtdsuper.c:197: error: implicit declaration of
function 'bdput'It already gets
fs.hindirectly throughlinux/mtd/super.h, so while your patch might be correct it cannot fix a compile error.
Quoted 8 lines
Quoted 4 lines
If that's with
CONFIG_BLOCK=nthen it's
http://bugzilla.kernel.org/show_bug.cgi?id=11225Otherwise please send your .config .
I do not have this config, I collect log from builds with randconfig and try to fix problems.
...
You must store the config of the failed builds somewhere, since otherwise (like in this case) you cannot verify whether a patch actually fixes a problem.
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed2008/8/3 Adrian Bunk <[email protected]>:
Quoted 3 lines
You must store the config of the failed builds somewhere, since otherwise (like in this case) you cannot verify whether a patch actually fixes a problem.
Right, I have changed this script.
2008/8/3 Alexander Beregalov <[email protected]>:
Quoted 6 lines
2008/8/3 Adrian Bunk <[email protected]>:
Quoted 3 lines
You must store the config of the failed builds somewhere, since otherwise (like in this case) you cannot verify whether a patch actually fixes a problem.
Right, I have changed this script.
Yes, it is CONFIG_BLOCK=n.
Thanks.