Skip to contentSkip to conversation

drivers/video/console/promcon.c: fix build error

PATCH In review Alexander Beregalov 2 participants 3 messages Aug 2, 2008 – Aug 3, 2008 TTY layer and serial drivers

lore
Share & tools
lore

Alexander Beregalov

author
#0 lore raw

PATCH 1/1 drivers/video/console/promcon.c: fix build error

From: Alexander Beregalov <[email protected]>

drivers/video/console/promcon.c: fix build error

drivers/video/console/promcon.c:158: error: implicit declaration of function 'con_protect_unimap'

Introduced by commit 4744b43431e8613f920c5cba88346756f53c5165

Signed-off-by Alexander Beregalov <[email protected]>
Cc David Woodhouse <[email protected]>
Cc Tim Bird <[email protected]>

---

 include/linux/vt_kern.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/linux/vt_kern.h +1 -0
index 8c8119f..1c78d56 100644
@@ -86,6 +86,7 @@ int con_copy_unimap(struct vc_data *dst_vc, struct vc_data *src_vc);
 #define con_copy_unimap(d, s) (0)
 #define con_get_unimap(vc, ct, uct, list) (-EINVAL)
 #define con_free_unimap(vc) do { ; } while (0)
+#define con_protect_unimap(vc, rdonly) do { ; } while (0)
 
 #define vc_translate(vc, c) (c)
 #endif
#1 lore raw
Quoted 8 lines · Alexander Beregalov

From: Alexander Beregalov <[email protected]>

drivers/video/console/promcon.c: fix build error

drivers/video/console/promcon.c:158: error: implicit declaration of function 'con_protect_unimap'

Introduced by commit 4744b43431e8613f920c5cba88346756f53c5165

Commit a29ccf6f823a84d89e1c7aaaf221cf7282022024, surely?

And in fact it looks like we could remove those parts of promcon.c completely if !CONFIG_CONSOLE_TRANSLATIONS. But your patch is certainly correct, and I've applied it to my 'random-2.6.git' tree which I've already asked Linus to pull.

Signature · 2 lines
David Woodhouse                            Open Source Technology Centre
[email protected]                              Intel Corporation
author
#2 lore raw

2008/8/3 David Woodhouse <[email protected]>:

Quoted 11 lines · Alexander Beregalov
Quoted 8 lines

From: Alexander Beregalov <[email protected]>

drivers/video/console/promcon.c: fix build error

drivers/video/console/promcon.c:158: error: implicit declaration of function 'con_protect_unimap'

Introduced by commit 4744b43431e8613f920c5cba88346756f53c5165

Commit a29ccf6f823a84d89e1c7aaaf221cf7282022024, surely?

Yes, my mistake.

Quoted 5 lines

And in fact it looks like we could remove those parts of promcon.c completely if !CONFIG_CONSOLE_TRANSLATIONS. But your patch is certainly correct, and I've applied it to my 'random-2.6.git' tree which I've already asked Linus to pull.

Thanks.