Skip to contentSkip to conversation

oops in rt_cache_invalidate (2.6.27-rc1-2b12a4c)

PATCH Applied Marcin Slusarz 4 participants 9 messages Aug 3, 2008

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Marcin Slusarz

author
#0 lore raw
[   21.035097] Adding 1020112k swap on /dev/sda2.  Priority:-1 extents:1 across:1020112k
[   22.340292] BUG: unable to handle kernel NULL pointer dereference at 00000000000002c0
[   22.341002] IP: [<ffffffff80442a7e>] rt_cache_invalidate+0x25/0x32
[   22.341002] PGD 3dc7c067 PUD 3d198067 PMD 0
[   22.341002] Oops: 0002 [1] PREEMPT
[   22.341002] CPU 0
[   22.341002] Modules linked in: usbhid uhci_hcd tuner tea5767 tda8290 tuner_xc2028 xc5000 tda9887 tuner_simple tuner_types mt20xx tea5761 tda9875 ehci_hcd usbcore bttv ir_common compat_ioctl32 videodev v4l1_compat i2c_algo_bit snd_via82xx snd_ac97_codec v4l2_common ac97_bus snd_pcm videobuf_dma_sg snd_timer snd_page_alloc i2c_viapro videobuf_core btcx_risc snd_mpu401_uart snd_rawmidi tveeprom snd_seq_device snd soundcore
[   22.341002] Pid: 2248, comm: sysctl Not tainted 2.6.27-rc1-00507-g75aecb1 #261
[   22.341002] RIP: 0010:[<ffffffff80442a7e>]  [<ffffffff80442a7e>] rt_cache_invalidate+0x25/0x32
[   22.341002] RSP: 0018:ffff88003cd6de08  EFLAGS: 00010202
[   22.341002] RAX: 0000000000000052 RBX: 0000000000000000 RCX: 0000000000000000
[   22.341002] RDX: ffff88003cd6dda8 RSI: ffff88003cd6dda9 RDI: ffff88003cd6ddb2
[   22.341002] RBP: ffff88003cd6de28 R08: 0000000000000000 R09: ffff88003cd6dbb8
[   22.341002] R10: 00000000a94180f7 R11: ffff88003cd6dc0c R12: 0000000000000001
[   22.341002] R13: ffffffff8062a90c R14: 0000000000000000 R15: 0000000000000040
[   22.341002] FS:  00007f0674ee66f0(0000) GS:ffffffff80625200(0000) knlGS:0000000000000000
[   22.341002] CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[   22.341002] CR2: 00000000000002c0 CR3: 000000003d1a3000 CR4: 00000000000006e0
[   22.341002] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[   22.341002] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[   22.341002] Process sysctl (pid: 2248, threadinfo ffff88003cd6c000, task ffff88003d0dd900)
[   22.341002] Stack:  ffff88003cd6de38 ffffffff80233c93 51ff88003cd6df48 0000000000000000
[   22.341002]  ffff88003cd6de58 ffffffff80442c4c ffffffff80620740 0000000000000001
[   22.341002]  ffffffff8062a90c 0000000000000000 ffff88003cd6de98 ffffffff8046a63b
[   22.341002] Call Trace:
[   22.341002]  [<ffffffff80233c93>] ? do_proc_dointvec+0x3d/0x3f
[   22.341002]  [<ffffffff80442c4c>] rt_cache_flush+0x17/0xe2
[   22.341002]  [<ffffffff8046a63b>] ipv4_doint_and_flush+0x42/0x52
[   22.341002]  [<ffffffff802d263b>] proc_sys_call_handler+0x96/0xbb
[   22.341002]  [<ffffffff802d2674>] proc_sys_write+0x14/0x16
[   22.341002]  [<ffffffff8028f8fd>] vfs_write+0xb3/0x13c
[   22.341002]  [<ffffffff8028fdd0>] sys_write+0x4c/0x74
[   22.341002]  [<ffffffff8020b3fb>] system_call_fastpath+0x16/0x1b
[   22.341002]
[   22.341002]
[   22.341002] Code: 18 01 00 00 c9 c3 55 48 89 e5 53 48 83 ec 18 66 66 90 66 90 be 01 00 00 00 48 89 fb 48 8d 7d f7 e8 a3 fd f5 ff 0f b6 45 f7 ff c0 <01> 83 c0 02 00 00 48 83 c4 18 5b c9 c3 55 48 89 e5 53 48 83 ec
[   22.341002] RIP  [<ffffffff80442a7e>] rt_cache_invalidate+0x25/0x32
[   22.341002]  RSP <ffff88003cd6de08>
[   22.341002] CR2: 00000000000002c0
[   23.182975] ---[ end trace cc508a4cd3aa37ce ]---
[   33.359352] NET: Registered protocol family 17
[   36.346255] Marking TSC unstable due to cpufreq changes
[   40.893522] Clocksource tsc unstable (delta = -221374484 ns)

It's 2b12a4c524812fb3f6ee590a02e65b95c8c32229 + some unreleated trivial patches.

#1 lore raw
Quoted 44 lines · Marcin Slusarz
[   21.035097] Adding 1020112k swap on /dev/sda2.  Priority:-1 extents:1 across:1020112k
[   22.340292] BUG: unable to handle kernel NULL pointer dereference at 00000000000002c0
[   22.341002] IP: [<ffffffff80442a7e>] rt_cache_invalidate+0x25/0x32
[   22.341002] PGD 3dc7c067 PUD 3d198067 PMD 0
[   22.341002] Oops: 0002 [1] PREEMPT
[   22.341002] CPU 0
[   22.341002] Modules linked in: usbhid uhci_hcd tuner tea5767 tda8290 tuner_xc2028 xc5000 tda9887 tuner_simple tuner_types mt20xx tea5761 tda9875 ehci_hcd usbcore bttv ir_common compat_ioctl32 videodev v4l1_compat i2c_algo_bit snd_via82xx snd_ac97_codec v4l2_common ac97_bus snd_pcm videobuf_dma_sg snd_timer snd_page_alloc i2c_viapro videobuf_core btcx_risc snd_mpu401_uart snd_rawmidi tveeprom snd_seq_device snd soundcore
[   22.341002] Pid: 2248, comm: sysctl Not tainted 2.6.27-rc1-00507-g75aecb1 #261
[   22.341002] RIP: 0010:[<ffffffff80442a7e>]  [<ffffffff80442a7e>] rt_cache_invalidate+0x25/0x32
[   22.341002] RSP: 0018:ffff88003cd6de08  EFLAGS: 00010202
[   22.341002] RAX: 0000000000000052 RBX: 0000000000000000 RCX: 0000000000000000
[   22.341002] RDX: ffff88003cd6dda8 RSI: ffff88003cd6dda9 RDI: ffff88003cd6ddb2
[   22.341002] RBP: ffff88003cd6de28 R08: 0000000000000000 R09: ffff88003cd6dbb8
[   22.341002] R10: 00000000a94180f7 R11: ffff88003cd6dc0c R12: 0000000000000001
[   22.341002] R13: ffffffff8062a90c R14: 0000000000000000 R15: 0000000000000040
[   22.341002] FS:  00007f0674ee66f0(0000) GS:ffffffff80625200(0000) knlGS:0000000000000000
[   22.341002] CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[   22.341002] CR2: 00000000000002c0 CR3: 000000003d1a3000 CR4: 00000000000006e0
[   22.341002] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[   22.341002] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[   22.341002] Process sysctl (pid: 2248, threadinfo ffff88003cd6c000, task ffff88003d0dd900)
[   22.341002] Stack:  ffff88003cd6de38 ffffffff80233c93 51ff88003cd6df48 0000000000000000
[   22.341002]  ffff88003cd6de58 ffffffff80442c4c ffffffff80620740 0000000000000001
[   22.341002]  ffffffff8062a90c 0000000000000000 ffff88003cd6de98 ffffffff8046a63b
[   22.341002] Call Trace:
[   22.341002]  [<ffffffff80233c93>] ? do_proc_dointvec+0x3d/0x3f
[   22.341002]  [<ffffffff80442c4c>] rt_cache_flush+0x17/0xe2
[   22.341002]  [<ffffffff8046a63b>] ipv4_doint_and_flush+0x42/0x52
[   22.341002]  [<ffffffff802d263b>] proc_sys_call_handler+0x96/0xbb
[   22.341002]  [<ffffffff802d2674>] proc_sys_write+0x14/0x16
[   22.341002]  [<ffffffff8028f8fd>] vfs_write+0xb3/0x13c
[   22.341002]  [<ffffffff8028fdd0>] sys_write+0x4c/0x74
[   22.341002]  [<ffffffff8020b3fb>] system_call_fastpath+0x16/0x1b
[   22.341002]
[   22.341002]
[   22.341002] Code: 18 01 00 00 c9 c3 55 48 89 e5 53 48 83 ec 18 66 66 90 66 90 be 01 00 00 00 48 89 fb 48 8d 7d f7 e8 a3 fd f5 ff 0f b6 45 f7 ff c0 <01> 83 c0 02 00 00 48 83 c4 18 5b c9 c3 55 48 89 e5 53 48 83 ec
[   22.341002] RIP  [<ffffffff80442a7e>] rt_cache_invalidate+0x25/0x32
[   22.341002]  RSP <ffff88003cd6de08>
[   22.341002] CR2: 00000000000002c0
[   23.182975] ---[ end trace cc508a4cd3aa37ce ]---
[   33.359352] NET: Registered protocol family 17
[   36.346255] Marking TSC unstable due to cpufreq changes
[   40.893522] Clocksource tsc unstable (delta = -221374484 ns)
Quoted 1 line

It's 2b12a4c524812fb3f6ee590a02e65b95c8c32229 + some unreleated trivial patches.

Could you send you .config?

Regards,
Den

#2 lore raw
Quoted 45 lines · Denis V. Lunev
Quoted 44 lines · Marcin Slusarz
[   21.035097] Adding 1020112k swap on /dev/sda2.  Priority:-1 extents:1 across:1020112k
[   22.340292] BUG: unable to handle kernel NULL pointer dereference at 00000000000002c0
[   22.341002] IP: [<ffffffff80442a7e>] rt_cache_invalidate+0x25/0x32
[   22.341002] PGD 3dc7c067 PUD 3d198067 PMD 0
[   22.341002] Oops: 0002 [1] PREEMPT
[   22.341002] CPU 0
[   22.341002] Modules linked in: usbhid uhci_hcd tuner tea5767 tda8290 tuner_xc2028 xc5000 tda9887 tuner_simple tuner_types mt20xx tea5761 tda9875 ehci_hcd usbcore bttv ir_common compat_ioctl32 videodev v4l1_compat i2c_algo_bit snd_via82xx snd_ac97_codec v4l2_common ac97_bus snd_pcm videobuf_dma_sg snd_timer snd_page_alloc i2c_viapro videobuf_core btcx_risc snd_mpu401_uart snd_rawmidi tveeprom snd_seq_device snd soundcore
[   22.341002] Pid: 2248, comm: sysctl Not tainted 2.6.27-rc1-00507-g75aecb1 #261
[   22.341002] RIP: 0010:[<ffffffff80442a7e>]  [<ffffffff80442a7e>] rt_cache_invalidate+0x25/0x32
[   22.341002] RSP: 0018:ffff88003cd6de08  EFLAGS: 00010202
[   22.341002] RAX: 0000000000000052 RBX: 0000000000000000 RCX: 0000000000000000
[   22.341002] RDX: ffff88003cd6dda8 RSI: ffff88003cd6dda9 RDI: ffff88003cd6ddb2
[   22.341002] RBP: ffff88003cd6de28 R08: 0000000000000000 R09: ffff88003cd6dbb8
[   22.341002] R10: 00000000a94180f7 R11: ffff88003cd6dc0c R12: 0000000000000001
[   22.341002] R13: ffffffff8062a90c R14: 0000000000000000 R15: 0000000000000040
[   22.341002] FS:  00007f0674ee66f0(0000) GS:ffffffff80625200(0000) knlGS:0000000000000000
[   22.341002] CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[   22.341002] CR2: 00000000000002c0 CR3: 000000003d1a3000 CR4: 00000000000006e0
[   22.341002] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[   22.341002] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[   22.341002] Process sysctl (pid: 2248, threadinfo ffff88003cd6c000, task ffff88003d0dd900)
[   22.341002] Stack:  ffff88003cd6de38 ffffffff80233c93 51ff88003cd6df48 0000000000000000
[   22.341002]  ffff88003cd6de58 ffffffff80442c4c ffffffff80620740 0000000000000001
[   22.341002]  ffffffff8062a90c 0000000000000000 ffff88003cd6de98 ffffffff8046a63b
[   22.341002] Call Trace:
[   22.341002]  [<ffffffff80233c93>] ? do_proc_dointvec+0x3d/0x3f
[   22.341002]  [<ffffffff80442c4c>] rt_cache_flush+0x17/0xe2
[   22.341002]  [<ffffffff8046a63b>] ipv4_doint_and_flush+0x42/0x52
[   22.341002]  [<ffffffff802d263b>] proc_sys_call_handler+0x96/0xbb
[   22.341002]  [<ffffffff802d2674>] proc_sys_write+0x14/0x16
[   22.341002]  [<ffffffff8028f8fd>] vfs_write+0xb3/0x13c
[   22.341002]  [<ffffffff8028fdd0>] sys_write+0x4c/0x74
[   22.341002]  [<ffffffff8020b3fb>] system_call_fastpath+0x16/0x1b
[   22.341002]
[   22.341002]
[   22.341002] Code: 18 01 00 00 c9 c3 55 48 89 e5 53 48 83 ec 18 66 66 90 66 90 be 01 00 00 00 48 89 fb 48 8d 7d f7 e8 a3 fd f5 ff 0f b6 45 f7 ff c0 <01> 83 c0 02 00 00 48 83 c4 18 5b c9 c3 55 48 89 e5 53 48 83 ec
[   22.341002] RIP  [<ffffffff80442a7e>] rt_cache_invalidate+0x25/0x32
[   22.341002]  RSP <ffff88003cd6de08>
[   22.341002] CR2: 00000000000002c0
[   23.182975] ---[ end trace cc508a4cd3aa37ce ]---
[   33.359352] NET: Registered protocol family 17
[   36.346255] Marking TSC unstable due to cpufreq changes
[   40.893522] Clocksource tsc unstable (delta = -221374484 ns)
Quoted 3 lines
Quoted 1 line

It's 2b12a4c524812fb3f6ee590a02e65b95c8c32229 + some unreleated trivial patches.

Could you send you .config?

No need to, the issue can be triggered by

sysctl net.ipv4.ip_default_ttl=1

when 76e6ebfb40a2455c18234dcb0f9df37533215461 is applied.

ipv4_doint_and_flush and ipv4_doint_and_flush_strategy access the member extra2 of the ctl_table, but it is never set to a meaningful value. Don't know if it's just the following that is missing or if we need another namespace.

net: Add missing extra2 prameter for ip_default_ttl sysctl

Commit 76e6ebfb40a2455c18234dcb0f9df37533215461 needs the extra2 parameter set to init_net, else we'll oops when setting the ip_default_ttl sysctl.

Signed-off-by Sven Wegener <[email protected]>
---
 net/ipv4/sysctl_net_ipv4.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
net/ipv4/sysctl_net_ipv4.c +1 -0
index 770d827..e0689fd 100644
@@ -232,6 +232,7 @@ static struct ctl_table ipv4_table[] = {
 		.mode		= 0644,
 		.proc_handler	= &ipv4_doint_and_flush,
 		.strategy	= &ipv4_doint_and_flush_strategy,
+		.extra2		= &init_net,
 	},
 	{
 		.ctl_name	= NET_IPV4_NO_PMTU_DISC,
#3 lore raw
Quoted 49 lines · Sven Wegener
Quoted 47 lines · Denis V. Lunev
Quoted 45 lines · Marcin Slusarz
[   21.035097] Adding 1020112k swap on /dev/sda2.  Priority:-1 extents:1 across:1020112k
[   22.340292] BUG: unable to handle kernel NULL pointer dereference at 00000000000002c0
[   22.341002] IP: [<ffffffff80442a7e>] rt_cache_invalidate+0x25/0x32
[   22.341002] PGD 3dc7c067 PUD 3d198067 PMD 0
[   22.341002] Oops: 0002 [1] PREEMPT
[   22.341002] CPU 0
[   22.341002] Modules linked in: usbhid uhci_hcd tuner tea5767 tda8290 tuner_xc2028 xc5000 tda9887 tuner_simple tuner_types mt20xx tea5761 tda9875 ehci_hcd usbcore bttv ir_common compat_ioctl32 videodev v4l1_compat i2c_algo_bit snd_via82xx snd_ac97_codec v4l2_common ac97_bus snd_pcm videobuf_dma_sg snd_timer snd_page_alloc i2c_viapro videobuf_core btcx_risc snd_mpu401_uart snd_rawmidi tveeprom snd_seq_device snd soundcore
[   22.341002] Pid: 2248, comm: sysctl Not tainted 2.6.27-rc1-00507-g75aecb1 #261
[   22.341002] RIP: 0010:[<ffffffff80442a7e>]  [<ffffffff80442a7e>] rt_cache_invalidate+0x25/0x32
[   22.341002] RSP: 0018:ffff88003cd6de08  EFLAGS: 00010202
[   22.341002] RAX: 0000000000000052 RBX: 0000000000000000 RCX: 0000000000000000
[   22.341002] RDX: ffff88003cd6dda8 RSI: ffff88003cd6dda9 RDI: ffff88003cd6ddb2
[   22.341002] RBP: ffff88003cd6de28 R08: 0000000000000000 R09: ffff88003cd6dbb8
[   22.341002] R10: 00000000a94180f7 R11: ffff88003cd6dc0c R12: 0000000000000001
[   22.341002] R13: ffffffff8062a90c R14: 0000000000000000 R15: 0000000000000040
[   22.341002] FS:  00007f0674ee66f0(0000) GS:ffffffff80625200(0000) knlGS:0000000000000000
[   22.341002] CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[   22.341002] CR2: 00000000000002c0 CR3: 000000003d1a3000 CR4: 00000000000006e0
[   22.341002] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[   22.341002] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[   22.341002] Process sysctl (pid: 2248, threadinfo ffff88003cd6c000, task ffff88003d0dd900)
[   22.341002] Stack:  ffff88003cd6de38 ffffffff80233c93 51ff88003cd6df48 0000000000000000
[   22.341002]  ffff88003cd6de58 ffffffff80442c4c ffffffff80620740 0000000000000001
[   22.341002]  ffffffff8062a90c 0000000000000000 ffff88003cd6de98 ffffffff8046a63b
[   22.341002] Call Trace:
[   22.341002]  [<ffffffff80233c93>] ? do_proc_dointvec+0x3d/0x3f
[   22.341002]  [<ffffffff80442c4c>] rt_cache_flush+0x17/0xe2
[   22.341002]  [<ffffffff8046a63b>] ipv4_doint_and_flush+0x42/0x52
[   22.341002]  [<ffffffff802d263b>] proc_sys_call_handler+0x96/0xbb
[   22.341002]  [<ffffffff802d2674>] proc_sys_write+0x14/0x16
[   22.341002]  [<ffffffff8028f8fd>] vfs_write+0xb3/0x13c
[   22.341002]  [<ffffffff8028fdd0>] sys_write+0x4c/0x74
[   22.341002]  [<ffffffff8020b3fb>] system_call_fastpath+0x16/0x1b
[   22.341002]
[   22.341002]
[   22.341002] Code: 18 01 00 00 c9 c3 55 48 89 e5 53 48 83 ec 18 66 66 90 66 90 be 01 00 00 00 48 89 fb 48 8d 7d f7 e8 a3 fd f5 ff 0f b6 45 f7 ff c0 <01> 83 c0 02 00 00 48 83 c4 18 5b c9 c3 55 48 89 e5 53 48 83 ec
[   22.341002] RIP  [<ffffffff80442a7e>] rt_cache_invalidate+0x25/0x32
[   22.341002]  RSP <ffff88003cd6de08>
[   22.341002] CR2: 00000000000002c0
[   23.182975] ---[ end trace cc508a4cd3aa37ce ]---
[   33.359352] NET: Registered protocol family 17
[   36.346255] Marking TSC unstable due to cpufreq changes
[   40.893522] Clocksource tsc unstable (delta = -221374484 ns)

It's 2b12a4c524812fb3f6ee590a02e65b95c8c32229 + some unreleated trivial patches.

Quoted 7 lines
Quoted 1 line

Could you send you .config?

No need to, the issue can be triggered by

sysctl net.ipv4.ip_default_ttl=1

when 76e6ebfb40a2455c18234dcb0f9df37533215461 is applied.

Actually it's 86c657f6b5bbf2f3ec2213eca528998134a9b344, 76e6ebf adds the initial code that accesses the extra2 parameter, but 86c657f adds the oops.

Quoted 33 lines

ipv4_doint_and_flush and ipv4_doint_and_flush_strategy access the member extra2 of the ctl_table, but it is never set to a meaningful value. Don't know if it's just the following that is missing or if we need another namespace.

net: Add missing extra2 prameter for ip_default_ttl sysctl

Commit 76e6ebfb40a2455c18234dcb0f9df37533215461 needs the extra2 parameter set to init_net, else we'll oops when setting the ip_default_ttl sysctl.

Signed-off-by Sven Wegener <[email protected]>
---
 net/ipv4/sysctl_net_ipv4.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
net/ipv4/sysctl_net_ipv4.c +1 -1
index 770d827..e0689fd 100644
@@ -232,6 +232,7 @@ static struct ctl_table ipv4_table[] = {
 		.mode		= 0644,
 		.proc_handler	= &ipv4_doint_and_flush,
 		.strategy	= &ipv4_doint_and_flush_strategy,
+		.extra2		= &init_net,
 	},
 	{
 		.ctl_name	= NET_IPV4_NO_PMTU_DISC,
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#4 lore raw
Quoted 12 lines · Sven Wegener
Quoted 10 lines · Sven Wegener
Quoted 5 lines · Denis V. Lunev
Quoted 2 lines · Marcin Slusarz

[...]
It's 2b12a4c524812fb3f6ee590a02e65b95c8c32229 + some unreleated trivial patches.

Could you send you .config?

No need to, the issue can be triggered by

Quoted 7 lines
Quoted 3 lines

sysctl net.ipv4.ip_default_ttl=1

when 76e6ebfb40a2455c18234dcb0f9df37533215461 is applied.

Actually it's 86c657f6b5bbf2f3ec2213eca528998134a9b344, 76e6ebf adds the initial code that accesses the extra2 parameter, but 86c657f adds the oops.

I should stop for today, it's e84f84f276473dcc673f360e8ff3203148bdf0e2 that has the &net->ipv4.rt_genid in rt_cache_invalidate(). ...

author Tested-by
#5 lore raw
In reply to Sven Wegener
Quoted 47 lines · Sven Wegener
Quoted 45 lines · Denis V. Lunev
Quoted 44 lines · Marcin Slusarz
[   21.035097] Adding 1020112k swap on /dev/sda2.  Priority:-1 extents:1 across:1020112k
[   22.340292] BUG: unable to handle kernel NULL pointer dereference at 00000000000002c0
[   22.341002] IP: [<ffffffff80442a7e>] rt_cache_invalidate+0x25/0x32
[   22.341002] PGD 3dc7c067 PUD 3d198067 PMD 0
[   22.341002] Oops: 0002 [1] PREEMPT
[   22.341002] CPU 0
[   22.341002] Modules linked in: usbhid uhci_hcd tuner tea5767 tda8290 tuner_xc2028 xc5000 tda9887 tuner_simple tuner_types mt20xx tea5761 tda9875 ehci_hcd usbcore bttv ir_common compat_ioctl32 videodev v4l1_compat i2c_algo_bit snd_via82xx snd_ac97_codec v4l2_common ac97_bus snd_pcm videobuf_dma_sg snd_timer snd_page_alloc i2c_viapro videobuf_core btcx_risc snd_mpu401_uart snd_rawmidi tveeprom snd_seq_device snd soundcore
[   22.341002] Pid: 2248, comm: sysctl Not tainted 2.6.27-rc1-00507-g75aecb1 #261
[   22.341002] RIP: 0010:[<ffffffff80442a7e>]  [<ffffffff80442a7e>] rt_cache_invalidate+0x25/0x32
[   22.341002] RSP: 0018:ffff88003cd6de08  EFLAGS: 00010202
[   22.341002] RAX: 0000000000000052 RBX: 0000000000000000 RCX: 0000000000000000
[   22.341002] RDX: ffff88003cd6dda8 RSI: ffff88003cd6dda9 RDI: ffff88003cd6ddb2
[   22.341002] RBP: ffff88003cd6de28 R08: 0000000000000000 R09: ffff88003cd6dbb8
[   22.341002] R10: 00000000a94180f7 R11: ffff88003cd6dc0c R12: 0000000000000001
[   22.341002] R13: ffffffff8062a90c R14: 0000000000000000 R15: 0000000000000040
[   22.341002] FS:  00007f0674ee66f0(0000) GS:ffffffff80625200(0000) knlGS:0000000000000000
[   22.341002] CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[   22.341002] CR2: 00000000000002c0 CR3: 000000003d1a3000 CR4: 00000000000006e0
[   22.341002] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[   22.341002] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[   22.341002] Process sysctl (pid: 2248, threadinfo ffff88003cd6c000, task ffff88003d0dd900)
[   22.341002] Stack:  ffff88003cd6de38 ffffffff80233c93 51ff88003cd6df48 0000000000000000
[   22.341002]  ffff88003cd6de58 ffffffff80442c4c ffffffff80620740 0000000000000001
[   22.341002]  ffffffff8062a90c 0000000000000000 ffff88003cd6de98 ffffffff8046a63b
[   22.341002] Call Trace:
[   22.341002]  [<ffffffff80233c93>] ? do_proc_dointvec+0x3d/0x3f
[   22.341002]  [<ffffffff80442c4c>] rt_cache_flush+0x17/0xe2
[   22.341002]  [<ffffffff8046a63b>] ipv4_doint_and_flush+0x42/0x52
[   22.341002]  [<ffffffff802d263b>] proc_sys_call_handler+0x96/0xbb
[   22.341002]  [<ffffffff802d2674>] proc_sys_write+0x14/0x16
[   22.341002]  [<ffffffff8028f8fd>] vfs_write+0xb3/0x13c
[   22.341002]  [<ffffffff8028fdd0>] sys_write+0x4c/0x74
[   22.341002]  [<ffffffff8020b3fb>] system_call_fastpath+0x16/0x1b
[   22.341002]
[   22.341002]
[   22.341002] Code: 18 01 00 00 c9 c3 55 48 89 e5 53 48 83 ec 18 66 66 90 66 90 be 01 00 00 00 48 89 fb 48 8d 7d f7 e8 a3 fd f5 ff 0f b6 45 f7 ff c0 <01> 83 c0 02 00 00 48 83 c4 18 5b c9 c3 55 48 89 e5 53 48 83 ec
[   22.341002] RIP  [<ffffffff80442a7e>] rt_cache_invalidate+0x25/0x32
[   22.341002]  RSP <ffff88003cd6de08>
[   22.341002] CR2: 00000000000002c0
[   23.182975] ---[ end trace cc508a4cd3aa37ce ]---
[   33.359352] NET: Registered protocol family 17
[   36.346255] Marking TSC unstable due to cpufreq changes
[   40.893522] Clocksource tsc unstable (delta = -221374484 ns)
Quoted 3 lines
Quoted 3 lines
Quoted 1 line

It's 2b12a4c524812fb3f6ee590a02e65b95c8c32229 + some unreleated trivial patches.

Could you send you .config?

http://www.kadu.net/~joi/kernel/2008.08.03/config

Quoted 3 lines

No need to, the issue can be triggered by

sysctl net.ipv4.ip_default_ttl=1

Yes, I have this in sysctl.conf:

$ grep "ip_default_ttl" /etc/sysctl.conf
net.ipv4.ip_default_ttl = 92
Quoted 22 lines

when 76e6ebfb40a2455c18234dcb0f9df37533215461 is applied.

ipv4_doint_and_flush and ipv4_doint_and_flush_strategy access the member extra2 of the ctl_table, but it is never set to a meaningful value. Don't know if it's just the following that is missing or if we need another namespace.

net: Add missing extra2 prameter for ip_default_ttl sysctl

Commit 76e6ebfb40a2455c18234dcb0f9df37533215461 needs the extra2 parameter set to init_net, else we'll oops when setting the ip_default_ttl sysctl.

Signed-off-by Sven Wegener <[email protected]>
---
 net/ipv4/sysctl_net_ipv4.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
net/ipv4/sysctl_net_ipv4.c +0 -0
index 770d827..e0689fd 100644

net/ipv4/sysctl_net_ipv4.c static struct ctl_table ipv4_table[] = { · line 238

Quoted 7 lines
net/ipv4/sysctl_net_ipv4.c +1 -0
@@ -232,6 +232,7 @@ static struct ctl_table ipv4_table[] = {
 		.mode		= 0644,
 		.proc_handler	= &ipv4_doint_and_flush,
 		.strategy	= &ipv4_doint_and_flush_strategy,
+		.extra2		= &init_net,
 	},
 	{
 		.ctl_name	= NET_IPV4_NO_PMTU_DISC,

Thanks, now it works.

Tested-by Marcin Slusarz <[email protected]>

Marcin

Acked-by
#6 lore raw
In reply to Sven Wegener
Quoted 85 lines · Sven Wegener
Quoted 45 lines · Denis V. Lunev
Quoted 44 lines · Marcin Slusarz
[   21.035097] Adding 1020112k swap on /dev/sda2.  Priority:-1 extents:1 across:1020112k
[   22.340292] BUG: unable to handle kernel NULL pointer dereference at 00000000000002c0
[   22.341002] IP: [<ffffffff80442a7e>] rt_cache_invalidate+0x25/0x32
[   22.341002] PGD 3dc7c067 PUD 3d198067 PMD 0
[   22.341002] Oops: 0002 [1] PREEMPT
[   22.341002] CPU 0
[   22.341002] Modules linked in: usbhid uhci_hcd tuner tea5767 tda8290 tuner_xc2028 xc5000 tda9887 tuner_simple tuner_types mt20xx tea5761 tda9875 ehci_hcd usbcore bttv ir_common compat_ioctl32 videodev v4l1_compat i2c_algo_bit snd_via82xx snd_ac97_codec v4l2_common ac97_bus snd_pcm videobuf_dma_sg snd_timer snd_page_alloc i2c_viapro videobuf_core btcx_risc snd_mpu401_uart snd_rawmidi tveeprom snd_seq_device snd soundcore
[   22.341002] Pid: 2248, comm: sysctl Not tainted 2.6.27-rc1-00507-g75aecb1 #261
[   22.341002] RIP: 0010:[<ffffffff80442a7e>]  [<ffffffff80442a7e>] rt_cache_invalidate+0x25/0x32
[   22.341002] RSP: 0018:ffff88003cd6de08  EFLAGS: 00010202
[   22.341002] RAX: 0000000000000052 RBX: 0000000000000000 RCX: 0000000000000000
[   22.341002] RDX: ffff88003cd6dda8 RSI: ffff88003cd6dda9 RDI: ffff88003cd6ddb2
[   22.341002] RBP: ffff88003cd6de28 R08: 0000000000000000 R09: ffff88003cd6dbb8
[   22.341002] R10: 00000000a94180f7 R11: ffff88003cd6dc0c R12: 0000000000000001
[   22.341002] R13: ffffffff8062a90c R14: 0000000000000000 R15: 0000000000000040
[   22.341002] FS:  00007f0674ee66f0(0000) GS:ffffffff80625200(0000) knlGS:0000000000000000
[   22.341002] CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[   22.341002] CR2: 00000000000002c0 CR3: 000000003d1a3000 CR4: 00000000000006e0
[   22.341002] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[   22.341002] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[   22.341002] Process sysctl (pid: 2248, threadinfo ffff88003cd6c000, task ffff88003d0dd900)
[   22.341002] Stack:  ffff88003cd6de38 ffffffff80233c93 51ff88003cd6df48 0000000000000000
[   22.341002]  ffff88003cd6de58 ffffffff80442c4c ffffffff80620740 0000000000000001
[   22.341002]  ffffffff8062a90c 0000000000000000 ffff88003cd6de98 ffffffff8046a63b
[   22.341002] Call Trace:
[   22.341002]  [<ffffffff80233c93>] ? do_proc_dointvec+0x3d/0x3f
[   22.341002]  [<ffffffff80442c4c>] rt_cache_flush+0x17/0xe2
[   22.341002]  [<ffffffff8046a63b>] ipv4_doint_and_flush+0x42/0x52
[   22.341002]  [<ffffffff802d263b>] proc_sys_call_handler+0x96/0xbb
[   22.341002]  [<ffffffff802d2674>] proc_sys_write+0x14/0x16
[   22.341002]  [<ffffffff8028f8fd>] vfs_write+0xb3/0x13c
[   22.341002]  [<ffffffff8028fdd0>] sys_write+0x4c/0x74
[   22.341002]  [<ffffffff8020b3fb>] system_call_fastpath+0x16/0x1b
[   22.341002]
[   22.341002]
[   22.341002] Code: 18 01 00 00 c9 c3 55 48 89 e5 53 48 83 ec 18 66 66 90 66 90 be 01 00 00 00 48 89 fb 48 8d 7d f7 e8 a3 fd f5 ff 0f b6 45 f7 ff c0 <01> 83 c0 02 00 00 48 83 c4 18 5b c9 c3 55 48 89 e5 53 48 83 ec
[   22.341002] RIP  [<ffffffff80442a7e>] rt_cache_invalidate+0x25/0x32
[   22.341002]  RSP <ffff88003cd6de08>
[   22.341002] CR2: 00000000000002c0
[   23.182975] ---[ end trace cc508a4cd3aa37ce ]---
[   33.359352] NET: Registered protocol family 17
[   36.346255] Marking TSC unstable due to cpufreq changes
[   40.893522] Clocksource tsc unstable (delta = -221374484 ns)
Quoted 3 lines
Quoted 1 line

It's 2b12a4c524812fb3f6ee590a02e65b95c8c32229 + some unreleated trivial patches.

Could you send you .config?

No need to, the issue can be triggered by

sysctl net.ipv4.ip_default_ttl=1

when 76e6ebfb40a2455c18234dcb0f9df37533215461 is applied.

ipv4_doint_and_flush and ipv4_doint_and_flush_strategy access the member extra2 of the ctl_table, but it is never set to a meaningful value. Don't know if it's just the following that is missing or if we need another namespace.

net: Add missing extra2 prameter for ip_default_ttl sysctl

Commit 76e6ebfb40a2455c18234dcb0f9df37533215461 needs the extra2 parameter set to init_net, else we'll oops when setting the ip_default_ttl sysctl.

Signed-off-by Sven Wegener <[email protected]>
---
 net/ipv4/sysctl_net_ipv4.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
net/ipv4/sysctl_net_ipv4.c +1 -1
index 770d827..e0689fd 100644
@@ -232,6 +232,7 @@ static struct ctl_table ipv4_table[] = {
 		.mode		= 0644,
 		.proc_handler	= &ipv4_doint_and_flush,
 		.strategy	= &ipv4_doint_and_flush_strategy,
+		.extra2		= &init_net,
 	},
 	{
 		.ctl_name	= NET_IPV4_NO_PMTU_DISC,
--
Quoted 3 lines

To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Acked-by Denis V. Lunev <[email protected]>
#7 lore raw

PATCH 1/1 net: Add missing extra2 parameter for ip_default_ttl sysctl

Commit 76e6ebfb40a2455c18234dcb0f9df37533215461 acceses the extra2 parameter of the ip_default_ttl ctl_table, but it is never set to a meaningful value. When e84f84f276473dcc673f360e8ff3203148bdf0e2 is applied, we'll oops in rt_cache_invalidate(). Set extra2 to init_net, to avoid that.

Reported-by Marcin Slusarz <[email protected]>
Signed-off-by Sven Wegener <[email protected]>
Tested-by Marcin Slusarz <[email protected]>
Acked-by Denis V. Lunev <[email protected]>
---
 net/ipv4/sysctl_net_ipv4.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
net/ipv4/sysctl_net_ipv4.c +1 -0
index 770d827..e0689fd 100644
@@ -232,6 +232,7 @@ static struct ctl_table ipv4_table[] = {
 		.mode		= 0644,
 		.proc_handler	= &ipv4_doint_and_flush,
 		.strategy	= &ipv4_doint_and_flush_strategy,
+		.extra2		= &init_net,
 	},
 	{
 		.ctl_name	= NET_IPV4_NO_PMTU_DISC,
maintainer Tested-by Marcin Slusarz Acked-by Denis V. Lunev on v1 1/1 Applied
#8 lore raw

Re: [PATCH] net: Add missing extra2 parameter for ip_default_ttl sysctl

From: Sven Wegener <[email protected]>
Date: Sun, 3 Aug 2008 22:18:59 +0200 (CEST)

Quoted 9 lines

Commit 76e6ebfb40a2455c18234dcb0f9df37533215461 acceses the extra2 parameter of the ip_default_ttl ctl_table, but it is never set to a meaningful value. When e84f84f276473dcc673f360e8ff3203148bdf0e2 is applied, we'll oops in rt_cache_invalidate(). Set extra2 to init_net, to avoid that.

Reported-by Marcin Slusarz <[email protected]>
Signed-off-by Sven Wegener <[email protected]>
Tested-by Marcin Slusarz <[email protected]>
Acked-by Denis V. Lunev <[email protected]>

Applied, thanks a lot.

Please provide commit header line text when referencing SHA IDs, as the SHA IDs can change when patches are applied to different trees. Here is the actual changelog message I used so you can see what I mean:

net: Add missing extra2 parameter for ip_default_ttl sysctl

Commit 76e6ebfb40a2455c18234dcb0f9df37533215461 ("netns: add namespace parameter to rt_cache_flush") acceses the extra2 parameter of the ip_default_ttl ctl_table, but it is never set to a meaningful value. When e84f84f276473dcc673f360e8ff3203148bdf0e2 ("netns: place rt_genid into struct net") is applied, we'll oops in rt_cache_invalidate(). Set extra2 to init_net, to avoid that.

Reported-by Marcin Slusarz <[email protected]>
Signed-off-by Sven Wegener <[email protected]>
Tested-by Marcin Slusarz <[email protected]>
Acked-by Denis V. Lunev <[email protected]>
Signed-off-by David S. Miller <[email protected]>