Skip to contentSkip to conversation

beagle LED fixes

PATCH In review David Brownell 3 participants 3 messages Aug 5, 2008

lore
Share & tools
lore

David Brownell

author
#0 lore raw

PATCH 1/1 beagle LED fixes

Signed-off-by David Brownell <[email protected]>

Update and fix Beagle LED declarations: gpios for USR0 and USR1 were swapped, and their names don't match docs or silksreen.

Signed-off-by David Brownell <[email protected]>
---
 arch/arm/mach-omap2/board-omap3beagle.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

--- a/arch/arm/mach-omap2/board-omap3beagle.c 2008-08-04 22:08:16.000000000 -0700
+++ b/arch/arm/mach-omap2/board-omap3beagle.c 2008-08-04 22:08:36.000000000 -0700

@@ -75,14 +76,14 @@ static struct omap_lcd_config omap3_beag

struct gpio_led gpio_leds[] = {
{
- .name = "beagleboard::led0",
+ .name = "beagleboard::usr0",
.default_trigger = "none",
- .gpio = 149,
+ .gpio = 150,
},
{
- .name = "beagleboard::led1",
+ .name = "beagleboard::usr1",
.default_trigger = "none",
- .gpio = 150,
+ .gpio = 149,
},
};

Acked-by on v1 1/1
#1 lore raw

Op 5 aug 2008, om 08:56 heeft David Brownell het volgende geschreven:

Quoted 4 lines
Signed-off-by David Brownell <[email protected]>

Update and fix Beagle LED declarations: gpios for USR0 and USR1 were swapped, and their names don't match docs or silksreen.

I just heard that from TI and wanted to fix that today :) I didn't notice it because revA board have the leds shorted together so they both light up at the same time.

Quoted 1 line
Signed-off-by David Brownell <[email protected]>
Acked-by Koen Kooi <[email protected]>
Quoted 34 lines

---
arch/arm/mach-omap2/board-omap3beagle.c | 9 +++++----

1 file changed, 5 insertions(+), 4 deletions(-)

--- a/arch/arm/mach-omap2/board-omap3beagle.c 2008-08-04
22:08:16.000000000 -0700
+++ b/arch/arm/mach-omap2/board-omap3beagle.c 2008-08-04
22:08:36.000000000 -0700

(quoted diff) +4 -5
@@ -75,14 +76,14 @@ static struct omap_lcd_config omap3_beag
 
 struct gpio_led gpio_leds[] = {
 	{
-		.name			= "beagleboard::led0",
+		.name			= "beagleboard::usr0",
 		.default_trigger	= "none",
-		.gpio			= 149,
+		.gpio			= 150,
 	},
 	{
-		.name			= "beagleboard::led1",
+		.name			= "beagleboard::usr1",
 		.default_trigger	= "none",
-		.gpio			= 150,
+		.gpio			= 149,
 	},
 };
 
--

To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
Quoted 11 lines · Koen Kooi

Op 5 aug 2008, om 08:56 heeft David Brownell het volgende geschreven:

Quoted 4 lines
Signed-off-by David Brownell <[email protected]>

Update and fix Beagle LED declarations: gpios for USR0 and USR1 were swapped, and their names don't match docs or silksreen.

I just heard that from TI and wanted to fix that today :) I didn't notice it because revA board have the leds shorted together so they both light up at the same time.

Pushing today.

Tony

Quoted 41 lines
Quoted 2 lines
Signed-off-by David Brownell <[email protected]>
Acked-by Koen Kooi <[email protected]>
Quoted 35 lines

---
arch/arm/mach-omap2/board-omap3beagle.c | 9 +++++----

1 file changed, 5 insertions(+), 4 deletions(-)

--- a/arch/arm/mach-omap2/board-omap3beagle.c 2008-08-04
22:08:16.000000000 -0700
+++ b/arch/arm/mach-omap2/board-omap3beagle.c 2008-08-04
22:08:36.000000000 -0700

(quoted diff) +4 -5
@@ -75,14 +76,14 @@ static struct omap_lcd_config omap3_beag
 
 struct gpio_led gpio_leds[] = {
 	{
-		.name			= "beagleboard::led0",
+		.name			= "beagleboard::usr0",
 		.default_trigger	= "none",
-		.gpio			= 149,
+		.gpio			= 150,
 	},
 	{
-		.name			= "beagleboard::led1",
+		.name			= "beagleboard::usr1",
 		.default_trigger	= "none",
-		.gpio			= 150,
+		.gpio			= 149,
 	},
 };
 
--

To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html