Skip to contentSkip to conversation

busybox: fix missing dependencies in unpacked and config rules

PATCH New Hans-Christian Egtvedt 3 participants 4 messages Jul 29, 2008 – Sep 25, 2008 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 busybox: fix missing dependencies in unpacked and config rules

This patch adds depedency to host-sed and $(PROJECT_BUILD_DIR) when running make busybox-config and busybox-unpacked.

---
 package/busybox/busybox.mk |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
package/busybox/busybox.mk +2 -2
index c616e45..969502b 100644
@@ -127,9 +127,9 @@ busybox: uclibc $(TARGET_DIR)/bin/busybox
 
 busybox-source: $(DL_DIR)/$(BUSYBOX_SOURCE)
 
-busybox-unpacked: $(BUSYBOX_DIR)/.unpacked
+busybox-unpacked: host-sed $(PROJECT_BUILD_DIR) $(BUSYBOX_DIR)/.unpacked
 
-busybox-config: $(BUSYBOX_DIR)/.configured
+busybox-config: host-sed $(PROJECT_BUILD_DIR) $(BUSYBOX_DIR)/.configured
 
 busybox-menuconfig: host-sed $(PROJECT_BUILD_DIR) busybox-source $(BUSYBOX_DIR)/.configured
 	$(MAKE) __TARGET_ARCH=$(ARCH) -C $(BUSYBOX_DIR) menuconfig
Signature · 1 line
1.5.4.3
#1 lore raw

PATCH 1/1 busybox: fix missing dependencies in unpacked and config rules

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Hans-Christian" == Hans-Christian Egtvedt <[email protected]> writes:

Hans-Christian> This patch adds depedency to host-sed and Hans-Christian> $(PROJECT_BUILD_DIR) when running make busybox-config Hans-Christian> and busybox-unpacked.

Thanks, committed as r23065.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 busybox: fix missing dependencies in unpacked and config rules

Quoted 7 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Hans-Christian" == Hans-Christian Egtvedt <[email protected]> writes:

Hans-Christian> This patch adds depedency to host-sed and Hans-Christian> $(PROJECT_BUILD_DIR) when running make busybox-config Hans-Christian> and busybox-unpacked.

Thanks, committed as r23065.

Does that really work?

Please

$ chmod -x $(which sed)
on your build host, so that host-sed has to be actually be built (ISTR
that we rightfully use the busybox sed in this case)
then wipe your obj trees and
$ cp -a my_toplevel_config.BAK .config
$ make busybox-menuconfig

I think that if you had a pristine tree and copyied a backed-up br2.config to the toplevel, that you could (previously) run all menuconfig targets (with a disfunctional sed on your host).

A message that is not in the archive (sent off-list or not yet received): 7F3102E19F8147C3A4922F613D734799@aeglos

#4 lore raw

PATCH 1/1 busybox: fix missing dependencies inunpacked and config rules

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Ulf" == Ulf Samuelsson <[email protected]> writes:

CC'ed list - Please keep buildroot stuff on the buildroot list.

Ulf> You are aware that you broke the script downloading the linux image to Ulf> the target
Ulf> by removing $(DATE) from the image name in Config.in?

I take it that you are referring to r23254? If so, why don't you just set ROOTFS_SUFFIX to what you need?

Ulf> A fix may be needed, but this should keep $(DATE) in the image name Ulf> if the Atmel specific U-boot is used.

Signature · 1 line
Bye, Peter Korsgaard