Skip to contentSkip to conversation

usb: cdc-acm: flags passed to spin_lock_irqsave must be unsigned

PATCH In review Marcin Slusarz 2 participants 2 messages Aug 3, 2008 – Aug 7, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: cdc-acm: flags passed to spin_lock_irqsave must be unsigned

gcc warned about it:
drivers/usb/class/cdc-acm.c: In function 'acm_waker':
drivers/usb/class/cdc-acm.c:527: warning: comparison of distinct pointer types lacks a cast drivers/usb/class/cdc-acm.c:529: warning: comparison of distinct pointer types lacks a cast

Cc Oliver Neukum <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
---
 drivers/usb/class/cdc-acm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/class/cdc-acm.c +1 -1
index 0725b18..a92395b 100644
@@ -512,7 +512,7 @@ static void acm_softint(struct work_struct *work)
 static void acm_waker(struct work_struct *waker)
 {
 	struct acm *acm = container_of(waker, struct acm, waker);
-	long flags;
+	unsigned long flags;
 	int rv;
 
 	rv = usb_autopm_get_interface(acm->control);
Signature · 1 line
1.5.4.5
#1 lore raw
Quoted 8 lines · Marcin Slusarz

gcc warned about it:
drivers/usb/class/cdc-acm.c: In function 'acm_waker':
drivers/usb/class/cdc-acm.c:527: warning: comparison of distinct pointer types lacks a cast drivers/usb/class/cdc-acm.c:529: warning: comparison of distinct pointer types lacks a cast

Cc Oliver Neukum <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>

Just got this fix from someone else first, sorry, but thanks for the patch.

greg k-h