Skip to contentSkip to conversation

PCI: Limit VPD length for Broadcom 5708S

DISCUSSION Dean Hildebrand 2 participants 4 messages Aug 5, 2008 – Aug 8, 2008 2 messages not in the archive PCI

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): 2d9716d7-99a4-4d17-9cae-83842e216c8c@y19g2000prn.googlegroups.com

#2 lore raw
Quoted 3 lines

I have no idea if 5706S and 5709S also needs this truncation ofVPDlength

It seems that our IBM Blade servers using 5706S also require this fix. We have confirmed that the patch below works on 2.6.27-rc1.

drivers/pci/quirks.c 2008-08-05 10:50:57.000000000 -0700 renamed from drivers/pci/quirks.c 2008-08-05 10:51:42.000000000 -0700 +2 -1
diff -uprN linux-2.6.27-rc1/drivers/pci/quirks.c linux-2.6.27-rc1-fix/drivers/pci/quirks.c
@@ -1756,9 +1756,10 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_VI
  */
 static void __devinit quirk_brcm_570x_limit_vpd(struct pci_dev *dev)
 {
-       /*  Only disable the VPD capability for 5706, 5708, and 5709 rev. A */
+       /*  Only disable the VPD capability for 5706, 5706S, 5708, and 5709 rev. A */
        if ((dev->device == PCI_DEVICE_ID_NX2_5706) ||
            (dev->device == PCI_DEVICE_ID_NX2_5708) ||
+           (dev->device == PCI_DEVICE_ID_NX2_5706S) ||
            ((dev->device == PCI_DEVICE_ID_NX2_5709) &&
             (dev->revision & 0xf0) == 0x0)) {
                if (dev->vpd)

Please cc me on the response. Thanks,
Dean Hildebrand
IBM Almaden
[email protected]

#3 lore raw
Quoted 20 lines · Dean Hildebrand
Quoted 1 line

I have no idea if 5706S and 5709S also needs this truncation ofVPDlength

It seems that our IBM Blade servers using 5706S also require this fix. We have confirmed that the patch below works on 2.6.27-rc1.

diff -uprN linux-2.6.27-rc1/drivers/pci/quirks.c
linux-2.6.27-rc1-fix/drivers/pci/quirks.c
--- linux-2.6.27-rc1/drivers/pci/quirks.c 2008-08-05
10:51:42.000000000 -0700
+++ linux-2.6.27-rc1-fix/drivers/pci/quirks.c 2008-08-05
10:50:57.000000000 -0700

drivers/pci/quirks.c 2008-08-05 10:50:57.000000000 -0700 renamed from drivers/pci/quirks.c 2008-08-05 10:51:42.000000000 -0700 +0 -1
@@ -1756,9 +1756,10 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_VI
   */
  static void __devinit quirk_brcm_570x_limit_vpd(struct pci_dev *dev)
  {
-       /*  Only disable the VPD capability for 5706, 5708, and 5709

rev. A */
+ /* Only disable the VPD capability for 5706, 5706S, 5708, and
5709 rev. A */

Quoted 6 lines
         if ((dev->device == PCI_DEVICE_ID_NX2_5706) ||
             (dev->device == PCI_DEVICE_ID_NX2_5708) ||
+           (dev->device == PCI_DEVICE_ID_NX2_5706S) ||
             ((dev->device == PCI_DEVICE_ID_NX2_5709) &&
              (dev->revision & 0xf0) == 0x0)) {
                 if (dev->vpd)

Looks fine. Can you respin against my for-linus branch and resubmit with a signed-off-by and full changelog?

Thanks,
Jesse

#4 lore raw
Quoted 18 lines · Jesse Barnes
Quoted 17 lines · Dean Hildebrand
Quoted 1 line

I have no idea if 5706S and 5709S also needs this truncation ofVPDlength

It seems that our IBM Blade servers using 5706S also require this fix. We have confirmed that the patch below works on 2.6.27-rc1.

diff -uprN linux-2.6.27-rc1/drivers/pci/quirks.c
linux-2.6.27-rc1-fix/drivers/pci/quirks.c
--- linux-2.6.27-rc1/drivers/pci/quirks.c 2008-08-05
10:51:42.000000000 -0700
+++ linux-2.6.27-rc1-fix/drivers/pci/quirks.c 2008-08-05
10:50:57.000000000 -0700

(quoted diff) +0 -1
@@ -1756,9 +1756,10 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_VI
   */
  static void __devinit quirk_brcm_570x_limit_vpd(struct pci_dev *dev)
  {
-       /*  Only disable the VPD capability for 5706, 5708, and 5709

rev. A */
+ /* Only disable the VPD capability for 5706, 5706S, 5708, and

Quoted 8 lines
Quoted 7 lines

5709 rev. A */

         if ((dev->device == PCI_DEVICE_ID_NX2_5706) ||
             (dev->device == PCI_DEVICE_ID_NX2_5708) ||
+           (dev->device == PCI_DEVICE_ID_NX2_5706S) ||
             ((dev->device == PCI_DEVICE_ID_NX2_5709) &&
              (dev->revision & 0xf0) == 0x0)) {
                 if (dev->vpd)

Looks fine. Can you respin against my for-linus branch and resubmit with a signed-off-by and full changelog

<cid:[email protected]>Ok, here it is.
----

BCM5706S wont work correctly unless VPD length truncated to 128

---
drivers/pci/quirks.c | 4 +++-

1 files changed, 3 insertions(+), 1 deletions(-)
drivers/pci/quirks.c +0 -0
index 59667e5..9236e7f 100644
@@ -1757,9 +1757,11 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_VIA, 0x324e, quirk_via_cx700_pci_parking_c

static void __devinit quirk_brcm_570x_limit_vpd(struct pci_dev *dev)

{
    /*
-     * Only disable the VPD capability for 5706, 5708, 5708S and 5709 rev. A
+     * Only disable the VPD capability for 5706, 5706S, 5708,
+     * 5708S and 5709 rev. A
     */
    if ((dev->device == PCI_DEVICE_ID_NX2_5706) ||
+        (dev->device == PCI_DEVICE_ID_NX2_5706S) ||
        (dev->device == PCI_DEVICE_ID_NX2_5708) ||
        (dev->device == PCI_DEVICE_ID_NX2_5708S) ||
        ((dev->device == PCI_DEVICE_ID_NX2_5709) &&
Signature · 1 line
1.5.2.5