Skip to contentSkip to conversation

T60p not coming out of suspend to RAM since 2.6.27-rc1

DISCUSSION Michael S. Tsirkin 2 participants 2 messages Aug 7, 2008 – Aug 8, 2008

lore
Share & tools
lore
#0 lore raw

In both 2.6.27-rc1 and 2.6.27-rc2, my laptop won't come out of suspend to ram: it blinks the crescent one or twice, and hangs. It does resume fine under 2.6.26.

I bisected the problem and got the following commit:

commit ce6fce4295ba727b36fdc73040e444bd1aae64cd

Author: Matthew Wilcox <[email protected]>
Date:   Fri Jul 25 15:42:58 2008 -0600

PCI MSI: Don't disable MSIs if the mask bit isn't supported

David Vrabel has a device which generates an interrupt storm on the INTx pin if we disable MSI interrupts altogether. Masking interrupts is only a performance optimisation, so we can ignore the request to mask the interrupt.

Reverting ce6fce4295ba727b36fdc73040e444bd1aae64cd fixes resume from suspend to RAM for me.

Steps to reproduce:

Press Fn-F4 to suspend, press Fn to resume.
This works on 2.6.26, hangs on vanilla 2.6.27-rc1 and 2.6.27-rc2, works on 2.6.27-rc2 with reverted ce6fce..

Bug added to bugzilla: http://bugzilla.kernel.org/show_bug.cgi?id=11283

Signature · 1 line
MST
#1 lore raw
Quoted 23 lines · Michael S. Tsirkin

In both 2.6.27-rc1 and 2.6.27-rc2, my laptop won't come out of suspend to ram: it blinks the crescent one or twice, and hangs. It does resume fine under 2.6.26.

I bisected the problem and got the following commit:

commit ce6fce4295ba727b36fdc73040e444bd1aae64cd

Author: Matthew Wilcox <[email protected]>
Date:   Fri Jul 25 15:42:58 2008 -0600

PCI MSI: Don't disable MSIs if the mask bit isn't supported

David Vrabel has a device which generates an interrupt storm on the
INTx pin if we disable MSI interrupts altogether. Masking interrupts is only a performance optimisation, so we can ignore the request to mask the interrupt.

Reverting ce6fce4295ba727b36fdc73040e444bd1aae64cd fixes resume from suspend to RAM for me.

Quoted 7 lines

Steps to reproduce:

Press Fn-F4 to suspend, press Fn to resume.
This works on 2.6.26, hangs on vanilla 2.6.27-rc1 and 2.6.27-rc2, works on 2.6.27-rc2 with reverted ce6fce..

Bug added to bugzilla: http://bugzilla.kernel.org/show_bug.cgi?id=11283

I noted in the bug that I think this is a duplicate. Can you try pulling my for-linus branch into your tree to see if it fixes things for you?

git pull git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci-2.6.git for-linus

from inside your kernel tree should do it.

Thanks,
Jesse