PATCH] trivial xfs_remove comment fixup

PATCH Christoph Hellwig 3 participants 4 messages Aug 7, 2008 – Oct 21, 2008 XFS filesystem

Share & tools

Christoph Hellwig

author

2008-08-07 21:57 UTC #0 lore raw

The dp to ip comment should be for the unconditional xfs_droplink call, and the "." link obviously only exists for directories, so it should be in the is_dir conditional.

Signed-off-by Christoph Hellwig <[email protected]>

fs/xfs/xfs_vnodeops.c +2 -2

Index: linux-2.6-xfs/fs/xfs/xfs_vnodeops.c
===================================================================
@@ -2014,7 +2014,7 @@ xfs_remove(
 			goto out_bmap_cancel;
 
 		/*
-		 * Drop the link from dp to ip.
+		 * Drop the "." link from ip to self.
 		 */
 		error = xfs_droplink(tp, ip);
 		if (error)

@@ -2029,7 +2029,7 @@ xfs_remove(
 	}
 
 	/*
-	 * Drop the "." link from ip to self.
+	 * Drop the link from dp to ip.
 	 */
 	error = xfs_droplink(tp, ip);
 	if (error)

Dave Chinner

2008-08-08 00:32 UTC #1 lore raw

Quoted 3 lines · Christoph Hellwig

The dp to ip comment should be for the unconditional xfs_droplink call, and the "." link obviously only exists for directories, so it should be in the is_dir conditional.

Ack.

Cheers,

Dave.

Signature · 2 lines

Dave Chinner
[email protected]

Christoph Hellwig

author

2008-10-18 12:34 UTC #2 lore raw

Re: [PATCH] trivial xfs_remove comment fixup

In reply to Christoph Hellwig

Ping? This is just a trivial comment fixup, shouldn't be that hard to review..

Quoted 20 lines · Christoph Hellwig

The dp to ip comment should be for the unconditional xfs_droplink call, and the "." link obviously only exists for directories, so it should be in the is_dir conditional.
Signed-off-by Christoph Hellwig <[email protected]>
Index: linux-2.6-xfs/fs/xfs/xfs_vnodeops.c
===================================================================
fs/xfs/xfs_vnodeops.c +1 -1
@@ -2014,7 +2014,7 @@ xfs_remove(
 			goto out_bmap_cancel;
 
 		/*
-		 * Drop the link from dp to ip.
+		 * Drop the "." link from ip to self.
 		 */
 		error = xfs_droplink(tp, ip);
 		if (error)

fs/xfs/xfs_vnodeops.c xfs_remove( · line 2035

Quoted 8 lines

fs/xfs/xfs_vnodeops.c +1 -1

@@ -2029,7 +2029,7 @@ xfs_remove(
 	}
 
 	/*
-	 * Drop the "." link from ip to self.
+	 * Drop the link from dp to ip.
 	 */
 	error = xfs_droplink(tp, ip);
 	if (error)

---end quoted text---

Donald Douwsma

2008-10-21 07:34 UTC #3 lore raw

Re: [PATCH] trivial xfs_remove comment fixup

Quoted 2 lines · Christoph Hellwig

Ping? This is just a trivial comment fixup, shouldn't be that hard to review..

This is to cleanup the comments from the xfs_rmd -> xfs_remove merge. Ok then, its in.

Quoted 32 lines · Christoph Hellwig

Quoted 20 lines
The dp to ip comment should be for the unconditional xfs_droplink call, and the "." link obviously only exists for directories, so it should be in the is_dir conditional.
Signed-off-by Christoph Hellwig <[email protected]>
Index: linux-2.6-xfs/fs/xfs/xfs_vnodeops.c
===================================================================
fs/xfs/xfs_vnodeops.c +1 -1
@@ -2014,7 +2014,7 @@ xfs_remove(
 			goto out_bmap_cancel;
 
 		/*
-		 * Drop the link from dp to ip.
+		 * Drop the "." link from ip to self.
 		 */
 		error = xfs_droplink(tp, ip);
 		if (error)
fs/xfs/xfs_vnodeops.c xfs_remove( · line 2035
Quoted 8 lines
fs/xfs/xfs_vnodeops.c +1 -1
@@ -2029,7 +2029,7 @@ xfs_remove(
 	}
 
 	/*
-	 * Drop the "." link from ip to self.
+	 * Drop the link from dp to ip.
 	 */
 	error = xfs_droplink(tp, ip);
 	if (error)
---end quoted text---