ide: remove M68K_IDE_SWAPW define from <asm-m68k/ide.h>

PATCH In review Bartlomiej Zolnierkiewicz 2 participants 2 messages Aug 10, 2008 libata

Share & tools

Bartlomiej Zolnierkiewicz

author

2008-08-10 15:49 UTC #0 lore raw

PATCH 1/1 ide: remove M68K_IDE_SWAPW define from <asm-m68k/ide.h>

Since we solved this by overriding default ->{in,out}put_data methods in {q40,falcon}ide M68K_IDE_SWAP define can go away.

Cc Geert Uytterhoeven <[email protected]>

Cc Roman Zippel <[email protected]>

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

---
 include/asm-m68k/ide.h |    9 ---------
 1 file changed, 9 deletions(-)

include/asm-m68k/ide.h +0 -9

Index: b/include/asm-m68k/ide.h
===================================================================
@@ -92,15 +92,6 @@
 #define outsw_swapw(port, addr, n)	raw_outsw_swapw((u16 *)port, addr, n)
 #endif
 
-
-/* Q40 and Atari have byteswapped IDE busses and since many interesting
- * values in the identification string are text, chars and words they
- * happened to be almost correct without swapping.. However *_capacity
- * is needed for drives over 8 GB. RZ */
-#if defined(CONFIG_Q40) || defined(CONFIG_ATARI)
-#define M68K_IDE_SWAPW  (MACH_IS_Q40 || MACH_IS_ATARI)
-#endif
-
 #ifdef CONFIG_BLK_DEV_FALCON_IDE
 #define IDE_ARCH_LOCK

Geert Uytterhoeven

Acked-by on v1 1/1

2008-08-10 18:16 UTC #1 lore raw

Quoted 6 lines · Bartlomiej Zolnierkiewicz

Since we solved this by overriding default ->{in,out}put_data methods in {q40,falcon}ide M68K_IDE_SWAP define can go away.
Cc Geert Uytterhoeven <[email protected]>
Cc Roman Zippel <[email protected]>
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

Acked-by Geert Uytterhoeven <[email protected]>

Quoted 13 lines

---
 include/asm-m68k/ide.h |    9 ---------
 1 file changed, 9 deletions(-)
Index: b/include/asm-m68k/ide.h
===================================================================
include/asm-m68k/ide.h +0 -1
@@ -92,15 +92,6 @@
 #define outsw_swapw(port, addr, n)	raw_outsw_swapw((u16 *)port, addr, n)
 #endif
 
-

include/asm-m68k/ide.h line 96

Quoted 10 lines

include/asm-m68k/ide.h +0 -8

-/* Q40 and Atari have byteswapped IDE busses and since many interesting
- * values in the identification string are text, chars and words they
- * happened to be almost correct without swapping.. However *_capacity
- * is needed for drives over 8 GB. RZ */
-#if defined(CONFIG_Q40) || defined(CONFIG_ATARI)
-#define M68K_IDE_SWAPW  (MACH_IS_Q40 || MACH_IS_ATARI)
-#endif
-
 #ifdef CONFIG_BLK_DEV_FALCON_IDE
 #define IDE_ARCH_LOCK

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds